organicmaps/icu
13
Fork 0
mirror of https://github.com/unicode-org/icu.git synced 2025-04-13 17:01:16 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions 3

ICU-5410 Improve code coverage, and fix some logically impossible code to call.

Browse source 
X-SVN-Rev: 20671
This commit is contained in:
George Rhoten 2006-11-16 19:38:37 +00:00
parent 46cd2a0d94
commit 13f3bd0a24
1 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
icu4c/source/i18n/coleitr.cpp
View file

@ -86,11 +86,7 @@ UBool CollationElementIterator::operator!=(
UBool CollationElementIterator::operator==(
const CollationElementIterator& that) const
{
if (this == &that) {
return TRUE;
}
if (m_data_ == that.m_data_) {
if (this == &that || m_data_ == that.m_data_) {
return TRUE;
}
@ -123,7 +119,7 @@ UBool CollationElementIterator::operator==(
// checking normalization buffer
if ((m_data_->iteratordata_.flags & UCOL_ITER_HASLEN) == 0) {
if ((m_data_->iteratordata_.flags & UCOL_ITER_HASLEN) != 0) {
if ((that.m_data_->iteratordata_.flags & UCOL_ITER_HASLEN) != 0) {
return FALSE;
}
// both are in the normalization buffer
@ -135,7 +131,7 @@ UBool CollationElementIterator::operator==(
return FALSE;
}
}
else if ((m_data_->iteratordata_.flags & UCOL_ITER_HASLEN) == 0) {
else if ((that.m_data_->iteratordata_.flags & UCOL_ITER_HASLEN) == 0) {
return FALSE;
}
// checking ce position