organicmaps/icu
13
Fork 0
mirror of https://github.com/unicode-org/icu.git synced 2025-04-06 14:05:32 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions 8

ICU-22761 Optimize get value of LocaleObjectCache

Browse source 
See #2984
This commit is contained in:
imurluck 2024-04-29 12:54:49 +00:00 • committed by Markus Scherer
parent 22ff260c76
commit 1c33fcf81d
1 changed files with 23 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
icu4j/main/core/src/main/java/com/ibm/icu/impl/locale/LocaleObjectCache.java
View file

@ -34,24 +34,34 @@ public abstract class LocaleObjectCache<K, V> {
}
if (value == null) {
key = normalizeKey(key);
// subclass must return non-null key object
if (key == null) {
return null;
}
entry = _map.get(key);
if (entry != null) {
value = entry.get();
}
// hit cache
if (value != null) {
return value;
}
// if map not contains key or the referent value of CacheEntry is set to be null
// both need create a new value
V newVal = createObject(key);
if (key == null || newVal == null) {
// subclass must return non-null key/value object
if (newVal == null) {
// subclass must return non-null value object
return null;
}
CacheEntry<K, V> newEntry = new CacheEntry<K, V>(key, newVal, _queue);
while (value == null) {
cleanStaleEntries();
entry = _map.putIfAbsent(key, newEntry);
if (entry == null) {
value = newVal;
break;
} else {
value = entry.get();
}
}
// just replace it
_map.put(key, newEntry);
// clean recycled SoftReferences again
cleanStaleEntries();
return newVal;
}
return value;
}