ICU-5170 compiler warning cleanup

X-SVN-Rev: 19596

icu4c/source/common/ubrk.cpp

@@ -17,6 +17,7 @@
 #include "unicode/uchriter.h"
 #include "unicode/rbbi.h"
 #include "rbbirb.h"
+#include "uassert.h"
 
 U_NAMESPACE_USE
 
@@ -59,6 +60,9 @@ ubrk_open(UBreakIteratorType type,
   case UBRK_TITLE:
     result = BreakIterator::createTitleInstance(Locale(locale), *status);
     break;
+
+  default:
+    U_ASSERT(FALSE);
   }
 
   // check for allocation error

icu4c/source/common/unicode/brkiter.h

@@ -146,7 +146,7 @@ public:
      * Return a CharacterIterator over the text being analyzed.
      * @stable ICU 2.0
      */
-    virtual const CharacterIterator& getText(void) const = 0;
+    virtual CharacterIterator& getText(void) const = 0;
 
 
     /**

icu4c/source/common/unicode/rbbi.h

@@ -301,7 +301,12 @@ public:
      * rules for thread safety in ICU, which are that const functions are
      * thread safe.
      * <p/>
-     * The function getUText() provides similar functionality, and is more efficient.
+     * When the break iterator is operating on text supplied via a UText,
+     * this function will fail.  Lacking any way to signal failures, it
+     * returns an CharacterIterator containing no text in this case.
+     * The function getUText() provides similar functionality,
+     * is reliable, and is more efficient.
+     *
      * TODO:  deprecate this function?
      *
      * @return An iterator over the text being analyzed.

icu4c/source/test/intltest/rbbitst.cpp

@@ -1344,7 +1344,7 @@ void RBBITest::executeTest(TestParams *t) {
             if (rs != expectedTagVal) {
                 errln("Incorrect status for reverse break.  Pos=%4d  File line,col= %4d,%4d.\n"
                       "          Actual, Expected status = %4d, %4d",
-                    bp, t->srcLine->elementAti(bp), t->srcCol->elementAti(bp), rs, expectedTagVal);
+                    bp, line, t->srcCol->elementAti(bp), rs, expectedTagVal);
             }
         }