organicmaps/icu
13
Fork 0
mirror of https://github.com/unicode-org/icu.git synced 2025-04-13 08:53:20 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions 2

ICU-13102 - Add logKnownIssue and skip problematic locales in format/DateFormatTest/TestHost for now.

Browse source 
X-SVN-Rev: 40014
This commit is contained in:
Jeff Genovy 2017-04-08 02:22:19 +00:00
parent a10ddb166a
commit 2a722c9b5a
2 changed files with 20 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
icu4c/source/test/intltest/windttst.cpp
View file

@ -28,6 +28,8 @@
#include "winutil.h"
#include "windttst.h"
#include "dtfmttst.h"
#include "cmemory.h"
#include "cstring.h"
#include "locmap.h"
@ -66,7 +68,7 @@ static const char *getCalendarType(int32_t type)
}
}
void Win32DateTimeTest::testLocales(TestLog *log)
void Win32DateTimeTest::testLocales(DateFormatTest *log)
{
SYSTEMTIME winNow;
UDate icuNow = 0;
@ -118,6 +120,21 @@ void Win32DateTimeTest::testLocales(TestLog *log)
continue;
}
// Some locales have had their names change over various OS releases; skip them in the test for now.
int32_t failingLocaleLCIDs[] = {
0x040a, /* es-ES_tradnl;es-ES-u-co-trad; */
0x048c, /* fa-AF;prs-AF;prs-Arab-AF; */
0x046b, /* qu-BO;quz-BO;quz-Latn-BO; */
0x086b, /* qu-EC;quz-EC;quz-Latn-EC; */
0x0c6b, /* qu-PE;quz-PE;quz-Latn-PE; */
0x0492 /* ckb-IQ;ku-Arab-IQ; */
};
bool skip = (std::find(std::begin(failingLocaleLCIDs), std::end(failingLocaleLCIDs), lcidRecords[i].lcid) != std::end(failingLocaleLCIDs));
if (skip && log->logKnownIssue("13119", "Windows '@compat=host' fails on down-level versions of the OS")) {
log->logln("ticket:13119 - Skipping LCID = 0x%04x", lcidRecords[i].lcid);
continue;
}
GetLocaleInfoW(lcidRecords[i].lcid, LOCALE_SLONGDATE, longDateFormat, 81);
GetLocaleInfoW(lcidRecords[i].lcid, LOCALE_STIMEFORMAT, longTimeFormat, 81);
GetLocaleInfoW(lcidRecords[i].lcid, LOCALE_RETURN_NUMBER|LOCALE_ICALENDARTYPE, (LPWSTR) calType, sizeof(int32_t));

4
icu4c/source/test/intltest/windttst.h
View file

@ -25,12 +25,12 @@
* \brief C++ API: Format dates using Windows API.
*/
class TestLog;
class DateFormatTest;
class Win32DateTimeTest
{
public:
static void testLocales(TestLog *log);
static void testLocales(DateFormatTest *log);
private:
Win32DateTimeTest();