ICU-359 fixed virtual destructors/members incoherences.

X-SVN-Rev: 1142

icu4c/source/common/digitlst.h

@@ -52,8 +52,7 @@
 class U_COMMON_API DigitList { // Declare external to make compiler happy
 public:
     DigitList();
-
-    ~DigitList(); // Make this virtual if subclassing is desired later
+    ~DigitList();
 
     DigitList(const DigitList&); // copy constructor
 
@@ -76,13 +75,13 @@ public:
      * you hit the decimal point, you set myDigitList.fDecimalAt = myDigitList.fCount;
      * then go on appending digits.
      */
-    virtual void clear(void);
+    void clear(void);
 
     /**
      * Appends digits to the list. Ignores all digits beyond the first DBL_DIG,
      * since they are not significant for either longs or doubles.
      */
-    virtual void append(char digit);
+    void append(char digit);
 
     /**
      * Utility routine to get the value of the digit list

icu4c/source/i18n/digitlst.h

@@ -52,8 +52,7 @@
 class U_COMMON_API DigitList { // Declare external to make compiler happy
 public:
     DigitList();
-
-    ~DigitList(); // Make this virtual if subclassing is desired later
+    ~DigitList();
 
     DigitList(const DigitList&); // copy constructor
 
@@ -76,13 +75,13 @@ public:
      * you hit the decimal point, you set myDigitList.fDecimalAt = myDigitList.fCount;
      * then go on appending digits.
      */
-    virtual void clear(void);
+    void clear(void);
 
     /**
      * Appends digits to the list. Ignores all digits beyond the first DBL_DIG,
      * since they are not significant for either longs or doubles.
      */
-    virtual void append(char digit);
+    void append(char digit);
 
     /**
      * Utility routine to get the value of the digit list

icu4c/source/i18n/unicode/coleitr.h

@@ -99,13 +99,13 @@ public:
      * Returns true if "other" is the same as "this"
      * @stable
      */
-    virtual     bool_t          operator==(const CollationElementIterator& other) const;
+    bool_t          operator==(const CollationElementIterator& other) const;
 
     /**
      * Returns true if "other" is not the same as "this".
      * @stable
      */
-    virtual     bool_t          operator!=(const CollationElementIterator& other) const;
+    bool_t          operator!=(const CollationElementIterator& other) const;
 
     /**
      * Resets the cursor to the beginning of the string.

icu4c/source/test/intltest/allcoll.h

@@ -35,7 +35,7 @@ public:
     enum EToken_Len { MAX_TOKEN_LEN = 128 };
 
     CollationDummyTest();
-    ~CollationDummyTest();
+    virtual ~CollationDummyTest();
     void runIndexedTest( int32_t index, bool_t exec, char* &name, char* par = NULL );
 
     // main test method called with different strengths,

icu4c/source/test/intltest/currcoll.h

@@ -39,8 +39,7 @@ public:
     enum EToken_Len { MAX_TOKEN_LEN = 16 };
 
     CollationCurrencyTest();
-    ~CollationCurrencyTest();
-
+    virtual ~CollationCurrencyTest();
     void runIndexedTest(int32_t index, bool_t exec, char* &name, char* par = NULL);
 
     void currencyTest(char *par);

icu4c/source/test/intltest/dacoll.h

@@ -32,7 +32,7 @@ public:
     enum EToken_Len { MAX_TOKEN_LEN = 128 };
 
     CollationDanishTest();
-    ~CollationDanishTest();
+    virtual ~CollationDanishTest();
     void runIndexedTest( int32_t index, bool_t exec, char* &name, char* par = NULL );
 
     // main test routine, Tests rules specific to danish collation

icu4c/source/test/intltest/decoll.h

@@ -30,7 +30,7 @@ public:
     enum EToken_Len { MAX_TOKEN_LEN = 128 };
 
     CollationGermanTest();
-    ~CollationGermanTest();
+    virtual ~CollationGermanTest();
     void runIndexedTest( int32_t index, bool_t exec, char* &name, char* par = NULL );
 
     //main test routine, tests rules specific to germa locale

icu4c/source/test/intltest/encoll.h

@@ -32,7 +32,7 @@ public:
     enum EToken_Len { MAX_TOKEN_LEN = 128 };
 
     CollationEnglishTest();
-    ~CollationEnglishTest();
+    virtual ~CollationEnglishTest();
     void runIndexedTest( int32_t index, bool_t exec, char* &name, char* par = NULL );
 
     // main test routine, tests rules defined by the "en" locale

icu4c/source/test/intltest/escoll.h

@@ -32,7 +32,7 @@ public:
     enum EToken_Len { MAX_TOKEN_LEN = 128 };
 
     CollationSpanishTest();
-    ~CollationSpanishTest();
+    virtual ~CollationSpanishTest();
     void runIndexedTest( int32_t index, bool_t exec, char* &name, char* par = NULL );
 
     // amin test routine, tests rules specific to the spanish locale

icu4c/source/test/intltest/ficoll.h

@@ -31,7 +31,7 @@ public:
     enum EToken_Len { MAX_TOKEN_LEN = 128 };
 
     CollationFinnishTest();
-    ~CollationFinnishTest();
+    virtual ~CollationFinnishTest();
     void runIndexedTest( int32_t index, bool_t exec, char* &name, char* par = NULL );
 
     // main test routine, tests rules specific to the finish locale

icu4c/source/test/intltest/frcoll.h

@@ -30,7 +30,7 @@ public:
     enum EToken_Len { MAX_TOKEN_LEN = 128 };
 
     CollationFrenchTest();
-    ~CollationFrenchTest();
+    virtual ~CollationFrenchTest();
     void runIndexedTest( int32_t index, bool_t exec, char* &name, char* par = NULL );
 
     // amin test routine, test rules specific to the french locale

icu4c/source/test/intltest/g7coll.h

@@ -56,7 +56,7 @@ public:
     enum ETotal_Test { TOTALTESTSET = 30 };
 
     G7CollationTest() {}
-    ~G7CollationTest() {}
+    virtual ~G7CollationTest() {}
     void runIndexedTest( int32_t index, bool_t exec, char* &name, char* par = NULL );
 
     // main test routine, tests comparisons for a set of strings against sets of expected results

icu4c/source/test/intltest/isocoll.h

@@ -34,7 +34,7 @@ public:
     enum EToken_Len { MAX_TOKEN_LEN = 5 };
 
     CollationISOTest();
-    ~CollationISOTest();
+    virtual ~CollationISOTest();
     void runIndexedTest( int32_t index, bool_t exec, char* &name, char* par = NULL );
 
     // test proper comparing for 3774 entries of ISO 14651 characters

icu4c/source/test/intltest/itercoll.h

@@ -43,7 +43,7 @@ public:
     enum EToken_Len { MAX_TOKEN_LEN = 128 };
 
     CollationIteratorTest();
-    ~CollationIteratorTest();
+    virtual ~CollationIteratorTest();
 
     void runIndexedTest(int32_t index, bool_t exec, char* &name, char* par = NULL);
 

icu4c/source/test/intltest/jacoll.h

@@ -31,7 +31,7 @@ public:
     enum EToken_Len { MAX_TOKEN_LEN = 128 };
 
     CollationKanaTest();
-    ~CollationKanaTest();
+    virtual ~CollationKanaTest();
     void runIndexedTest( int32_t index, bool_t exec, char* &name, char* par = NULL );
 
     // main test routine, tests rules specific to "Kana" locale

icu4c/source/test/intltest/regcoll.h

@@ -39,7 +39,7 @@ public:
     enum EToken_Len { MAX_TOKEN_LEN = 128 };
 
     CollationRegressionTest();
-    ~CollationRegressionTest();
+    virtual ~CollationRegressionTest();
 
     void runIndexedTest( int32_t index, bool_t exec, char* &name, char* par = NULL );
 

icu4c/source/test/intltest/thcoll.h

@@ -19,8 +19,7 @@ class CollationThaiTest : public IntlTest {
 public:
 
     CollationThaiTest();
-
-    ~CollationThaiTest();
+    virtual ~CollationThaiTest();
 
     void runIndexedTest( int32_t index, bool_t exec, char* &name, char* par = NULL );
     

icu4c/source/test/intltest/trcoll.h

@@ -30,7 +30,7 @@ public:
     enum EToken_Len { MAX_TOKEN_LEN = 128 };
 
     CollationTurkishTest();
-    ~CollationTurkishTest();
+    virtual ~CollationTurkishTest();
     void runIndexedTest( int32_t index, bool_t exec, char* &name, char* par = NULL );
 
     // main test routine, tests rules specific to turkish locale