From 3a41fdc00744d47f00e139277f03c7c4b9a17d4d Mon Sep 17 00:00:00 2001 From: Yoshito Umaoka Date: Mon, 23 Sep 2013 18:14:29 +0000 Subject: [PATCH] ICU-10399 Some updates for the eclipse plug-in version. Resolve some compiler warnings, updated the build version. X-SVN-Rev: 34456 --- icu4j/eclipse-build/build.properties | 2 +- .../src/com/ibm/icu/impl/TimeZoneGenericNames.java | 3 ++- .../core/src/com/ibm/icu/text/TimeZoneFormat.java | 14 +++++++++++++- 3 files changed, 16 insertions(+), 3 deletions(-) diff --git a/icu4j/eclipse-build/build.properties b/icu4j/eclipse-build/build.properties index 4f57f498d76..2d41643a6a8 100644 --- a/icu4j/eclipse-build/build.properties +++ b/icu4j/eclipse-build/build.properties @@ -2,6 +2,6 @@ #* Copyright (C) 2010-2013, International Business Machines Corporation and * #* others. All Rights Reserved. * #******************************************************************************* -icu4j.plugin.impl.version.string=52.0.1 +icu4j.plugin.impl.version.string=52.1.0 copyright.eclipse=Licensed Materials - Property of IBM \n (C) Copyright IBM Corp. 2000, 2013. All Rights Reserved. \n IBM is a registered trademark of IBM Corp. icu4j.data.version.number=52 diff --git a/icu4j/main/classes/core/src/com/ibm/icu/impl/TimeZoneGenericNames.java b/icu4j/main/classes/core/src/com/ibm/icu/impl/TimeZoneGenericNames.java index ffcaf78cf22..e1c60830e91 100644 --- a/icu4j/main/classes/core/src/com/ibm/icu/impl/TimeZoneGenericNames.java +++ b/icu4j/main/classes/core/src/com/ibm/icu/impl/TimeZoneGenericNames.java @@ -797,8 +797,9 @@ public class TimeZoneGenericNames implements Serializable, Freezable case ISO_EXTENDED_LOCAL_FULL: result = formatOffsetISO8601Extended(offset, false, false, false); break; + + default: + // Other cases are handled earlier and never comes into this + // switch statement. + assert false; + break; } // time type if (timeType != null) { @@ -1189,6 +1195,10 @@ public class TimeZoneFormat extends UFormat implements Freezable case GENERIC_SHORT: genericNameTypes = EnumSet.of(GenericNameType.SHORT, GenericNameType.LOCATION); break; + default: + // style cannot be other than above cases + assert false; + break; } GenericMatchInfo bestGeneric = getTimeZoneGenericNames().findBestMatch(text, startIdx, genericNameTypes); if (bestGeneric != null && (startIdx + bestGeneric.matchLength() > parsedPos)) { @@ -1787,8 +1797,10 @@ public class TimeZoneFormat extends UFormat implements Freezable case LONG_DAYLIGHT: case SHORT_DAYLIGHT: return TimeType.DAYLIGHT; + + default: + return TimeType.UNKNOWN; } - return TimeType.UNKNOWN; } /**