From 501fe1b74a6027709cb72e6b58fba189db541fd6 Mon Sep 17 00:00:00 2001
From: Mihai Nita <mnita@google.com>
Date: Wed, 20 Sep 2023 11:59:07 -0700
Subject: [PATCH] ICU-22324 Mavenization, preparing for maven central
 deployment

---
 icu4j/.gitignore                            |   2 +
 icu4j/main/charset/pom.xml                  |   8 +-
 icu4j/main/icu4j/pom.xml                    |  66 ++++++++-
 icu4j/main/icu4j/src/main/resources/LICENSE |   1 +
 icu4j/main/localespi/pom.xml                |  46 ++++++-
 icu4j/pom.xml                               | 144 +++++++++++++++++---
 6 files changed, 234 insertions(+), 33 deletions(-)
 create mode 120000 icu4j/main/icu4j/src/main/resources/LICENSE

diff --git a/icu4j/.gitignore b/icu4j/.gitignore
index 6a2573b3a54..11cee88cc3e 100644
--- a/icu4j/.gitignore
+++ b/icu4j/.gitignore
@@ -1 +1,3 @@
 /release_cldr
+**/dependency-reduced-pom.xml
+
diff --git a/icu4j/main/charset/pom.xml b/icu4j/main/charset/pom.xml
index 630350a957e..c58e50eeb8e 100644
--- a/icu4j/main/charset/pom.xml
+++ b/icu4j/main/charset/pom.xml
@@ -22,7 +22,7 @@
   <dependencies>
     <dependency>
       <groupId>com.ibm.icu</groupId>
-      <artifactId>core</artifactId>
+      <artifactId>icu4j</artifactId>
       <version>${project.version}</version>
     </dependency>
 
@@ -68,6 +68,12 @@
           </archive>
         </configuration>
       </plugin>
+      <plugin>
+        <artifactId>maven-deploy-plugin</artifactId>
+        <configuration>
+          <skip>false</skip>
+        </configuration>
+      </plugin>
     </plugins>
   </build>
 
diff --git a/icu4j/main/icu4j/pom.xml b/icu4j/main/icu4j/pom.xml
index c01d56d1eec..20fc1b8b0b0 100644
--- a/icu4j/main/icu4j/pom.xml
+++ b/icu4j/main/icu4j/pom.xml
@@ -66,6 +66,15 @@
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-shade-plugin</artifactId>
         <executions>
+          <execution>
+            <id>source-jar</id>
+            <goals>
+              <goal>shade</goal>
+            </goals>
+            <configuration>
+              <createSourcesJar>true</createSourcesJar>
+            </configuration>
+          </execution>
           <execution>
             <goals>
               <goal>shade</goal>
@@ -75,22 +84,65 @@
               <createDependencyReducedPom>true</createDependencyReducedPom>
               <dependencyReducedPomLocation>${project.build.directory}/dependency-reduced-pom.xml</dependencyReducedPomLocation>
               <promoteTransitiveDependencies>true</promoteTransitiveDependencies>
+              <transformers>
+                <transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
+                  <manifestEntries>
+                    <Main-Class>com.ibm.icu.util.VersionInfo</Main-Class>
+                    <Export-Package>com.ibm.icu.lang,com.ibm.icu.math,com.ibm.icu.number,com.ibm.icu.text,com.ibm.icu.util</Export-Package>
+                  </manifestEntries>
+                </transformer>
+              </transformers>
             </configuration>
           </execution>
         </executions>
       </plugin>
       <plugin>
-        <artifactId>maven-jar-plugin</artifactId>
+        <artifactId>maven-clean-plugin</artifactId>
         <configuration>
-          <archive>
-            <manifestEntries>
-              <Main-Class>com.ibm.icu.util.VersionInfo</Main-Class>
-              <Export-Package>com.ibm.icu.lang,com.ibm.icu.math,com.ibm.icu.number,com.ibm.icu.text,com.ibm.icu.util</Export-Package>
-            </manifestEntries>
-          </archive>
+          <filesets>
+            <fileset>
+              <directory>.</directory>
+              <includes>
+                <include>**/dependency-reduced-pom.xml</include>
+              </includes>
+              <followSymlinks>false</followSymlinks>
+            </fileset>
+          </filesets>
+        </configuration>
+      </plugin>
+      <plugin>
+        <artifactId>maven-deploy-plugin</artifactId>
+        <configuration>
+          <skip>false</skip>
         </configuration>
       </plugin>
     </plugins>
   </build>
 
+  <profiles>
+    <profile>
+      <id>with_javadoc</id>
+      <build>
+        <plugins>
+          <plugin>
+            <artifactId>maven-javadoc-plugin</artifactId>
+            <executions>
+              <execution>
+                <goals>
+                  <goal>jar</goal>
+                </goals>
+                <configuration>
+                  <!-- This is important. Since this is a shaded jar with no sources,
+                    there is no javadoc generated without this line.
+                  -->
+                  <includeDependencySources>true</includeDependencySources>
+                </configuration>
+              </execution>
+            </executions>
+          </plugin>
+        </plugins>
+      </build>
+    </profile>
+  </profiles>
+
 </project>
diff --git a/icu4j/main/icu4j/src/main/resources/LICENSE b/icu4j/main/icu4j/src/main/resources/LICENSE
new file mode 120000
index 00000000000..ee8b6feb8cc
--- /dev/null
+++ b/icu4j/main/icu4j/src/main/resources/LICENSE
@@ -0,0 +1 @@
+../../../../../../LICENSE
\ No newline at end of file
diff --git a/icu4j/main/localespi/pom.xml b/icu4j/main/localespi/pom.xml
index 3d4dd2de7fa..0cfac910155 100644
--- a/icu4j/main/localespi/pom.xml
+++ b/icu4j/main/localespi/pom.xml
@@ -81,10 +81,10 @@
         </configuration>
       </plugin>
 
-      <!-- 
+      <!--
         Mainly for running localespi tests in Java 8:
         The easiest way to get the integration tests to pass (in particular, to get the JVM that is
-        spawned with the `-Djava.ext.dirs` system property value to be interpreted properly in order 
+        spawned with the `-Djava.ext.dirs` system property value to be interpreted properly in order
         for the extensions jars therein to be loaded correctly) was to copy the jars needed to a
         separate directory. (The alternative of pointing to the build directories of the respective
         submodules didn't seem to work.)
@@ -142,7 +142,7 @@
             <include>**/*ITCase.java</include>
           </includes>
 
-          <!-- 
+          <!--
             For Java 8:
             Set up the locale service provider using the .jar file of `icu4j-localespi` main code from the `package` phase
 
@@ -150,7 +150,7 @@
             Using the `java.ext.dirs` special Java system property on Java 9+ runtimes triggers an
              error that tells the user to place those jars on the classpath instead.
           -->
-          <!-- 
+          <!--
               Notes:
 
               https://stackoverflow.com/a/5039973/2077918
@@ -169,7 +169,7 @@
           -->
           <argLine>${localespi-tests.jvm.args}</argLine>
 
-          <!-- 
+          <!--
               For Java 9+:
               Configure to use the locale service provider using the .jar file of `icu4j-localespi` main code from the `package` phase
 
@@ -183,11 +183,18 @@
         </configuration>
       </plugin>
 
+      <plugin>
+        <artifactId>maven-deploy-plugin</artifactId>
+        <configuration>
+          <skip>false</skip>
+        </configuration>
+      </plugin>
+
     </plugins>
   </build>
 
   <profiles>
-    <!-- 
+    <!--
       For testing localespi using the Java extensions feature, which last existed in Java 8.
       ICU4J currently has a minimum supported version of 8.
     -->
@@ -215,6 +222,33 @@
         <localespi-tests.locale-providers>CLDR,COMPAT,SPI</localespi-tests.locale-providers>
       </properties>
     </profile>
+    <profile>
+      <id>with_javadoc</id>
+      <build>
+        <plugins>
+          <plugin>
+            <artifactId>maven-javadoc-plugin</artifactId>
+            <executions>
+              <execution>
+                <goals>
+                  <goal>jar</goal>
+                </goals>
+                <configuration>
+                  <!-- All files in com/ibm/icu/impl folders are exluded from javadoc.
+                    So we need to bring back this one file, to match the previously published artifacts.
+                    Without this all java files are excluded and no javadoc is generated.
+                  -->
+                  <sourceFileIncludes>
+                    <include>ICULocaleServiceProvider.java</include>
+                  </sourceFileIncludes>
+                  <sourcepath>${basedir}/src/main/java/com/ibm/icu/impl/javaspi</sourcepath>
+                </configuration>
+              </execution>
+            </executions>
+          </plugin>
+        </plugins>
+      </build>
+    </profile>
   </profiles>
 
 </project>
diff --git a/icu4j/pom.xml b/icu4j/pom.xml
index 95f4ba4e178..3755fde4a6f 100644
--- a/icu4j/pom.xml
+++ b/icu4j/pom.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!--
-* © 2023 and later: Unicode, Inc. and others.
+* © 2016 and later: Unicode, Inc. and others.
 * License & terms of use: http://www.unicode.org/copyright.html
 -->
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
@@ -12,8 +12,10 @@
   <packaging>pom</packaging>
 
   <name>${proj-title} (${project.artifactId})</name>
-  <description>International Component for Unicode for Java (ICU4J) is a mature, widely used Java library
+  <description>International Components for Unicode for Java (ICU4J) is a mature, widely used Java library
     providing Unicode and Globalization support</description>
+  <url>https://icu.unicode.org/</url>
+  <inceptionYear>1995</inceptionYear>
 
   <organization>
     <name>Unicode, Inc.</name>
@@ -33,6 +35,10 @@
     <maven.compiler.source>1.8</maven.compiler.source>
     <maven.compiler.target>1.8</maven.compiler.target>
 
+    <maven_central_repo_url>https://oss.sonatype.org</maven_central_repo_url>
+    <maven-central-releases-repo-url>${maven-central-repo-url}/service/local/staging/deploy/maven2</maven-central-releases-repo-url>
+    <maven-central-snapshots-repo-url>${maven-central-repo-url}/content/repositories/snapshots</maven-central-snapshots-repo-url>
+
     <junit.version>4.13.2</junit.version>
     <junitparams.version>1.1.1</junitparams.version>
 
@@ -76,7 +82,98 @@
     <mf.Bundle-Copyright>© 2016 and later: Unicode, Inc. and others. License &amp; terms of use: http://www.unicode.org/copyright.html</mf.Bundle-Copyright>
   </properties>
 
+  <licenses>
+    <license>
+      <name>Unicode/ICU License</name>
+      <url>https://raw.githubusercontent.com/unicode-org/icu/main/LICENSE</url>
+      <distribution>repo</distribution>
+    </license>
+  </licenses>
+
+  <developers>
+    <developer>
+      <id>markusicu</id>
+      <name>Markus Scherer</name>
+      <organization>Google</organization>
+      <roles>
+        <role>Chair</role>
+      </roles>
+    </developer>
+    <developer>
+      <id>yumaoka</id>
+      <name>Yoshito Umaoka</name>
+      <organization>IBM</organization>
+      <roles>
+        <role>Vice chair</role>
+      </roles>
+    </developer>
+  </developers>
+
+  <mailingLists>
+    <mailingList>
+      <name>icu-support</name>
+      <subscribe>https://lists.sourceforge.net/lists/listinfo/icu-support</subscribe>
+      <unsubscribe>https://lists.sourceforge.net/lists/listinfo/icu-support</unsubscribe>
+      <post>icu-support@lists.sourceforge.net</post>
+      <archive>http://sourceforge.net/mailarchive/forum.php?forum_name=icu-support</archive>
+    </mailingList>
+    <mailingList>
+      <name>icu-announce</name>
+      <subscribe>https://lists.sourceforge.net/lists/listinfo/icu-announce</subscribe>
+      <unsubscribe>https://lists.sourceforge.net/lists/listinfo/icu-announce</unsubscribe>
+      <post>icu-announce@lists.sourceforge.net</post>
+      <archive>http://sourceforge.net/mailarchive/forum.php?forum_name=icu-announce</archive>
+    </mailingList>
+    <mailingList>
+      <name>icu-design</name>
+      <subscribe>https://lists.sourceforge.net/lists/listinfo/icu-design</subscribe>
+      <unsubscribe>https://lists.sourceforge.net/lists/listinfo/icu-design</unsubscribe>
+      <post>icu-design@lists.sourceforge.net</post>
+      <archive>http://sourceforge.net/mailarchive/forum.php?forum_name=icu-design</archive>
+    </mailingList>
+  </mailingLists>
+
+  <scm>
+    <connection>scm:git:git://github.com/unicode-org/icu.git</connection>
+    <developerConnection>scm:git:git@github.com:unicode-org/icu.git</developerConnection>
+    <url>https://github.com/unicode-org/icu</url>
+  </scm>
+
+  <issueManagement>
+    <system>JIRA</system>
+    <url>https://unicode-org.atlassian.net/projects/ICU</url>
+  </issueManagement>
+
+  <distributionManagement>
+    <repository>
+      <id>icu4j-releases</id>
+      <name>ICU4J Central Repository</name>
+      <url>${maven-central-releases-repo-url}</url>
+    </repository>
+    <snapshotRepository>
+      <id>icu4j-snapshots</id>
+      <name>ICU4J Central Development Repository</name>
+      <url>${maven-central-snapshots-repo-url}</url>
+    </snapshotRepository>
+  </distributionManagement>
+
   <build>
+    <!-- Workaround for Windows symlink issue:
+      https://issues.apache.org/jira/browse/MRESOURCES-237
+      BUT FAILS ON LINUX :-(
+    -->
+    <!--
+    <resources>
+      <resource>
+        <directory>src/test/resources</directory>
+        <filtering>true</filtering>
+        <includes>
+          <include>LICENSE</include>
+        </includes>
+      </resource>
+    </resources>
+    -->
+
     <pluginManagement>
       <plugins>
         <plugin>
@@ -97,17 +194,21 @@
           <configuration>
             <includes>
               <!-- Some test files start with "IntlTest...". Many don't fit
-               the Surefire test file name default patterns. To be safe, use
-               a catchall pattern instead of the default patterns.
+                the Surefire test file name default patterns. To be safe, use
+                a catchall pattern instead of the default patterns.
 
-               FYI, the default patterns are documented on the website of the
-               testing plugin:
-               https://maven.apache.org/surefire/maven-surefire-plugin/examples/inclusion-exclusion.html
+                FYI, the default patterns are documented on the website of the
+                testing plugin:
+                https://maven.apache.org/surefire/maven-surefire-plugin/examples/inclusion-exclusion.html
               -->
               <include>**/*.java</include>
             </includes>
           </configuration>
         </plugin>
+        <plugin>
+          <artifactId>maven-failsafe-plugin</artifactId>
+          <version>3.1.2</version>
+        </plugin>
         <plugin>
           <artifactId>maven-install-plugin</artifactId>
           <version>3.1.1</version>
@@ -115,6 +216,13 @@
         <plugin>
           <artifactId>maven-deploy-plugin</artifactId>
           <version>3.1.1</version>
+          <!-- We don't want to deploy all submodules to Maven, so we make it opt-in.
+            What we want to publish to Maven Central are the current 3 artifacts (icu4j, charset, and localespi).
+            And what we publish to the GitHub Maven repository is the specific-to-CLDR version of ICU4J.
+          -->
+          <configuration>
+            <skip>true</skip>
+          </configuration>
         </plugin>
         <plugin>
           <artifactId>maven-site-plugin</artifactId>
@@ -184,22 +292,22 @@
             <taglets>
               <taglet>
                 <tagletClass>com.ibm.icu.dev.tool.docs.ICUTaglet</tagletClass>
+                <tagletArtifact>
+                  <groupId>com.ibm.icu</groupId>
+                  <artifactId>tools_build</artifactId>
+                  <version>${project.version}</version>
+                </tagletArtifact>
               </taglet>
               <taglet>
                 <tagletClass>ch.arrenbrecht.jcite.JCiteTaglet</tagletClass>
+                <tagletArtifact>
+                  <groupId>org.mcraig</groupId>
+                  <artifactId>jcite</artifactId>
+                  <version>1.13.0</version>
+                </tagletArtifact>
               </taglet>
             </taglets>
             <tagletArtifacts>
-              <tagletArtifact>
-                <groupId>com.ibm.icu</groupId>
-                <artifactId>tools_build</artifactId>
-                <version>${project.version}</version>
-              </tagletArtifact>
-              <tagletArtifact>
-                <groupId>org.mcraig</groupId>
-                <artifactId>jcite</artifactId>
-                <version>1.13.0</version>
-              </tagletArtifact>
               <!-- Dependencies for org.mcraig:jcite -->
               <tagletArtifact>
                 <groupId>commons-discovery</groupId>
@@ -282,7 +390,6 @@
   <profiles>
 
     <!-- This is used to create the *-sources.jar for individual modules -->
-    <!-- TODO: the shaded equivalent. -->
     <profile>
       <id>with_sources</id>
       <build>
@@ -303,7 +410,6 @@
     </profile>
 
     <!-- This is used to create the *-javadoc.jar for individual modules -->
-    <!-- TODO: the shaded equivalent. -->
     <profile>
       <id>with_javadoc</id>
       <build>