organicmaps/icu
13
Fork 0
mirror of https://github.com/unicode-org/icu.git synced 2025-04-06 14:05:32 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions 9

ICU-21959 Update stale Jira tickets in ICU4J TODOs

Browse source 
See #2062
This commit is contained in:
Hugo van der Merwe 2022-04-09 20:27:59 +00:00
parent fca6b342c0
commit 50e14fe15b
3 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
icu4j/main/classes/core/src/com/ibm/icu/impl/units/UnitsConverter.java
View file

@ -116,7 +116,7 @@ public class UnitsConverter {
// We should see no offsets for reciprocal conversions - they don't make sense:
assert offset == BigDecimal.ZERO;
if (result.compareTo(BigDecimal.ZERO) == 0) {
// TODO(ICU-21862): determine desirable behaviour
// TODO(ICU-21988): determine desirable behaviour
return BigDecimal.ZERO;
}
result = BigDecimal.ONE.divide(result, DECIMAL128);
@ -130,7 +130,7 @@ public class UnitsConverter {
// We should see no offsets for reciprocal conversions - they don't make sense:
assert offset == BigDecimal.ZERO;
if (result.compareTo(BigDecimal.ZERO) == 0) {
// TODO(ICU-21862): determine desirable behaviour
// TODO(ICU-21988): determine desirable behaviour
return BigDecimal.ZERO;
}
result = BigDecimal.ONE.divide(result, DECIMAL128);

4
icu4j/main/tests/core/src/com/ibm/icu/dev/test/impl/UnitsTest.java
View file

@ -472,10 +472,10 @@ public class UnitsTest {
new TestData("cubic-meter-per-meter", "mile-per-gallon", 2.1383143939394E-6, 1.1),
new TestData("cubic-meter-per-meter", "mile-per-gallon", 2.6134953703704E-6, 0.9),
new TestData("liter-per-100-kilometer", "mile-per-gallon", 6.6, 35.6386),
// // TODO(ICU-21862): we should probably return something other than "0":
// // TODO(ICU-21988): we should probably return something other than "0":
// new TestData("liter-per-100-kilometer", "mile-per-gallon", 0, 0),
// new TestData("mile-per-gallon", "liter-per-100-kilometer", 0, 0),
// // TODO(ICU-21862): deal with infinity input in Java?
// // TODO(ICU-21988): deal with infinity input in Java?
// new TestData("mile-per-gallon", "liter-per-100-kilometer", INFINITY, 0),
// We skip testing -Inf, because the inverse conversion loses the sign:
// new TestData("mile-per-gallon", "liter-per-100-kilometer", -INFINITY, 0),

6
icu4j/main/tests/core/src/com/ibm/icu/dev/test/number/NumberFormatterApiTest.java
View file

@ -1682,7 +1682,7 @@ public class NumberFormatterApiTest extends TestFmwk {
6.6, //
"36 mpg");
// // TODO(ICU-21862): determine desired behaviour. Commented out for now
// // TODO(ICU-21988): determine desired behaviour. Commented out for now
// // to not enforce undesirable behaviour
// assertFormatSingle("Fuel consumption: inverted units, divide-by-zero, en-US",
// "unit/liter-per-100-kilometer usage/vehicle-fuel",
@ -1694,7 +1694,7 @@ public class NumberFormatterApiTest extends TestFmwk {
// 0, //
// "0 mpg");
// // TODO(ICU-21862): determine desired behaviour. Commented out for now
// // TODO(ICU-21988): determine desired behaviour. Commented out for now
// // to not enforce undesirable behaviour
// assertFormatSingle("Fuel consumption: inverted units, divide-by-zero, en-ZA",
// "unit/mile-per-gallon usage/vehicle-fuel",
@ -1706,7 +1706,7 @@ public class NumberFormatterApiTest extends TestFmwk {
// 0, //
// "0 mpg");
// // TODO(ICU-21862): Once we support Inf as input:
// // TODO(ICU-21988): Once we support Inf as input:
// assertFormatSingle("Fuel consumption: inverted units, divide-by-inf",
// "unit/mile-per-gallon usage/vehicle-fuel",
// "unit/mile-per-gallon usage/vehicle-fuel",