organicmaps/icu
13
Fork 0
mirror of https://github.com/unicode-org/icu.git synced 2025-04-08 06:53:45 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions 2

ICU-4933 make BreakIterator.getBreakInstance() public+internal and use it instead of writing a duplicate

Browse source 
X-SVN-Rev: 20191
This commit is contained in:
Markus Scherer 2006-08-30 15:39:51 +00:00
parent 050e6b861d
commit 5282667c4c
2 changed files with 13 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
icu4j/src/com/ibm/icu/dev/test/lang/UCharacterCaseTest.java
View file

@ -288,36 +288,19 @@ public final class UCharacterCaseTest extends TestFmwk
}
}
// Unfortunately, BreakIterator.getBreakInstance(ULocale where, int kind)
// is private. Re-implement it here.
private final BreakIterator getBreakInstance(ULocale where, int kind) {
switch(kind) {
case BreakIterator.KIND_CHARACTER:
return BreakIterator.getCharacterInstance(where);
case BreakIterator.KIND_WORD:
return BreakIterator.getWordInstance(where);
case BreakIterator.KIND_LINE:
return BreakIterator.getLineInstance(where);
case BreakIterator.KIND_SENTENCE:
return BreakIterator.getSentenceInstance(where);
case BreakIterator.KIND_TITLE:
return BreakIterator.getTitleInstance(where);
default:
return null;
}
}
public void TestTitle()
{
try{
for (int i = 0; i < TITLE_DATA_.length;) {
String test = TITLE_DATA_[i++];
String expected = TITLE_DATA_[i++];
String locale = TITLE_DATA_[i++];
String breakType = TITLE_DATA_[i++];
ULocale loc = new ULocale(locale);
BreakIterator iter = getBreakInstance(loc, Integer.parseInt(breakType));
String result = UCharacter.toTitleCase(loc, test, iter);
ULocale locale = new ULocale(TITLE_DATA_[i++]);
int breakType = Integer.parseInt(TITLE_DATA_[i++]);
BreakIterator iter =
breakType >= 0 ?
BreakIterator.getBreakInstance(locale, breakType) :
null;
String result = UCharacter.toTitleCase(locale, test, iter);
if (!expected.equals(result)) {
errln("titlecasing for " + prettify(test) + " should be " +
prettify(expected) + " but got " +

7
icu4j/src/com/ibm/icu/text/BreakIterator.java
View file

@ -700,7 +700,12 @@ public abstract class BreakIterator implements Cloneable
// end of registration
private static BreakIterator getBreakInstance(ULocale where, int kind) {
/*
* Get a particular kind of BreakIterator for a locale.
* Avoids writing a switch statement with getXYZInstance(where) calls.
* @internal
*/
public static BreakIterator getBreakInstance(ULocale where, int kind) {
if (iterCache[kind] != null) {
BreakIteratorCache cache = (BreakIteratorCache) iterCache[kind].get();