organicmaps/icu
13
Fork 0
mirror of https://github.com/unicode-org/icu.git synced 2025-04-04 13:05:31 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions 7

ICU-22817 Fix potential memory leak by using LocalPointer

Browse source 
See https://github.com/LuMingYinDetect/icu_defects/blob/main/icu_10.png
This commit is contained in:
Frank Tang 2025-03-17 21:46:55 -07:00 • committed by Frank Yung-Fong Tang
parent ba0f39b592
commit 545bf260e1
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
icu4c/source/i18n/tzgnames.cpp
View file

@ -1172,9 +1172,8 @@ TimeZoneGenericNames::createInstance(const Locale& locale, UErrorCode& status) {
if (U_FAILURE(status)) {
return nullptr;
}
TimeZoneGenericNames* instance = new TimeZoneGenericNames();
if (instance == nullptr) {
status = U_MEMORY_ALLOCATION_ERROR;
LocalPointer<TimeZoneGenericNames> instance(new TimeZoneGenericNames(), status);
if (U_FAILURE(status)) {
return nullptr;
}
@ -1193,7 +1192,6 @@ TimeZoneGenericNames::createInstance(const Locale& locale, UErrorCode& status) {
}
}
if (U_FAILURE(status)) {
delete instance;
return nullptr;
}
@ -1252,12 +1250,11 @@ TimeZoneGenericNames::createInstance(const Locale& locale, UErrorCode& status) {
} // End of mutex locked block
if (cacheEntry == nullptr) {
delete instance;
return nullptr;
}
instance->fRef = cacheEntry;
return instance;
return instance.orphan();
}
bool