mirror of
https://github.com/unicode-org/icu.git
synced 2025-04-13 08:53:20 +00:00
ICU-3931 Code-review comments and removed default constructor -same as Java
X-SVN-Rev: 27451
This commit is contained in:
parent
742d22d13e
commit
6924ba6c66
1 changed files with 5 additions and 11 deletions
|
@ -33,27 +33,21 @@
|
|||
|
||||
U_NAMESPACE_BEGIN
|
||||
|
||||
/*
|
||||
U_CDECL_BEGIN
|
||||
|
||||
static void U_CALLCONV
|
||||
deleteHashStrings(void *obj) {
|
||||
delete (UnicodeString *)obj;
|
||||
}
|
||||
|
||||
U_CDECL_END
|
||||
*/
|
||||
|
||||
UOBJECT_DEFINE_RTTI_IMPLEMENTATION(SelectFormat)
|
||||
|
||||
#define MAX_KEYWORD_SIZE 30
|
||||
static const UChar SELECT_KEYWORD_OTHER[] = {LOW_O, LOW_T, LOW_H, LOW_E, LOW_R, 0};
|
||||
|
||||
SelectFormat::SelectFormat(UErrorCode& status) {
|
||||
if (U_FAILURE(status)) {
|
||||
return;
|
||||
}
|
||||
init(status);
|
||||
}
|
||||
|
||||
SelectFormat::SelectFormat(const UnicodeString& pat, UErrorCode& status) {
|
||||
if (U_FAILURE(status)) {
|
||||
return;
|
||||
|
@ -76,7 +70,7 @@ void
|
|||
SelectFormat::init(UErrorCode& status) {
|
||||
parsedValuesHash = NULL;
|
||||
pattern.remove();
|
||||
status = U_ZERO_ERROR;
|
||||
//status = U_ZERO_ERROR;
|
||||
}
|
||||
|
||||
|
||||
|
@ -102,7 +96,7 @@ SelectFormat::applyPattern(const UnicodeString& newPattern, UErrorCode& status)
|
|||
if (U_FAILURE(status)) {
|
||||
return;
|
||||
}
|
||||
parsedValuesHash->setValueDeleter(deleteHashStrings);
|
||||
//parsedValuesHash->setValueDeleter(deleteHashStrings);
|
||||
}
|
||||
|
||||
//Process the state machine
|
||||
|
@ -448,7 +442,7 @@ SelectFormat::copyHashtable(Hashtable *other, UErrorCode& status) {
|
|||
if (U_FAILURE(status)){
|
||||
return;
|
||||
}
|
||||
parsedValuesHash->setValueDeleter(deleteHashStrings);
|
||||
//parsedValuesHash->setValueDeleter(deleteHashStrings);
|
||||
|
||||
int32_t pos = -1;
|
||||
const UHashElement* elem = NULL;
|
||||
|
|
Loading…
Add table
Reference in a new issue