organicmaps/icu
13
Fork 0
mirror of https://github.com/unicode-org/icu.git synced 2025-04-10 07:39:16 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions 1

ICU-21050 add detail for when need to ifndef C++ boilerplate

Browse source
This commit is contained in:
Markus Scherer 2021-02-01 14:48:06 -08:00
parent 7feb300a87
commit 790dfcf0b7
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
docs/userguide/dev/codingguidelines.md
View file

@ -295,8 +295,12 @@ We do not `#ifndef` APIs where that would be problematic:
struct/class fields, virtual methods)
* enum constants where that would modify the numeric values of following
constants
* C++ class boilerplate (e.g., default/copy constructors) because otherwise
the compiler would create public ones
* actually, best to use `#ifndef` together with explicitly defining the
numeric value of the next constant
* C++ class boilerplate (e.g., default/copy constructors), if
the compiler would auto-create public functions to replace `#ifndef`’ed ones
* For example, the compiler automatically creates a default constructor if
the class does not specify any other constructors.
* private class members
* definitions in internal/test/tools header files (that would be pointless;
they should probably not have API tags in the first place)