organicmaps/icu
13
Fork 0
mirror of https://github.com/unicode-org/icu.git synced 2025-04-14 17:24:01 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions 1

ICU-22686 Fix Unit preferences calculation in Java

Browse source 
See #2899
This commit is contained in:
Younies Mahmoud 2024-03-18 10:36:32 +00:00
parent a1c5294ae7
commit 80b33416e8
2 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
icu4j/main/common_tests/src/test/java/com/ibm/icu/dev/test/number/NumberFormatterApiTest.java
View file

@ -518,6 +518,11 @@ public class NumberFormatterApiTest extends CoreTestFmwk {
// Test the priorities
{"Test the locale with mu,ms,rg --> mu tag wins", "en-US-u-mu-celsius-ms-ussystem-rg-uszzzz", "celsius", "0", "default", "celsius", "0.0", "0 degrees Celsius"},
{"Test the locale with ms,rg --> ms tag wins", "en-US-u-ms-metric-rg-uszzzz", "foot", "1", "default", "foot", "30.0", "30 centimeters"},
// Test the liklihood of the languages
{"Test the region of `en` --> region should be US", "en", "celsius", "1", "default", "fahrenheit", "34.0", "34 degrees Fahrenheit"},
{"Test the region of `de` --> region should be DE", "de", "celsius", "1", "default", "celsius", "1.0", "1 Grad Celsius"},
{"Test the region of `ar` --> region should be EG", "ar", "celsius", "1", "default", "celsius", "1.0", "١ درجة مئوية"},
};
int testIndex = 0;
@ -1654,7 +1659,7 @@ public class NumberFormatterApiTest extends CoreTestFmwk {
ULocale.ENGLISH,
Double.NEGATIVE_INFINITY,
// "-∞ km²");
"0 cm²");
"0 in²");
// TODO(icu-units#132): Java BigDecimal does not support Inf and NaN, so
// we get a misleading "0" out of this:
@ -1666,7 +1671,7 @@ public class NumberFormatterApiTest extends CoreTestFmwk {
ULocale.ENGLISH,
Double.NaN,
// "NaN cm²");
"0 cm²");
"0 in²");
assertFormatSingle(
"Negative numbers: minute-and-second",

2
icu4j/main/core/src/main/java/com/ibm/icu/impl/units/UnitPreferences.java
View file

@ -92,7 +92,7 @@ public class UnitPreferences {
}
}
String region = ULocale.getRegionForSupplementalData(locale, false);
String region = ULocale.getRegionForSupplementalData(locale, true);
// Check the locale system tag, e.g `ms=metric`.
String localeSystem = locale.getKeywordValue("measure");