organicmaps/icu
13
Fork 0
mirror of https://github.com/unicode-org/icu.git synced 2025-04-08 06:53:45 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions 2

ICU-23004 clearer thinking

Browse source
This commit is contained in:
Markus Scherer 2025-03-08 15:57:13 -08:00
parent 19658d2647
commit 877172a746
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
icu4c/source/test/intltest/utfitertest.cpp
View file

@ -345,7 +345,6 @@ void U16IteratorTest::testSinglePassIter() {
typename std::iterator_traits<
UTFIterator<SinglePassIter<char16_t>, UChar32, U_BEHAVIOR_NEGATIVE>>::iterator_category,
std::input_iterator_tag>);
// auto iter = std::move(rangeBegin); -- TODO: why does this want to copy?
assertEquals("iter[0] * codePoint", u'a', (*iter).codePoint());
assertEquals("iter[0] -> codePoint", u'a', iter->codePoint());
++iter; // pre-increment
@ -373,7 +372,7 @@ void U16IteratorTest::testFwdIter() {
FwdIter<char16_t> goodBegin(good.data());
FwdIter<char16_t> goodLimit(good.data() + good.length());
auto rangeBegin = utfIterator<UChar32, U_BEHAVIOR_NEGATIVE>(goodBegin, goodLimit);
auto rangeLimit = utfIterator<UChar32, U_BEHAVIOR_NEGATIVE>(goodLimit, goodLimit);
auto rangeLimit = utfIterator<UChar32, U_BEHAVIOR_NEGATIVE>(goodLimit);
// TODO: UTFStringCodePoints<FwdIter, UChar32, U_BEHAVIOR_NEGATIVE> range(good);
assertTrue(
"forward_iterator_tag",
@ -483,7 +482,6 @@ void U8IteratorTest::testSinglePassIter() {
typename std::iterator_traits<
UTFIterator<SinglePassIter<char>, UChar32, U_BEHAVIOR_NEGATIVE>>::iterator_category,
std::input_iterator_tag>);
// auto iter = std::move(rangeBegin); -- TODO: why does this want to copy?
assertEquals("iter[0] * codePoint", u'a', (*iter).codePoint());
assertEquals("iter[0] -> codePoint", u'a', iter->codePoint());
++iter; // pre-increment
@ -511,7 +509,7 @@ void U8IteratorTest::testFwdIter() {
FwdIter<char> goodBegin(good.data());
FwdIter<char> goodLimit(good.data() + good.length());
auto rangeBegin = utfIterator<UChar32, U_BEHAVIOR_NEGATIVE>(goodBegin, goodLimit);
auto rangeLimit = utfIterator<UChar32, U_BEHAVIOR_NEGATIVE>(goodLimit, goodLimit);
auto rangeLimit = utfIterator<UChar32, U_BEHAVIOR_NEGATIVE>(goodLimit);
// TODO: UTFStringCodePoints<FwdIter, UChar32, U_BEHAVIOR_NEGATIVE> range(good);
assertTrue(
"forward_iterator_tag",
@ -619,7 +617,6 @@ void U32IteratorTest::testSinglePassIter() {
typename std::iterator_traits<
UTFIterator<SinglePassIter<char32_t>, UChar32, U_BEHAVIOR_NEGATIVE>>::iterator_category,
std::input_iterator_tag>);
// auto iter = std::move(rangeBegin); -- TODO: why does this want to copy?
assertEquals("iter[0] * codePoint", u'a', (*iter).codePoint());
assertEquals("iter[0] -> codePoint", u'a', iter->codePoint());
++iter; // pre-increment
@ -647,7 +644,7 @@ void U32IteratorTest::testFwdIter() {
FwdIter<char32_t> goodBegin(good.data());
FwdIter<char32_t> goodLimit(good.data() + good.length());
auto rangeBegin = utfIterator<UChar32, U_BEHAVIOR_NEGATIVE>(goodBegin, goodLimit);
auto rangeLimit = utfIterator<UChar32, U_BEHAVIOR_NEGATIVE>(goodLimit, goodLimit);
auto rangeLimit = utfIterator<UChar32, U_BEHAVIOR_NEGATIVE>(goodLimit);
// TODO: UTFStringCodePoints<FwdIter, UChar32, U_BEHAVIOR_NEGATIVE> range(good);
assertTrue(
"forward_iterator_tag",