organicmaps/icu
13
Fork 0
mirror of https://github.com/unicode-org/icu.git synced 2025-04-05 21:45:37 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions 12

ICU-22696 Add implicit conversion from StringPiece to std::string_view.

Browse source 
This will allow ICU4C to seamlessly use std::string_view internally
while continuing to use StringPiece in the public API.
This commit is contained in:
Fredrik Roubert 2024-03-14 22:04:43 +01:00 • committed by Fredrik Roubert
parent 5d7cbdbc02
commit 8891c070bd
2 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
icu4c/source/common/unicode/stringpiece.h
View file

@ -32,6 +32,7 @@
#if U_SHOW_CPLUSPLUS_API
#include <cstddef>
#include <string_view>
#include <type_traits>
#include "unicode/uobject.h"
@ -176,6 +177,16 @@ class U_COMMON_API StringPiece : public UMemory {
*/
StringPiece(const StringPiece& x, int32_t pos, int32_t len);
#ifndef U_HIDE_INTERNAL_API
/**
* Converts to a std::string_view().
* @internal
*/
inline operator std::string_view() const {
return {data(), static_cast<std::string_view::size_type>(size())};
}
#endif // U_HIDE_INTERNAL_API
/**
* Returns the string pointer. May be nullptr if it is empty.
*

5
icu4c/source/test/intltest/strtest.cpp
View file

@ -516,6 +516,11 @@ StringTest::TestStringPieceStringView() {
assertEquals("size()", piece.size(), view.size());
assertEquals("data()", piece.data(), view.data());
std::string_view v2 = piece; // Internal implicit conversion.
assertEquals("size()", piece.size(), v2.size());
assertEquals("data()", piece.data(), v2.data());
}
void