organicmaps/icu
13
Fork 0
mirror of https://github.com/unicode-org/icu.git synced 2025-04-15 01:42:37 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions 1

ICU-13373 Change TestDataDrivenJDK from blacklist to whitelist.

Browse source 
X-SVN-Rev: 41391
This commit is contained in:
Shane Carr 2018-05-16 23:55:51 +00:00
parent 2e2805df9a
commit 8d3fb63bd2
1 changed files with 5 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatDataDrivenTest.java
View file

@ -758,21 +758,16 @@ public class NumberFormatDataDrivenTest {
"numberformattestspecification.txt", ICU58);
}
// Note: This test case is really questionable. Depending on Java version,
// something may or may not work. However the test data assumes a specific
// Java runtime version. We should probably disable this test case - #13372
@Test
public void TestDataDrivenJDK() {
// Android implements java.text.DecimalFormat with ICU4J (ticket #13322).
// Oracle/OpenJDK 9's behavior is not exactly same with Oracle/OpenJDK 8.
// Some test cases failed on 8 work well, while some other test cases
// fail on 9, but worked on 8. Skip this test case if Java version is not 8.
// #13373: Since not all JDK implementations are the same, test only whitelisted JDKs
// with known behavior. The JDK version should be occasionally updated.
org.junit.Assume.assumeTrue(
TestUtil.getJavaVendor() != TestUtil.JavaVendor.Android
&& TestUtil.getJavaVersion() < 9);
TestUtil.getJavaRuntimeName() == TestUtil.JavaRuntimeName.OpenJDK
&& TestUtil.getJavaVersion() == 8);
DataDrivenNumberFormatTestUtility.runFormatSuiteIncludingKnownFailures(
"numberformattestspecification.txt", JDK);
"numberformattestspecification.txt", JDK);
}
@Test