organicmaps/icu
13
Fork 0
mirror of https://github.com/unicode-org/icu.git synced 2025-04-05 21:45:37 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions 12

ICU-22536 Fix ICUServiceThreadTest flakiness

Browse source 
Sometimes getVisibleIDs() method returns a null reference which might happend
because of inaccurate concurrent access. This change attempts to fix this
ICUServiceThreadTest flakiness.
This commit is contained in:
Victor Chang 2023-10-06 10:28:48 +01:00 • committed by Markus Scherer
parent aff1bbaa14
commit 9e6173fcef
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
icu4j/main/core/src/main/java/com/ibm/icu/impl/ICUService.java
View file

@ -592,13 +592,17 @@ public class ICUService extends ICUNotifier {
Factory f = lIter.previous();
f.updateVisibleIDs(mutableMap);
}
this.idcache = Collections.unmodifiableMap(mutableMap);
// Capture the return value in a local variable.
// Avoids returning an idcache value changed by another thread (could be null after clearCaches()).
Map<String, Factory> result = Collections.unmodifiableMap(mutableMap);
this.idcache = result;
return result;
} finally {
factoryLock.releaseRead();
}
}
return idcache;
}
return idcache;
}
private Map<String, Factory> idcache;