fix dependices and small nits

This commit is contained in:
Younies Mahmoud 2020-05-05 03:43:49 +02:00
parent 0a93866597
commit 9f1429dc1c
3 changed files with 3 additions and 6 deletions

View file

@ -23,8 +23,7 @@ void trimSpaces(CharString& factor, UErrorCode& status){
trimmed.append(factor[i], status);
}
factor.clear();
factor.append(trimmed, status);
factor = std::move(trimmed);
}
/**

View file

@ -1065,7 +1065,7 @@ group: sharedbreakiterator
group: units_extra
measunit_extra.o
deps
units ucharstriebuilder ucharstrie uclean_i18n double_conversion
units ucharstriebuilder ucharstrie uclean_i18n
group: units
measunit.o currunit.o nounit.o
@ -1075,7 +1075,7 @@ group: units
group: unitsformatter
unitsdata.o unitconverter.o
deps
resourcebundle units_extra
resourcebundle units_extra double_conversion
group: decnumber
decContext.o decNumber.o

View file

@ -2173,8 +2173,6 @@ UBool IntlTest::assertNotEquals(const char* message,
return TRUE;
}
// TODO: how about we adjust this function to align with JUnit? I see it simply has "assertEquals" for
// doulbes with a "delta" parameter:
// http://junit.sourceforge.net/javadoc/org/junit/Assert.html#assertEquals(java.lang.String,%20double,%20double,%20double)
UBool IntlTest::assertEqualsNear(const char *message, double expected, double actual, double precision) {
double diff = std::abs(expected - actual);