organicmaps/icu
13
Fork 0
mirror of https://github.com/unicode-org/icu.git synced 2025-04-06 05:55:35 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions 11

ICU-9950 improve review tool

Browse source 
X-SVN-Rev: 34499
This commit is contained in:
Steven R. Loomis 2013-10-01 00:14:24 +00:00
parent 6934b97a28
commit a501719673
2 changed files with 16 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
tools/trac/IcuCodeTools/0.12/icucodetools/review.py
View file

@ -1,10 +1,12 @@
# Copyright (C) 2007-2012 International Business Machines Corporation and Others. All Rights Reserved.
# Copyright (C) 2007-2013 International Business Machines Corporation and Others. All Rights Reserved.
# Review module.
# TODO: refactor ticket manipulation items into ticketmgr.
import re
import traceback
from trac.core import Component, implements
from trac.core import ComponentManager
from trac.core import TracError
@ -13,7 +15,8 @@ from trac.web import IRequestHandler
from trac.web.chrome import add_stylesheet, add_script, ITemplateProvider, add_ctxtnav
from trac.versioncontrol import Changeset
from trac.web.api import IRequestFilter
from trac.wiki import wiki_to_html, wiki_to_oneliner, IWikiSyntaxProvider
from trac.wiki import wiki_to_html, format_to_oneliner, IWikiSyntaxProvider
from trac.mimeview import Context
from genshi.builder import tag
#from trac.env import IEnvironmentSetupParticipant
@ -180,6 +183,7 @@ class ReviewModule(Component):
#ticketlist = {} # dict of ticket->???
#revlist = {} # dict of revision->
repos = self.env.get_repository()
context = Context.from_request(req, False)
new_path = req.args.get('new_path')
new_rev = req.args.get('new')
@ -243,6 +247,14 @@ class ReviewModule(Component):
revision['author'] = chgset.author
revision['num'] = rev
revision['comment'] = message #wiki_to_oneliner( message, self.env, db, shorten=False )
try:
revision['comment_wiki'] = format_to_oneliner( self.env, context, message, shorten=False )
except Exception, e:
self.env.log.warn(e)
revision['comment_wiki'] = "%s (could not format - %s)" % (message, str(e))
#return system_message(_('HTML parsing error: %(message)s',
# message=escape(e.msg)), line)
rbranches = revision['branches'] = []
for chg in chgset.get_changes():
path = chg[0]

4
tools/trac/IcuCodeTools/0.12/icucodetools/templates/review.html
View file

@ -2,7 +2,7 @@
PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<!--
# Copyright (C) 2007-2012 IBM and Others. All Rights Reserved
# Copyright (C) 2007-2013 IBM and Others. All Rights Reserved
-->
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:py="http://genshi.edgewall.org/"
@ -50,7 +50,7 @@
</py:for>
</td>
<td>
${rev.comment}
${rev.comment_wiki}
</td>
</tr>
</py:for>