organicmaps/icu
13
Fork 0
mirror of https://github.com/unicode-org/icu.git synced 2025-04-05 05:25:34 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions 11

ICU-22920 Avoid CTAD in Formattable's constructor. NFC

Browse source 
This line uses CTAD on `pair`, when every other place in the codebase
uses a function call to `make_pair` (and no other place uses CTAD on
any class template at all). Assume this was unintentional, and fix it.

    warning: class template argument deduction is incompatible with
    C++ standards before C++17; for compatibility, use explicit type
    name 'std::pair<const Formattable *, int>'
    (aka 'pair<const icu_77::message2::Formattable *, int>') [-Wctad]
          Formattable(const Formattable* arr, int32_t len) : contents(std::pair(arr, len)) {}
                                                                      ^~~~~~~~~
This commit is contained in:
Arthur O'Dwyer 2025-01-24 12:15:05 -05:00
parent ba4d4d3ac2
commit b9ccc39a41
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
icu4c/source/i18n/unicode/messageformat2_formattable.h
View file

@ -389,7 +389,7 @@ namespace message2 {
* @internal ICU 75 technology preview
* @deprecated This API is for technology preview only.
*/
Formattable(const Formattable* arr, int32_t len) : contents(std::pair(arr, len)) {}
Formattable(const Formattable* arr, int32_t len) : contents(std::make_pair(arr, len)) {}
/**
* Object constructor.
*