organicmaps/icu
13
Fork 0
mirror of https://github.com/unicode-org/icu.git synced 2025-04-06 22:15:31 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions 1

ICU-20438 Improving commit report instructions and efficiency.

Browse source
This commit is contained in:
Shane F. Carr 2019-02-20 20:48:14 -06:00 • committed by Shane F. Carr
parent 666d1a9d8e
commit d2d59c6d65
2 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
tools/commit-checker/README.md
View file

@ -31,9 +31,10 @@ This is required if you want to process sensitive tickets.
Make sure you have updated your repository:
$ git pull upstream master
$ git fetch --tags upstream
Run the tool and save the result into REPORT.md:
$ pipenv run python3 check.py > REPORT.md
$ pipenv run python3 check.py --jira-query "project=ICU AND fixVersion=63.1" > REPORT.md
Open a pull request so others can view the report easilly.

11
tools/commit-checker/check.py
View file

@ -70,7 +70,10 @@ def pretty_print_commit(commit, **kwargs):
def pretty_print_issue(issue, **kwargs):
print("- %s: `%s`" % (issue.issue_id, issue.issue.fields.summary))
print("\t- Assigned to %s" % issue.issue.fields.assignee.displayName)
if issue.issue.fields.assignee:
print("\t- Assigned to %s" % issue.issue.fields.assignee.displayName)
else:
print("\t- No assignee!")
print("\t- Jira Link: %s" % issue_id_to_url(issue.issue_id, **kwargs))
@ -164,6 +167,7 @@ def main():
(issue_id, [commit for commit in commits if commit.issue_id == issue_id])
for issue_id in sorted(commit_issue_ids)
]
jira_issue_map = {issue.issue_id: issue for issue in issues}
jira_issue_ids = set(issue.issue_id for issue in issues)
closed_jira_issue_ids = set(issue.issue_id for issue in issues if issue.is_closed)
@ -273,7 +277,10 @@ def main():
continue
print("#### Issue %s" % issue_id)
print()
jira_issue = get_single_jira_issue(issue_id, **vars(args))
if issue_id in jira_issue_map:
jira_issue = jira_issue_map[issue_id]
else:
jira_issue = get_single_jira_issue(issue_id, **vars(args))
if jira_issue:
pretty_print_issue(jira_issue, **vars(args))
else: