organicmaps/icu
13
Fork 0
mirror of https://github.com/unicode-org/icu.git synced 2025-04-07 22:44:49 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions 2

ICU-20000 Workaround for BigDecimal.stripTrailingZeros() differences. (#57)

Browse source 
Different implementations of BigDecimal.stripTrailingZeros(), in
different versions of the JDK (and different versions of Android), have
differences in their handling of zero. To avoid this, ICU4J can return
BigDecimal.ZERO for any value that is equal to zero, instead of calling
BigDecimal.stripTrailingZeros() in this problematic case.
This commit is contained in:
Fredrik Roubert 2018-08-16 02:54:32 +02:00 • committed by Shane Carr
parent 01ca8fb555
commit da7bd533ab
No known key found for this signature in database
GPG key ID: FCED3B24AAB18B5C
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
icu4j/main/classes/core/src/com/ibm/icu/number/Scale.java
View file

@ -40,7 +40,11 @@ public class Scale {
private Scale(int magnitude, BigDecimal arbitrary, MathContext mc) {
if (arbitrary != null) {
// Attempt to convert the BigDecimal to a magnitude multiplier.
arbitrary = arbitrary.stripTrailingZeros();
// ICU-20000: JDKs have inconsistent behavior on stripTrailingZeros() for Zero.
arbitrary =
arbitrary.compareTo(BigDecimal.ZERO) == 0
? BigDecimal.ZERO
: arbitrary.stripTrailingZeros();
if (arbitrary.precision() == 1 && arbitrary.unscaledValue().equals(BigInteger.ONE)) {
// Success!
magnitude -= arbitrary.scale();