organicmaps/icu
13
Fork 0
mirror of https://github.com/unicode-org/icu.git synced 2025-04-13 17:01:16 +00:00
Code Issues1 Projects Releases Wiki Activity Actions3

ICU-10461 Andy's review comments.

Browse source 
X-SVN-Rev: 35490
This commit is contained in:
Travis Keep 2014-03-17 18:07:34 +00:00
parent 283c817edb
commit e4f7eafc89
5 changed files with 19 additions and 19 deletions

4
icu4c/source/common/lrucache.cpp
View file

@ -80,8 +80,8 @@ const SharedObject *LRUCache::_get(const char *localeId, UErrorCode &status) {
if (U_FAILURE(status)) {
return NULL;
}
CacheEntry *entry = (CacheEntry *) uhash_get(
localeIdToEntries, localeId);
CacheEntry *entry = static_cast<CacheEntry *>(uhash_get(
localeIdToEntries, localeId));
if (entry == NULL) {
// Its a cache miss.

2
icu4c/source/i18n/numfmt.cpp
View file

@ -1046,7 +1046,7 @@ NumberFormat::createInstance(const Locale& loc, UNumberFormatStyle kind, UErrorC
if (U_FAILURE(status)) {
return NULL;
}
NumberFormat *result = (NumberFormat *) (*shared)->clone();
NumberFormat *result = static_cast<NumberFormat *>((*shared)->clone());
shared->removeRef();
if (result == NULL) {
status = U_MEMORY_ALLOCATION_ERROR;

16
icu4c/source/i18n/sharednumberformat.h
View file

@ -19,15 +19,15 @@ class NumberFormat;
class U_I18N_API SharedNumberFormat : public SharedObject {
public:
SharedNumberFormat(NumberFormat *nfToAdopt) : ptr(nfToAdopt) { }
virtual ~SharedNumberFormat();
const NumberFormat *get() const { return ptr; }
const NumberFormat *operator->() const { return ptr; }
const NumberFormat &operator*() const { return *ptr; }
SharedNumberFormat(NumberFormat *nfToAdopt) : ptr(nfToAdopt) { }
virtual ~SharedNumberFormat();
const NumberFormat *get() const { return ptr; }
const NumberFormat *operator->() const { return ptr; }
const NumberFormat &operator*() const { return *ptr; }
private:
NumberFormat *ptr;
SharedNumberFormat(const SharedNumberFormat &);
SharedNumberFormat &operator=(const SharedNumberFormat &);
NumberFormat *ptr;
SharedNumberFormat(const SharedNumberFormat &);
SharedNumberFormat &operator=(const SharedNumberFormat &);
};
U_NAMESPACE_END

14
icu4c/source/i18n/sharedpluralrules.h
View file

@ -19,14 +19,14 @@ class PluralRules;
class U_I18N_API SharedPluralRules : public SharedObject {
public:
SharedPluralRules(PluralRules *prToAdopt) : ptr(prToAdopt) { }
virtual ~SharedPluralRules();
const PluralRules *operator->() const { return ptr; }
const PluralRules &operator*() const { return *ptr; }
SharedPluralRules(PluralRules *prToAdopt) : ptr(prToAdopt) { }
virtual ~SharedPluralRules();
const PluralRules *operator->() const { return ptr; }
const PluralRules &operator*() const { return *ptr; }
private:
PluralRules *ptr;
SharedPluralRules(const SharedPluralRules &);
SharedPluralRules &operator=(const SharedPluralRules &);
PluralRules *ptr;
SharedPluralRules(const SharedPluralRules &);
SharedPluralRules &operator=(const SharedPluralRules &);
};
U_NAMESPACE_END

2
icu4c/source/i18n/unicode/plurrule.h
View file

@ -308,7 +308,7 @@ public:
/**
* For ICU use only.
* Returns handle to the shared, cached PluralRules isntance.
* Returns handle to the shared, cached PluralRules instance.
* Caller must call removeRef() on returned value once it is done with
* the shared instance.
* @internal