ICU-5456 minor changes for review feedback

X-SVN-Rev: 39364
This commit is contained in:
Markus Scherer 2016-09-27 21:38:03 +00:00
parent cd47bd50e6
commit ecfeb4ac29
2 changed files with 6 additions and 2 deletions

View file

@ -659,6 +659,8 @@ public final class CaseMap {
* Probably simpler than a stateless function that has to figure out complex context-before
* for each character.
* TODO: Try to re-consolidate one way or another with the non-Greek function.
*
* <p>Keep this consistent with the C++ versions in ustrcase.cpp (UTF-16) and ucasemap.cpp (UTF-8).
*/
private static String toUpper(CharSequence s, int[] locCache) {
StringBuilder result = new StringBuilder(s.length());

View file

@ -457,7 +457,7 @@ public final class UCaseProps {
return getTypeFromProps(trie.get(c));
}
/** @return same as ucase_getType() and set bit 2 if c is case-ignorable */
/** @return like getType() but also sets IGNORABLE if c is case-ignorable */
public final int getTypeOrIgnorable(int c) {
return getTypeAndIgnorableFromProps(trie.get(c));
}
@ -1335,15 +1335,17 @@ public final class UCaseProps {
public static final int UPPER=2;
public static final int TITLE=3;
/** @return NONE, LOWER, UPPER, TITLE */
private static final int getTypeFromProps(int props) {
return props&TYPE_MASK;
}
/** @return like getTypeFromProps() but also sets IGNORABLE if props indicate case-ignorable */
private static final int getTypeAndIgnorableFromProps(int props) {
return props&7;
}
public static final int IGNORABLE= 4;
static final int IGNORABLE=4;
private static final int SENSITIVE= 8;
private static final int EXCEPTION= 0x10;