ICU-23081 Use String.replace on non-regex string queries

https://unicode-org.atlassian.net/browse/ICU-23081
2025-04-04 13:05:31 +00:00 · 2025-03-20 16:33:28 +00:00 · 2025-03-20 16:33:28 +00:00 · ee90520429
commit ee90520429
parent 1bf6bf774d
3 changed files with 7 additions and 7 deletions
--- a/icu4j/main/core/src/main/java/com/ibm/icu/impl/locale/InternalLocaleBuilder.java
+++ b/icu4j/main/core/src/main/java/com/ibm/icu/impl/locale/InternalLocaleBuilder.java
@ -75,7 +75,7 @@ public final class InternalLocaleBuilder {
            _variant = "";
        } else {
            // normalize separators to "_"
-            String var = variant.replaceAll(LanguageTag.SEP, BaseLocale.SEP);
+            String var = variant.replace(LanguageTag.SEP, BaseLocale.SEP);
            int errIdx = checkVariants(var, BaseLocale.SEP);
            if (errIdx != -1) {
                throw new LocaleSyntaxException("Ill-formed variant: " + variant, errIdx);
@ -121,7 +121,7 @@ public final class InternalLocaleBuilder {
        } else {
            if (type.length() != 0) {
                // normalize separator to "-"
-                String tp = type.replaceAll(BaseLocale.SEP, LanguageTag.SEP);
+                String tp = type.replace(BaseLocale.SEP, LanguageTag.SEP);
                // validate
                StringTokenIterator itr = new StringTokenIterator(tp, LanguageTag.SEP);
                while (!itr.isDone()) {
@ -166,7 +166,7 @@ public final class InternalLocaleBuilder {
            }
        } else {
            // validate value
-            String val = value.replaceAll(BaseLocale.SEP, LanguageTag.SEP);
+            String val = value.replace(BaseLocale.SEP, LanguageTag.SEP);
            StringTokenIterator itr = new StringTokenIterator(val, LanguageTag.SEP);
            while (!itr.isDone()) {
                String s = itr.current();
@ -202,7 +202,7 @@ public final class InternalLocaleBuilder {
            clearExtensions();
            return this;
        }
-        subtags = subtags.replaceAll(BaseLocale.SEP, LanguageTag.SEP);
+        subtags = subtags.replace(BaseLocale.SEP, LanguageTag.SEP);
        StringTokenIterator itr = new StringTokenIterator(subtags, LanguageTag.SEP);

        List<String> extensions = null;
@ -485,7 +485,7 @@ public final class InternalLocaleBuilder {
                    if (sb.length() != 0) {
                        sb.append(BaseLocale.SEP);
                    }
-                    sb.append(privuse.substring(privVarStart).replaceAll(LanguageTag.SEP, BaseLocale.SEP));
+                    sb.append(privuse.substring(privVarStart).replace(LanguageTag.SEP, BaseLocale.SEP));
                    variant = sb.toString();
                }
            }
--- a/icu4j/main/core/src/main/java/com/ibm/icu/impl/units/ConversionRates.java
+++ b/icu4j/main/core/src/main/java/com/ibm/icu/impl/units/ConversionRates.java
@ -183,7 +183,7 @@ public class ConversionRates {


                    String keyString = key.toString();
-                    String valueString = value.toString().replaceAll(" ", "");
+                    String valueString = value.toString().replace(" ", "");
                    if ("target".equals(keyString)) {
                        target = valueString;
                    } else if ("factor".equals(keyString)) {
--- a/icu4j/main/core/src/main/java/com/ibm/icu/text/DateFormatSymbols.java
+++ b/icu4j/main/core/src/main/java/com/ibm/icu/text/DateFormatSymbols.java
@ -2244,7 +2244,7 @@ public class DateFormatSymbols implements Serializable, Cloneable {
            }
        }
        if (calType == null) {
-            calType = className.replaceAll("Calendar", "").toLowerCase(Locale.ENGLISH);
+            calType = className.replace("Calendar", "").toLowerCase(Locale.ENGLISH);
        }

        initializeData(locale, calType);