ICU-22721 Simplify wait-for-checks match logic

This commit is contained in:
Elango Cheran 2024-06-30 21:37:54 -07:00
parent 0178a07a26
commit ee93218eab
2 changed files with 3 additions and 4 deletions

View file

@ -27,9 +27,8 @@ jobs:
uses: poseidon/wait-for-status-checks@6988432d64ad3f9c2608db4ca16fded1b7d36ead # v0.5.0
with:
token: ${{ secrets.GITHUB_TOKEN }}
# This is one large regex. The GHA parser for the YAML `>-` operator doesn't work as advertised,
# so instead, this next best thing is to write out the regex pattern string directly
match_pattern: "license.*|jira-ticket|single-commit|CI-ICU4J|CI-ICU4C|Test build of User Guide docs|copyright-scan|valid-UTF-8-and-no-BOM-check|icu4j-.*|icu4c-.*|gcc-.*|clang-.*|run-with-stubdata|u-.*|lstm-test|adaboost-test|testmap|internal-header-compilation|valid-UTF-8-and-no-BOM-check|uconfig-unit-tests.*|unicode-update-tools|lstm-icu4j.*|adaboost-icu4j.*|env-test.*"
# This regex matches everything since almost all (if not all) CI checks are required.
match_pattern: ".*"
# For Azure Pipelines, each pipeline displays a check that represents the complete success of the pipeline.
# It won't pass until all of the pipeline's checks pass.
# For the ICU4J and ICU4C pipelines, this is called `CI-ICU4J` and `CI-ICU4C`.

View file

@ -54,7 +54,7 @@ Individual tests can be configured in the ICU Github repository:
6. Underneath that enabled checkbox, the table "Status checks that are required." lists the currently enabled tests ("checks") that must pass before a Pull Request can be merged to the branch
7. Set the only required check to be `enforce-all-checks`.
- The [`wait-for-checks` Github Action](https://github.com/marketplace/actions/wait-for-checks)
correctly enforces that all of checks of interest are passing,
correctly enforces that all checks of interest are passing,
while only inspecting activated checks
(ignoring checks that are inactive or skipped due to conditional triggering).
- See the `enforce-all-checks` job of the `.github/workflows/wait-for-checks.yml` workflow for usage details.