organicmaps/icu
13
Fork 0
mirror of https://github.com/unicode-org/icu.git synced 2025-04-13 17:01:16 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions 3

ICU-13766 Make UnicodeMapTest#TestUnicodeMapGeneralCategory smaller.

Browse source 
There are 0x10FFFF code points and this test allocates memory for every
code point tested. Testing every single one of them is therefore memory
intensive and slow, without adding any real value to the test.

Instead an equivalent test coverage can be achieved by testing a much
smaller set of ranges of code points that cover all categories.

X-SVN-Rev: 41547
This commit is contained in:
Fredrik Roubert 2018-06-21 20:17:22 +00:00
parent 3f7a4aa202
commit f1d29ce62e
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
icu4j/main/tests/translit/src/com/ibm/icu/dev/test/translit/UnicodeMapTest.java
View file

@ -343,7 +343,6 @@ public class UnicodeMapTest extends TestFmwk {
checkNext(map1, map2, LIMIT);
}
private static final int SET_LIMIT = 0x10FFFF;
private static final int propEnum = UProperty.GENERAL_CATEGORY;
@Test
@ -354,12 +353,23 @@ public class UnicodeMapTest extends TestFmwk {
//Map<Integer, String> map3 = new TreeMap<Integer, String>();
map1 = new UnicodeMap<String>();
map2 = new TreeMap<Integer,String>();
for (int cp = 0; cp <= SET_LIMIT; ++cp) {
for (int cp = 0;;) {
int enumValue = UCharacter.getIntPropertyValue(cp, propEnum);
//if (enumValue <= 0) continue; // for smaller set
String value = UCharacter.getPropertyValueName(propEnum,enumValue, UProperty.NameChoice.LONG);
map1.put(cp, value);
map2.put(cp, value);
cp++;
// Unicode is huge, skip over large parts of it.
if (cp == 0x08FF) { // General Scripts Area.
cp = 0xD700; // Hangul Syllables Area.
} else if (cp == 0x100FF) { // General Scripts Area.
cp = 0x1F000; // Symbols Area.
} else if (cp == 0x200FF) { // CJK Unified Ideographs Extensions.
cp = 0x10FF00; // Supplementary Private Use Area-B.
} else if (cp == 0x10FFFF) { // The end of Unicode.
break;
}
}
checkNext(map1, map2, Integer.MAX_VALUE);