From f69999fbfc0ebd2c97d538958dd7caaec1039c9f Mon Sep 17 00:00:00 2001 From: Ram Viswanadha Date: Wed, 4 Dec 2002 23:31:10 +0000 Subject: [PATCH] ICU-2135 fix typo more error checking X-SVN-Rev: 10481 --- icu4c/source/tools/genrb/genrb.c | 2 ++ icu4c/source/tools/genrb/parse.c | 3 +-- icu4c/source/tools/genrb/reslist.c | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/icu4c/source/tools/genrb/genrb.c b/icu4c/source/tools/genrb/genrb.c index ac0844199da..0604cc0c22c 100644 --- a/icu4c/source/tools/genrb/genrb.c +++ b/icu4c/source/tools/genrb/genrb.c @@ -348,6 +348,7 @@ processFile(const char *filename, const char *cp, const char *inputDir, const ch data = parse(ucbuf, inputDir, status); if (data == NULL || U_FAILURE(*status)) { + fprintf(stderr, "couldn't parse the file %s. Error:%s\n", filename,u_errorName(*status)); goto finish; } @@ -385,6 +386,7 @@ processFile(const char *filename, const char *cp, const char *inputDir, const ch } if(U_FAILURE(*status)) { + fprintf(stderr, "couldn't make the res fileName for bundle %s. Error:%s\n", filename,u_errorName(*status)); goto finish; } if(write_java== TRUE){ diff --git a/icu4c/source/tools/genrb/parse.c b/icu4c/source/tools/genrb/parse.c index 31c2dce5a97..e35d087f1e5 100644 --- a/icu4c/source/tools/genrb/parse.c +++ b/icu4c/source/tools/genrb/parse.c @@ -1196,8 +1196,7 @@ parseImport(char *tag, uint32_t startline, UErrorCode *status) } len = T_FileStream_size(file); - data = (uint8_t*)uprv_malloc(len* sizeof(uint8_t)* 3); - uprv_memset(data,0xFF, len *3); + data = (uint8_t*)uprv_malloc(len * sizeof(uint8_t)); /* test for NULL */ if(data == NULL) { diff --git a/icu4c/source/tools/genrb/reslist.c b/icu4c/source/tools/genrb/reslist.c index 2546959c6dc..3f0bdac460a 100644 --- a/icu4c/source/tools/genrb/reslist.c +++ b/icu4c/source/tools/genrb/reslist.c @@ -340,7 +340,7 @@ void bundle_write(struct SRBRoot *bundle, const char *outputDir, const char *out } mem = udata_create(outputDir, "res", dataName, &dataInfo, (gIncludeCopyright==TRUE)? U_COPYRIGHT_STRING:NULL, status); - if(U_FAILURE(status)){ + if(U_FAILURE(*status)){ return; } pad = calcPadding(bundle->fKeyPoint);