Commit graph

207 commits

Author SHA1 Message Date
Arthur O'Dwyer
fb64693c28 ICU-22920 Avoid "return by const value" antipattern
Returning a const-qualified prvalue doesn't do anything useful, but it does
turn an assignment such as `v = rb.getLocale();` from a move-assignment
into a copy-assignment (because it's forbidden to move-from a const value,
even if it's a const prvalue). Each affected site was diagnosed mechanically
by my fork of Clang. E.g.:

    warning: 'const' type qualifier on return type is a bad idea [-Wqual-class-return-type]
      391 | const Locale ResourceBundle::getLocale(ULocDataLocaleType type, UErrorCode &status) const
          | ^~~~~
2025-01-30 10:58:25 -08:00
Frank Tang
4fc1b7e7f6 ICU-22991 Simplified Grego code
Use timeToFields instead of dayToFields

ICU-22991 Revert back gregoimp interface change
2025-01-24 17:13:51 -08:00
Frank Tang
9eafd8ca3e ICU-22991 Reduce Calendar object size
See #3327
2025-01-08 12:26:35 -08:00
Frank Tang
6c8c6aa430 ICU-22827 Fix memLeak by using LocalUResourceBundlePointer 2024-08-05 16:34:16 -07:00
Fredrik Roubert
0178a07a26 ICU-22793 Clang-Tidy: google-readability-casting
https://releases.llvm.org/17.0.1/tools/clang/tools/extra/docs/clang-tidy/checks/google/readability-casting.html
2024-07-04 22:32:12 +02:00
Frank Tang
6ac6fdda74 ICU-22730 propagate error avoid overflow 2024-05-16 00:27:14 -07:00
Fredrik Roubert
5401c12018 ICU-22621 Clang-Tidy: modernize-use-nullptr
https://releases.llvm.org/17.0.1/tools/clang/tools/extra/docs/clang-tidy/checks/modernize/use-nullptr.html
2024-03-15 14:31:54 +01:00
Frank Yung-Fong Tang
0b66fada30 ICU-22633 Fix integer overflow inside Calendar code
See #2806
2024-02-07 10:58:41 -08:00
Frank Tang
7c48842e23 ICU-22637 Accept non-ASCII digit to fix mistake 2024-01-22 14:00:12 -08:00
Frank Tang
c8336085bb ICU-22637 Rewrite custom timezone parser
See #2792
2024-01-19 01:44:52 -08:00
yumaoka
6338b704ff ICU-22452 API for resolving preferred IANA zone ID from a zone ID. 2023-08-11 17:00:05 -04:00
Markus Scherer
b6dcc95d3c ICU-21833 remove redundant void parameter lists
See #2351
2023-03-02 09:31:57 -08:00
Fredrik Roubert
2de88f9d9c ICU-21833 Replace UChar with char16_t in all C++ code. 2023-02-06 19:27:44 +01:00
Fredrik Roubert
2e0d30cfcf ICU-21833 Replace NULL with nullptr in all C++ code. 2023-02-03 20:20:38 +01:00
Fredrik Roubert
030fa1a479 ICU-21148 Consistently use standard lowercase true/false everywhere.
This is the normal standard way in C, C++ as well as Java and there's no
longer any reason for ICU to be different. The various internal macros
providing custom boolean constants can all be deleted and code as well
as documentation can be updated to use lowercase true/false everywhere.
2022-09-07 20:56:33 +02:00
Frank Yung-Fong Tang
3d89af0f72 ICU-22023 Fix Calendar::get() return out of bound value and SimpleDateTime::format assert while TimeZone is "UTC" and value is -1e-9
See #2086
2022-05-19 13:45:59 -07:00
Andy Heninger
85705f04e0 ICU-21960 C++20 Warnings from ATOMIC_VAR_INIT
Remove the ICU macros ATOMIC_INT32_T_INITIALIZER and U_INITONCE_INITIALIZER,
which made use of C++ ATOMIC_VAR_INIT, which has been removed from C++20.

With modern C++ features being available, these macros no longer served
any real need.
2022-05-17 15:45:06 -07:00
Peter Edberg
e69f337f3c ICU-21669 UPRV_UNREACHABLE > UPRV_UNREACHABLE_EXIT/ASSERT, update usages 2021-09-14 15:22:52 -07:00
Peter Varga
1986dcd0d8 ICU-21734 Add missing overrides 2021-09-07 17:42:14 -07:00
yumaoka
369357aaa7 ICU-21530 Added U_HIDE_DEPRECATED_API to deprecated methods. 2021-09-03 09:04:54 -04:00
Fredrik Roubert
633438f8da ICU-20973 Change all equality operator return types from UBool to bool. 2021-08-17 00:35:00 +02:00
luz paz
73eca0a9c9 ICU-21580 Fix typos in icu4c/
Found via `codespell -q 3 -L ans,anumber,atleast,ba,bre,hace,nd,nin,ois,rsource,som,sur,tht -S icu4c/source/data/zone,icu4c/source/data/lang`
ICU-21580 Fix source (related) typos
ICU-21580 Revert extraneous auto-encoding
ICU-21580 Re-add previous reverted fix without auto-encoding
2021-07-19 13:22:38 -05:00
Erik Torres
cfefa03539 ICU-21555 fix typos for D, E and F found in the repo
See #1714
2021-05-10 11:09:05 -07:00
Erik Torres Aguilar
bd3b202741 ICU-21018 Fix typos across repo that start with letter A
See #1506
2021-01-06 15:15:35 -08:00
Frank Tang
863582c2a4 ICU-20465 Calendar/DateFormat listen to tz extension
See #1176
2020-08-04 13:33:03 -07:00
Andy Heninger
afa9b9b48e ICU-20588 UMutex, add cleanup of underlying mutexes, and simplify usage model 2019-05-24 13:24:59 -07:00
Frank Tang
cb40d8b1a5 ICU-20595 Make icu::TimeZone::AdoptDefault thread safe
correct the mutex

Remove comments about not thread safe
2019-05-13 16:00:27 -07:00
Shane Carr
ab657778e4 ICU-20543 Fix -Wundef in library and test code. 2019-04-10 18:52:16 -07:00
Jeff Genovy
1188394d74 ICU-13820 ICU4C should use "Etc/Unknown" zone when host TZ detection fails.
Update API docs comments to clarify what is returned in failure cases.
2019-02-21 10:49:00 -08:00
Jeff Genovy
9f87d2d4be ICU-20413 ICU4C: OOM not handled in initStaticTimeZones() in timezone.cpp.
-Use static allocated memory and placement new to avoid OOM failures.
2019-02-20 10:41:40 -08:00
Jeff Genovy
4509ab7d96 ICU-20419 Export internal StackUResourceBundle helper, so it can be used in the i18n library.
Replace all current usages of ures_initStackObject() in the i18n library with the StackUResourceBundle helper.
2019-02-20 09:24:24 -08:00
Jeff Genovy
8858da9b7f ICU-20414 Add internal ures_openDirectFillIn API, use in getTZDataVersion to avoid memory allocation for UResourceBundle. 2019-02-19 16:58:38 -08:00
Jeff Genovy
1f17beb8eb ICU-20100 Change the name of the TimeZone::getDisplayName daylight parameter.
The TimeZone::getDisplayName "daylight" parameter conflicts with an existing macro in the CRT "time.h" header.
2019-02-13 10:55:43 -08:00
Daniel Ju
7453181fff ICU-20074 Define UPRV_UNREACHABLE macro for unreachable code
Replaced occurrences of U_ASSERT(FALSE) with new UPRV_UNREACHABLE macro.
2019-01-14 14:16:26 -08:00
Jeff Genovy
13ad1fe4e0 ICU-20194 TimeZone createSystemTimeZone doesn't set error code on OOM error. 2018-10-25 15:22:38 -07:00
Daniel Ju
b13c951348
ICU-20043 ICU-13214 ICU-13764 MSVC W3 and W4 warning cleanup (#53)
Cleaned up all of the MSVC W3 warnings and most of the W4 warnings in the common and i18n projects.
2018-09-27 14:27:38 -07:00
Jeff Genovy
275580806f ICU-13739 ICU4C does not report Out-of-Memory when iterating over the TZEnumeration.
X-SVN-Rev: 41309
2018-05-02 19:55:58 +00:00
Andy Heninger
242e02c388 ICU-12764 icu4c utf-8 source files, update Copyright notices.
X-SVN-Rev: 39583
2017-01-20 00:20:31 +00:00
Michael Ow
61607c2773 ICU-12564 Update copyright notice in trunk
X-SVN-Rev: 38848
2016-06-15 18:58:17 +00:00
Yoshito Umaoka
00ca13e126 ICU-12564 Reverted r38761 and r38762, because we want to prepend the Unicode copyright for existing source files, instead of replacing copyright comments.
X-SVN-Rev: 38776
2016-05-31 21:45:07 +00:00
Michael Ow
c9f199a30f ICU-12564 Update copyright notice in ICU4C
X-SVN-Rev: 38761
2016-05-26 22:32:17 +00:00
Michael Ow
13be2f95ae ICU-11623 Merge change to reset tz buffer
X-SVN-Rev: 38625
2016-04-18 22:33:45 +00:00
Peter Edberg
7d74634fa5 ICU-11433 BRS, no U_HIDE conditionals around impl code or private fields; fix comment typos
X-SVN-Rev: 37234
2015-03-16 04:15:28 +00:00
Yoshito Umaoka
3195f25068 ICU-11358 Separate host time zone detection code from the default time zone initialization code and make it public API as TimeZone::detectHostTimeZone().
X-SVN-Rev: 37148
2015-03-05 06:34:51 +00:00
Andy Heninger
b3c29ef95e ICU-11428 Various compiler warning fixes.
X-SVN-Rev: 36903
2014-12-19 23:41:18 +00:00
Steven R. Loomis
738cee69cc ICU-11389 improve error checking
X-SVN-Rev: 36758
2014-11-20 00:34:29 +00:00
Markus Scherer
90b6b64024 ICU-10561 ZoneMeta methods must check for bogus input strings
X-SVN-Rev: 34873
2014-01-10 23:14:14 +00:00
Steven R. Loomis
358e1ddcd2 ICU-10376 fixup clang warnings
X-SVN-Rev: 34385
2013-09-18 20:08:25 +00:00
Markus Scherer
8f38199123 ICU-10365 fix namespace issue: icu::UInitOnce
X-SVN-Rev: 34252
2013-09-10 00:34:12 +00:00
Steven R. Loomis
86c481026c ICU-10373 fix -DU_USING_ICU_NAMESPACE=0 issues
X-SVN-Rev: 34251
2013-09-10 00:13:41 +00:00