Frank Tang
ad0df7e4c8
ICU-22817 Use LocalPointer/Memory/Array to clarify ownership transfer
...
GHA ICU Merge CI / icu4j-converterperf (TestCharsetEncoderICU, korean, UTF-8) (push) Blocked by required conditions
GHA ICU Merge CI / icu4j-converterperf (TestCharsetEncoderICU, korean, csiso2022kr) (push) Blocked by required conditions
GHA ICU Merge CI / icu4j-converterperf (TestCharsetEncoderICU, s-chinese, EUC-CN) (push) Blocked by required conditions
GHA ICU Merge CI / icu4j-converterperf (TestCharsetEncoderICU, s-chinese, UTF-8) (push) Blocked by required conditions
GHA ICU Merge CI / icu4j-dateformatperf (en_US, "HH:mm Z" "13:13 -0800" 5, TestICUConstruction) (push) Blocked by required conditions
GHA ICU Merge CI / icu4j-dateformatperf (en_US, "HH:mm Z" "13:13 -0800" 5, TestICUFormat) (push) Blocked by required conditions
GHA ICU Merge CI / icu4j-dateformatperf (en_US, "HH:mm Z" "13:13 -0800" 5, TestICUParse) (push) Blocked by required conditions
GHA ICU Merge CI / icu4c-windows-msvc-postmerge (x64, Debug, x64) (push) Waiting to run
GHA ICU Merge CI / icu4c-windows-msvc-postmerge (x64, Release, x64) (push) Waiting to run
GHA ICU Merge CI / icu4c-windows-msvc-postmerge (x86, Debug, Win32) (push) Waiting to run
GHA ICU Merge CI / icu4c-windows-msvc-postmerge (x86, Release, Win32) (push) Waiting to run
GHA ICU Merge CI / icu4c-windows-cygwin-gcc (push) Waiting to run
GHA CI Valgrind / clang-valgrind-test (push) Waiting to run
GHA CI Valgrind / clang-valgrind-intltest (csdet) (push) Waiting to run
GHA CI Valgrind / clang-valgrind-intltest (format) (push) Waiting to run
GHA CI Valgrind / clang-valgrind-intltest (bidi) (push) Waiting to run
GHA CI Valgrind / clang-valgrind-intltest (collator) (push) Waiting to run
GHA CI Valgrind / clang-valgrind-intltest (convert) (push) Waiting to run
GHA CI Valgrind / clang-valgrind-intltest (icuserv) (push) Waiting to run
GHA CI Valgrind / clang-valgrind-intltest (idna) (push) Waiting to run
GHA CI Valgrind / clang-valgrind-intltest (normalize) (push) Waiting to run
GHA CI Valgrind / clang-valgrind-intltest (rbbi) (push) Waiting to run
GHA CI Valgrind / clang-valgrind-intltest (rbnf) (push) Waiting to run
GHA CI Valgrind / clang-valgrind-intltest (rbnfp) (push) Waiting to run
GHA CI Valgrind / clang-valgrind-intltest (rbnfrt) (push) Waiting to run
GHA CI Valgrind / clang-valgrind-intltest (regex) (push) Waiting to run
GHA CI Valgrind / clang-valgrind-intltest (spoof) (push) Waiting to run
GHA CI Valgrind / clang-valgrind-intltest (translit) (push) Waiting to run
GHA CI Valgrind / clang-valgrind-intltest (utility) (push) Waiting to run
Scorecard supply-chain security / Scorecard analysis (push) Waiting to run
See #3443
2025-03-24 16:24:02 -07:00
Fredrik Roubert
424d6a3e8b
ICU-22901 Update ulocimp_getSubtags() &co. to use std::string_view.
2024-11-22 19:05:03 +01:00
Frank Tang
a22dc93e3a
ICU-22825 Fix memLeak during error in tznames_impl.cpp
...
Rewrite the TextTrieMap::put() which should delete the value
during error instead of deleting key.
Rewrite to simplified the error handling.
2024-08-06 09:58:15 -07:00
Fredrik Roubert
0178a07a26
ICU-22793 Clang-Tidy: google-readability-casting
...
https://releases.llvm.org/17.0.1/tools/clang/tools/extra/docs/clang-tidy/checks/google/readability-casting.html
2024-07-04 22:32:12 +02:00
Fredrik Roubert
6ad78a08c7
ICU-22621 Clang-Tidy: readability-redundant-control-flow
...
https://releases.llvm.org/17.0.1/tools/clang/tools/extra/docs/clang-tidy/checks/readability/redundant-control-flow.html
2024-03-19 15:55:56 +01:00
Fredrik Roubert
ce052f52c2
ICU-22621 Clang-Tidy: readability-delete-null-pointer
...
https://releases.llvm.org/17.0.1/tools/clang/tools/extra/docs/clang-tidy/checks/readability/delete-null-pointer.html
2024-03-18 17:14:23 +01:00
Fredrik Roubert
5401c12018
ICU-22621 Clang-Tidy: modernize-use-nullptr
...
https://releases.llvm.org/17.0.1/tools/clang/tools/extra/docs/clang-tidy/checks/modernize/use-nullptr.html
2024-03-15 14:31:54 +01:00
Fredrik Roubert
53568e8dfc
ICU-22520 Refactor CharString & CharStringByteSink into helper.
...
The repeated sequence of allocating a CharString and CharStringByteSink,
before calling some function that writes into this, can be moved into a
single shared helper function which then is used to give all ulocimp.h
functions that write to ByteSink an overload that instead returns a
CharString, to make call sites look like perfectly normal C++ code.
2024-03-05 23:44:50 +01:00
Fredrik Roubert
939f08f274
ICU-22520 Use C++ function signatures for internal C++ functions.
...
Some of this code was originally written as C code and some of this code
was originally written as C++ code but made to resemble the then already
existing code that had once been C code. Changing it all to normal C++
now will make it easier and safer to work with going forward.
· Use unnamed namespace instead of static.
· Use reference instead of non-nullable pointer.
· Use bool instead of UBool.
· Use constexpr for static data.
· Use U_EXPORT instead of U_CAPI or U_CFUNC.
· Use the default calling convention instead of U_EXPORT2.
2024-02-12 21:44:06 +01:00
Frank Tang
abcb80fd53
ICU-22615 Test TimeZoneNames API will not assert with non ASCII.
...
Add tests and return error when the ID is non ASCII
2024-02-08 23:37:14 -08:00
Fredrik Roubert
d28e12b1f2
ICU-22520 Replace char arrays with icu::CharString.
2024-02-06 19:53:53 +01:00
Frank Tang
838227ce95
ICU-22614 Fix buffer overflow in TimeZoneNames
...
See #2752
2023-12-18 16:26:06 -08:00
Frank Tang
5cf5ec1adb
ICU-22549 Add TimeZoneNames fuzzer
2023-12-15 11:30:45 -08:00
Markus Scherer
b6dcc95d3c
ICU-21833 remove redundant void parameter lists
...
See #2351
2023-03-02 09:31:57 -08:00
Fredrik Roubert
2de88f9d9c
ICU-21833 Replace UChar with char16_t in all C++ code.
2023-02-06 19:27:44 +01:00
Fredrik Roubert
2e0d30cfcf
ICU-21833 Replace NULL with nullptr in all C++ code.
2023-02-03 20:20:38 +01:00
Fredrik Roubert
030fa1a479
ICU-21148 Consistently use standard lowercase true/false everywhere.
...
This is the normal standard way in C, C++ as well as Java and there's no
longer any reason for ICU to be different. The various internal macros
providing custom boolean constants can all be deleted and code as well
as documentation can be updated to use lowercase true/false everywhere.
2022-09-07 20:56:33 +02:00
Andy Heninger
85705f04e0
ICU-21960 C++20 Warnings from ATOMIC_VAR_INIT
...
Remove the ICU macros ATOMIC_INT32_T_INITIALIZER and U_INITONCE_INITIALIZER,
which made use of C++ ATOMIC_VAR_INIT, which has been removed from C++20.
With modern C++ features being available, these macros no longer served
any real need.
2022-05-17 15:45:06 -07:00
Andy Heninger
f66c8ca36b
ICU-21763 UVector cleanup in time zone code
...
Revise uses of UVector in time zone related code to better handle memory
allocation failures. This is one of an ongoing series of commits to address
similar problems with UVector usage throughout ICU.
The changes involve switching uses of UVector::addElementX() to the new
adoptElement() or addElement() functions, as appropriate, and using
LocalPointers for tracking memory ownership.
2021-10-29 17:37:13 -07:00
Peter Varga
1986dcd0d8
ICU-21734 Add missing overrides
2021-09-07 17:42:14 -07:00
Fredrik Roubert
0a1cfa398c
ICU-20973 Use standard keywords true & false to initialize type bool.
...
Now when all equality operators return standard bool (commit 633438f
2021-08-26 18:53:10 +02:00
Fredrik Roubert
633438f8da
ICU-20973 Change all equality operator return types from UBool to bool.
2021-08-17 00:35:00 +02:00
Andy Heninger
c26aebe802
ICU-21662 Rename UVector::addElement().
...
This is the first step towards improving the error handling and out-of-memory
behavior of UVector::addElement(). A followup PR will add back a new addElement()
with corrected error handling, then additional followups will switch call sites
from the original (renamed) function to the new addElement().
This commit includes no logic or behavior changes; it only renames the existing functions.
2021-07-28 15:36:50 -07:00
luz paz
73eca0a9c9
ICU-21580 Fix typos in icu4c/
...
Found via `codespell -q 3 -L ans,anumber,atleast,ba,bre,hace,nd,nin,ois,rsource,som,sur,tht -S icu4c/source/data/zone,icu4c/source/data/lang`
ICU-21580 Fix source (related) typos
ICU-21580 Revert extraneous auto-encoding
ICU-21580 Re-add previous reverted fix without auto-encoding
2021-07-19 13:22:38 -05:00
Erik Torres
3f043c7693
ICU-21555 Fix typos from G to L
...
See #1737
2021-06-07 16:09:09 -07:00
Markus Scherer
f02b496494
ICU-20783 C++ covariant return types: clone(), freeze() & friends
2019-08-22 16:24:41 -07:00
Andy Heninger
afa9b9b48e
ICU-20588 UMutex, add cleanup of underlying mutexes, and simplify usage model
2019-05-24 13:24:59 -07:00
Andy Heninger
b772241b52
ICU-20520 UMutex refactoring.
...
- Use STATIC_NEW for mutex creation, to avoid order-of-destruction problems
by avoiding destruction altogether, while avoiding memory leak reports.
- Remove UConditionVar, replace with direct use of std::condition_variable
2019-05-07 13:50:49 -07:00
Fredrik Roubert
4bd1ee008c
ICU-20445 Pass ByteSink to ulocimp_addLikelySubtags().
2019-04-23 19:45:28 +02:00
Andy Heninger
bc4bb89af2
ICU-20488 mutex static constructor fixes.
...
Remove the dependencies from the ICU library code on static constructors
that were introduced by using std::mutex and condition variables. The
mutexes are lazily initialized by embedding them as local static variables
in getter functions, and relying on the C++ compiler/runtime to do thread
safe initialization of them.
2019-03-12 09:52:16 -07:00
Daniel Ju
b13c951348
ICU-20043 ICU-13214 ICU-13764 MSVC W3 and W4 warning cleanup ( #53 )
...
Cleaned up all of the MSVC W3 warnings and most of the W4 warnings in the common and i18n projects.
2018-09-27 14:27:38 -07:00
Peter Edberg
0b5b91a70b
ICU-13366 Changes per Shane codereview comments
...
X-SVN-Rev: 40572
2017-10-05 20:36:07 +00:00
Peter Edberg
9ccab14af1
ICU-13366 part 1, fix TextTrieMap::search supplemental handling; make tz displayName buffer size bigger & logKnownIssue tests more specific
...
X-SVN-Rev: 40522
2017-10-02 03:42:54 +00:00
Yoshito Umaoka
ed012e1bfb
ICU-13312 Fixed getDisplayName crash issue caused by TZDBTimeZoneNames, added a test case for the fix that interate through all time zones.
...
X-SVN-Rev: 40412
2017-09-14 02:37:44 +00:00
William Zhao
d847a21238
ICU-13275 Merge warning cleanup fixes into trunk
...
X-SVN-Rev: 40283
2017-07-22 01:11:59 +00:00
George Rhoten
a82e70e5b1
ICU-13029 Mark unmodified static data as const
...
X-SVN-Rev: 40065
2017-04-19 18:55:46 +00:00
Markus Scherer
4c2fad3e36
ICU-12410 class Edits, class CaseMap with new low-level functions that work with Edits, simpler case properties code, some cleanup
...
X-SVN-Rev: 39684
2017-02-17 21:03:35 +00:00
Andy Heninger
242e02c388
ICU-12764 icu4c utf-8 source files, update Copyright notices.
...
X-SVN-Rev: 39583
2017-01-20 00:20:31 +00:00
Markus Scherer
3b23b78b95
ICU-12410 include what you use
...
X-SVN-Rev: 39553
2017-01-12 18:35:18 +00:00
Steven R. Loomis
a2ee3b1f28
ICU-11746 static analysis fixes
...
X-SVN-Rev: 39282
2016-09-19 18:52:48 +00:00
Shane Carr
d88a4109a5
ICU-11912 Adding more efficient implementation of getDisplayNames(), which was already present in Java
...
X-SVN-Rev: 39041
2016-08-11 23:29:51 +00:00
Shane Carr
0f403155dc
ICU-12646 Fixing Coverity code health issues on recently submitted code for TimeZoneNamesImpl and CompactDecimalDataCache
...
X-SVN-Rev: 39014
2016-07-21 23:01:53 +00:00
Shane Carr
fca98f1e7f
ICU-11912 Removing unused method 'consumeNoFallback', which was detected in Java unit test coverage.
...
X-SVN-Rev: 38969
2016-07-13 20:21:07 +00:00
Shane Carr
ad409a250e
ICU-11912 TimeZoneNames data sink implementation in C++.
...
X-SVN-Rev: 38960
2016-07-08 18:16:21 +00:00
Michael Ow
61607c2773
ICU-12564 Update copyright notice in trunk
...
X-SVN-Rev: 38848
2016-06-15 18:58:17 +00:00
Yoshito Umaoka
00ca13e126
ICU-12564 Reverted r38761 and r38762, because we want to prepend the Unicode copyright for existing source files, instead of replacing copyright comments.
...
X-SVN-Rev: 38776
2016-05-31 21:45:07 +00:00
Michael Ow
c9f199a30f
ICU-12564 Update copyright notice in ICU4C
...
X-SVN-Rev: 38761
2016-05-26 22:32:17 +00:00
Fredrik Roubert
7f4b8d106b
ICU-12012 Replace all sizeof p / sizeof *p with UPRV_LENGTHOF().
...
R=markus.icu@gmail.com
Review URL: https://codereview.appspot.com/285520043 .
X-SVN-Rev: 38337
2016-02-23 10:40:09 +00:00
Yoshito Umaoka
ae3f6f13a4
ICU-10934 The tz database abbreviation support in ICU4C
...
X-SVN-Rev: 36080
2014-07-23 21:51:09 +00:00
Andy Heninger
978f71fe78
ICU-10051 Mutexes: introduce UInitOnce; remove UMTX_CHECK; replace all uses of UMTX_CHECK.
...
X-SVN-Rev: 33787
2013-05-31 23:50:15 +00:00
