organicmaps/kothic
13
Fork 0
Code Issues Pull requests 2 Projects Releases Wiki Activity Actions

Add a ': none;' syntax for disabling area and icon drules #19

Merged
root merged 1 commit from pastk-drule-reset-syntax into master 2023-08-23 02:10:18 +00:00
Conversation 0 Commits 1 Files changed 1 +4 -4
pastk commented 2023-08-22 14:42:47 +00:00
Member
Copy link
No description provided.
vng (Migrated from github.com) approved these changes 2023-08-23 02:10:03 +00:00
src/libkomwm.py
@ -642,3 +642,3 @@
has_lines = True
if 'icon-image' in st or 'symbol-shape' in st or 'symbol-image' in st:
if 'icon-image' in st and st.get('icon-image') != 'none' or 'symbol-shape' in st or 'symbol-image' in st:
has_icons = True
vng (Migrated from github.com) commented 2023-08-23 02:09:58 +00:00
Copy link

Hm, just noticed, what do symbol-shape and symbol-image mean? Are they obsolete?

Hm, just noticed, what do symbol-shape and symbol-image mean? Are they obsolete?
pastk reviewed 2023-08-23 18:16:12 +00:00
src/libkomwm.py
@ -642,3 +642,3 @@
has_lines = True
if 'icon-image' in st or 'symbol-shape' in st or 'symbol-image' in st:
if 'icon-image' in st and st.get('icon-image') != 'none' or 'symbol-shape' in st or 'symbol-image' in st:
has_icons = True
pastk commented 2023-08-23 18:16:12 +00:00
Author
Member
Copy link

symbol-shape are for "circles", I don't know if they work, a quick experiment didn't show anything

symbol-image is used in one line only :) so redundant for sure

`symbol-shape` are for "circles", I don't know if they work, a quick experiment didn't show anything `symbol-image` is used in one line only :) so redundant for sure
Sign in to join this conversation.
Reviewers
No reviewers
vng
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/kothic#19
No description provided.
Delete branch "pastk-drule-reset-syntax"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?