Python 3 migration #2

Closed

strump wants to merge 1 commit from migrate-to-python3 into master

strump commented

2022-01-14 14:18:51 +00:00

Member

Fixed multiprocessing.
Added explicit data sorting.
Fixed float to string conversion.
Fixed explicit ordering of styles.

Compare to baseline

I compared this branch output to commit #cbaff545dd5d2343dcbd30285884dd4afa509d93 output.
Styles clear/style-clear, clear/style-night, vehicle/style-clear, and vehicle/style-night processed with Python2 and Python3 generated same output drules_proto_clear.txt, drules_proto_dark.txt, drules_proto_vehicle_clear.txt, and drules_proto_vehicle_dark.txt.

I sorted elements by priority to compare Python2 and Python3 outputs.

One difference is in float representation. In Python3 we have 4.2700000000000005 instead of 4.27. Here's discussion: https://stackoverflow.com/q/25898733 . This should not affect binary format created with ProtoBuf.

Please do comparing of old and new implementation because I could miss some cases!

Refactoring

Don't get me wrong, but code quality is far from best. There are a lot of places in libkomwm.py where code execution depends on order of styles. But in Python3 dict order is not the same as in Python2. And even more, dict doesn't guaranty ordering. So I put OrderedDict to freeze dict elements positions which looks like a hack.

I think unit-tests are needed and then refactoring.

Fixed multiprocessing. Added explicit data sorting. Fixed float to string conversion. Fixed explicit ordering of styles. ## Compare to baseline I compared this branch output to commit #cbaff545dd5d2343dcbd30285884dd4afa509d93 output. Styles `clear/style-clear`, `clear/style-night`, `vehicle/style-clear`, and `vehicle/style-night` processed with Python2 and Python3 generated same output `drules_proto_clear.txt`, `drules_proto_dark.txt`, `drules_proto_vehicle_clear.txt`, and `drules_proto_vehicle_dark.txt`. I sorted elements by priority to compare Python2 and Python3 outputs. One difference is in float representation. In Python3 we have `4.2700000000000005` instead of `4.27`. Here's discussion: https://stackoverflow.com/q/25898733 . This should not affect binary format created with ProtoBuf. Please do comparing of old and new implementation because I could miss some cases! ## Refactoring Don't get me wrong, but code quality is far from best. There are a lot of places in `libkomwm.py` where code execution depends on order of styles. But in Python3 `dict` order is not the same as in Python2. And even more, `dict` doesn't guaranty ordering. So I put `OrderedDict` to freeze dict elements positions which looks like a hack. I think unit-tests are needed and then refactoring.