Allow <1 dashdot values #28
No reviewers
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: organicmaps/kothic#28
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "pastk-small-dashdots"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
@ -754,3 +748,3 @@dr_line = LineRuleProto()dr_line.width = (st.get('width', 0) * WIDTH_SCALE)dr_line.width = st.get('width', 0)dr_line.color = mwm_encode_color(colors, st)WIDTH_SCALE not needed ?
@ -754,3 +748,3 @@dr_line = LineRuleProto()dr_line.width = (st.get('width', 0) * WIDTH_SCALE)dr_line.width = st.get('width', 0)dr_line.color = mwm_encode_color(colors, st)UPD: WIDTH_SCALE == 1. I'd keep it for consistency with other values.
@ -754,3 +748,3 @@dr_line = LineRuleProto()dr_line.width = (st.get('width', 0) * WIDTH_SCALE)dr_line.width = st.get('width', 0)dr_line.color = mwm_encode_color(colors, st)Effectively
WIDTH_SCALEis not used anywhere (an looks like never was used), so I see no point in keeping it in the code.I can remove all usages of it (its just a few) at once in this PR for consistency. WDYT?
@ -754,3 +748,3 @@dr_line = LineRuleProto()dr_line.width = (st.get('width', 0) * WIDTH_SCALE)dr_line.width = st.get('width', 0)dr_line.color = mwm_encode_color(colors, st)Remove if you think it will not be used.
@ -754,3 +748,3 @@dr_line = LineRuleProto()dr_line.width = (st.get('width', 0) * WIDTH_SCALE)dr_line.width = st.get('width', 0)dr_line.color = mwm_encode_color(colors, st)Done
Did you generate? No problem with int-float conversion?
Yes I regenerated and there are no conversion problems.