From 1222ae34fb77bbb5f5ca16f395b16d02380c68e1 Mon Sep 17 00:00:00 2001 From: Snild Dolkow Date: Fri, 29 Sep 2023 12:45:56 +0200 Subject: [PATCH] tests: Use SINGLE_BYTES in test_nobom_utf16_le All tests now run one instance where SINGLE_BYTES is equivalent to a single XML_Parse call. Using SINGLE_BYTES therefore gives more coverage, as evidenced by the new failure we now have to avoid in the test, until it can be fixed. --- expat/tests/basic_tests.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/expat/tests/basic_tests.c b/expat/tests/basic_tests.c index 53200019..4e49e8fe 100644 --- a/expat/tests/basic_tests.c +++ b/expat/tests/basic_tests.c @@ -159,11 +159,17 @@ START_TEST(test_bom_utf16_le) { } END_TEST -/* Parse whole buffer at once to exercise a different code path */ START_TEST(test_nobom_utf16_le) { char text[] = " \0<\0e\0/\0>\0"; - if (XML_Parse(g_parser, text, sizeof(text) - 1, XML_TRUE) == XML_STATUS_ERROR) + if (g_chunkSize == 1) { + // TODO: with just the first byte, we can't tell the difference between + // UTF-16-LE and UTF-8. Avoid the failure for now. + return; + } + + if (_XML_Parse_SINGLE_BYTES(g_parser, text, sizeof(text) - 1, XML_TRUE) + == XML_STATUS_ERROR) xml_failure(g_parser); } END_TEST