From 7165ae8bff9d26fb4b6289d709cf758b65e54c8c Mon Sep 17 00:00:00 2001 From: Sebastian Pipping Date: Thu, 24 Mar 2022 16:36:29 +0100 Subject: [PATCH] CMake: Fix pkg-config section "Libs" for MSVC --- expat/CMakeLists.txt | 6 +++++- expat/expat.pc.cmake | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/expat/CMakeLists.txt b/expat/CMakeLists.txt index ce69a278..ef0890f3 100644 --- a/expat/CMakeLists.txt +++ b/expat/CMakeLists.txt @@ -442,7 +442,10 @@ if(WIN32 AND NOT MINGW) # NOTE: "set_property(TARGET expat PROPERTY PREFIX lib)" would only affect *.dll # files but not *.lib files, so we have to rely on property OUTPUT_NAME, instead. # Property CMAKE_*_POSTFIX still applies. - set_property(TARGET expat PROPERTY OUTPUT_NAME libexpat) + set(_EXPAT_OUTPUT_NAME libexpat) + set_property(TARGET expat PROPERTY OUTPUT_NAME ${_EXPAT_OUTPUT_NAME}) +else() + set(_EXPAT_OUTPUT_NAME expat) endif() target_include_directories(expat @@ -494,6 +497,7 @@ if(EXPAT_BUILD_PKGCONFIG) string(TOLOWER "${_build_type}" _build_type_lower) string(TOUPPER "${_build_type}" _build_type_upper) set_property(TARGET expat PROPERTY "pkgconfig_${_build_type_lower}_name" "expat${CMAKE_${_build_type_upper}_POSTFIX}") + set_property(TARGET expat PROPERTY "pkgconfig_${_build_type_lower}_output_name" "${_EXPAT_OUTPUT_NAME}${CMAKE_${_build_type_upper}_POSTFIX}") if(_EXPAT_LIBM_FOUND) set_property(TARGET expat PROPERTY "pkgconfig_libm" "-lm") else() diff --git a/expat/expat.pc.cmake b/expat/expat.pc.cmake index 034b3a11..da7a0549 100644 --- a/expat/expat.pc.cmake +++ b/expat/expat.pc.cmake @@ -7,6 +7,6 @@ Name: $>_name> Version: $ Description: expat XML parser URL: https://libexpat.github.io/ -Libs: -L${libdir} -l$>_name> +Libs: -L${libdir} -l$>_output_name> Libs.private: $ Cflags: -I${includedir}