organicmaps/libexpat
13
Fork 0
mirror of https://github.com/libexpat/libexpat.git synced 2025-04-06 13:45:00 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions

tests: Replace invalid entity expansion in test_alloc_nested_entities

Browse source 
%pe2; would ultimately expand to a plain "ABCDEF...", which is not
valid in this context. This was not normally hit, since the test would
get its expected XML_ERROR_NO_MEMORY before expanding this far.

With g_chunkSize=0 and EXPAT_CONTEXT_BYTES=OFF, the number of allocs
required to reach that point becomes *just* low enough to reach the
final expansion, making the test fail with a very unexpected syntax
error.

Nesting %pe2; in another entity declaration avoids the problem.
This commit is contained in:
Snild Dolkow 2023-09-28 13:06:39 +02:00
parent b4d2b76a97
commit 7b0e27a698
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
expat/tests/alloc_tests.c
View file

@ -18,6 +18,7 @@
Copyright (c) 2019 David Loffredo <loffredo@steptools.com>
Copyright (c) 2020 Tim Gates <tim.gates@iress.com>
Copyright (c) 2021 Donghee Na <donghee.na@python.org>
Copyright (c) 2023 Sony Corporation / Snild Dolkow <snild@sony.com>
Licensed under the MIT license:
Permission is hereby granted, free of charge, to any person obtaining
@ -1645,7 +1646,7 @@ START_TEST(test_alloc_nested_entities) {
"ABCDEFGHIJKLMNOPABCDEFGHIJKLMNOPABCDEFGHIJKLMNOPABCDEFGHIJKLMNOP"
"'>\n"
"<!ENTITY % pe2 '%pe1;'>\n"
"%pe2;",
"<!ENTITY % pe3 '%pe2;'>",
"Memory Fail not faulted", NULL, XML_ERROR_NO_MEMORY};
/* Causes an allocation error in a nested storeEntityValue() */