From 7b9758517ba395e59e41b3c98500e532f82a2d26 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Berkay=20Eren=20=C3=9Cr=C3=BCn?= Date: Tue, 4 Mar 2025 13:04:07 +0100 Subject: [PATCH] Remove unnecessary triggerReenter calls callStoreEntityValue and storeAttributeValue call triggerReenter just before continuing with their main loop. This call does not have any use for the these functions as the continuity of their loop is already achieved by the continue key word. Only side effect these triggerReenter calls bring is that they cause a return to the the callProcessor, only to reenter to the same point again, wasting some time. This commit removes these unnecessary calls. --- expat/lib/xmlparse.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/expat/lib/xmlparse.c b/expat/lib/xmlparse.c index c1d7e8a5..d5161e93 100644 --- a/expat/lib/xmlparse.c +++ b/expat/lib/xmlparse.c @@ -6165,7 +6165,6 @@ storeAttributeValue(XML_Parser parser, const ENCODING *enc, XML_Bool isCdata, // process its possible inner entities (which are added to the // m_openAttributeEntities during appendAttributeValue) entity->hasMore = XML_FALSE; - triggerReenter(parser); continue; } // End of entity processing, "if" block skips the rest @@ -6617,7 +6616,6 @@ callStoreEntityValue(XML_Parser parser, const ENCODING *enc, // process its possible inner entities (which are added to the // m_openValueEntities during storeEntityValue) entity->hasMore = XML_FALSE; - triggerReenter(parser); continue; } // End of entity processing, "if" block skips the rest