organicmaps/libexpat
13
Fork 0
mirror of https://github.com/libexpat/libexpat.git synced 2025-04-04 21:04:57 +00:00
Code Issues 1 Projects Releases Wiki Activity Actions 19

Handle unreachable return locations

Browse source 
At some points we check m_reenter flag for return. However this flag can
never be true at these points. Therefore body of the check is never
executed. This commit excludes the body from test coverage, removes the
nextPtr update (since we faced an error, no need to update it) and
lastly makes them return XML_ERROR_UNEXPECTED_STATE as a safety net.
This commit is contained in:
Berkay Eren Ürün 2025-01-28 11:13:15 +01:00
parent e41a398e3f
commit c25f0cef93
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
expat/lib/xmlparse.c
View file

@ -2902,8 +2902,7 @@ externalEntityInitProcessor3(XML_Parser parser, const char *start,
return XML_ERROR_ABORTED;
case XML_PARSING:
if (parser->m_reenter) {
*endPtr = next;
return XML_ERROR_NONE;
return XML_ERROR_UNEXPECTED_STATE; // LCOV_EXCL_LINE
}
/* Fall through */
default:
@ -4342,8 +4341,7 @@ doCdataSection(XML_Parser parser, const ENCODING *enc, const char **startPtr,
return XML_ERROR_ABORTED;
case XML_PARSING:
if (parser->m_reenter) {
*nextPtr = next;
return XML_ERROR_NONE;
return XML_ERROR_UNEXPECTED_STATE; // LCOV_EXCL_LINE
}
/* Fall through */
default:;
@ -5962,8 +5960,7 @@ epilogProcessor(XML_Parser parser, const char *s, const char *end,
return XML_ERROR_ABORTED;
case XML_PARSING:
if (parser->m_reenter) {
*nextPtr = next;
return XML_ERROR_NONE;
return XML_ERROR_UNEXPECTED_STATE; // LCOV_EXCL_LINE
}
/* Fall through */
default:;