diff --git a/data/editor.config b/data/editor.config index 210ba5a081..3325b771c8 100644 --- a/data/editor.config +++ b/data/editor.config @@ -153,6 +153,21 @@ + + + + + + + + + + + + + + + @@ -170,15 +185,13 @@ - - + - + - @@ -189,23 +202,20 @@ - + - - + - + - - + - @@ -213,72 +223,62 @@ - - + - - + - - + - + - - + - - + - + - + - - - + - + - + - - - + - + - - + @@ -289,8 +289,7 @@ - - + @@ -302,28 +301,26 @@ - + - + - + - + - - + - @@ -333,12 +330,11 @@ - + - - + @@ -347,17 +343,16 @@ - + - - + - + @@ -368,86 +363,81 @@ - - + - - + - - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - - + - - + @@ -477,20 +467,18 @@ - + - - - + - + @@ -512,33 +500,31 @@ - - + - + - + - + - + - + - + - - + - + @@ -553,7 +539,7 @@ - + @@ -563,326 +549,251 @@ - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - - + - + - + - - + - + - - - + - + - - + - - + - - + - + - - + - - + - - + - - + - - + @@ -894,8 +805,7 @@ - - + @@ -911,21 +821,19 @@ - - + - - + - + - + - + @@ -933,13 +841,13 @@ - + - + - + @@ -979,14 +887,13 @@ - - + - + @@ -1005,70 +912,67 @@ - + - + - + - + - + - + - - + - + - + - + - + - + - + - + - - + - + - + - + - - + - + - + @@ -1161,12 +1060,10 @@ - - + - - + diff --git a/editor/editor_tests/editor_config_test.cpp b/editor/editor_tests/editor_config_test.cpp index cb5c4b9070..d2932e5d81 100644 --- a/editor/editor_tests/editor_config_test.cpp +++ b/editor/editor_tests/editor_config_test.cpp @@ -10,10 +10,11 @@ UNIT_TEST(EditorConfig_TypeDescription) using EType = feature::Metadata::EType; using Fields = editor::TypeAggregatedDescription::FeatureFields; - Fields const poi = { + Fields const poiInternet = { EType::FMD_OPEN_HOURS, EType::FMD_PHONE_NUMBER, EType::FMD_WEBSITE, + EType::FMD_INTERNET, EType::FMD_EMAIL, EType::FMD_LEVEL, EType::FMD_CONTACT_FACEBOOK, @@ -44,10 +45,7 @@ UNIT_TEST(EditorConfig_TypeDescription) TEST(config.GetTypeDescription({"shop-toys"}, desc), ()); TEST(desc.IsNameEditable(), ()); TEST(desc.IsAddressEditable(), ()); - auto fields = poi; - fields.push_back(EType::FMD_INTERNET); - base::SortUnique(fields); - TEST_EQUAL(desc.GetEditableFields(), fields, ()); + TEST_EQUAL(desc.GetEditableFields(), poiInternet, ()); } { // Test that amenity-bank is selected as it goes first in config. @@ -55,17 +53,14 @@ UNIT_TEST(EditorConfig_TypeDescription) TEST(config.GetTypeDescription({"amenity-bicycle_rental", "amenity-bank"}, desc), ()); TEST(desc.IsNameEditable(), ()); TEST(desc.IsAddressEditable(), ()); - auto fields = poi; - fields.push_back(EType::FMD_INTERNET); - base::SortUnique(fields); - TEST_EQUAL(desc.GetEditableFields(), fields, ()); + TEST_EQUAL(desc.GetEditableFields(), poiInternet, ()); } { // Testing type inheritance editor::TypeAggregatedDescription desc; TEST(config.GetTypeDescription({"amenity-place_of_worship-christian"}, desc), ()); TEST(desc.IsNameEditable(), ()); - TEST_EQUAL(desc.GetEditableFields(), poi, ()); + TEST_EQUAL(desc.GetEditableFields(), poiInternet, ()); } { // Testing long type inheritance on a fake object