organicmaps/organicmaps-tmp
Archived
13
Fork 1
Code Issues 2.7k Pull requests 182 Projects Releases 65 Wiki Activity Actions

[iOS] Avoid dummy copy.

Browse source 
Signed-off-by: vng <viktor.govako@gmail.com>
This commit is contained in:
vng 2021-04-26 22:36:29 +03:00 • committed by Viktor Govako
parent c76f604204
commit e061cdcf73
1 changed files with 16 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
iphone/CoreApi/CoreApi/Storage/MWMStorage.mm
View file

@ -38,25 +38,23 @@ using namespace storage;
_observers = [NSHashTable weakObjectsHashTable];
NSHashTable *observers = _observers;
auto const &countryFunction = [observers](CountryId const & countryId) {
NSHashTable *observersCopy = [observers copy];
for (id<MWMStorageObserver> observer in observersCopy) {
[observer processCountryEvent:@(countryId.c_str())];
}
};
auto const &progressFunction = [observers](CountryId const & countryId, downloader::Progress const & progress) {
NSHashTable *observersCopy = [observers copy];
for (id<MWMStorageObserver> observer in observersCopy) {
if ([observer respondsToSelector:@selector(processCountry:downloadedBytes:totalBytes:)]) {
[observer processCountry:@(countryId.c_str())
downloadedBytes:progress.m_bytesDownloaded
totalBytes:progress.m_bytesTotal];
GetFramework().GetStorage().Subscribe(
[observers](CountryId const & countryId) {
for (id<MWMStorageObserver> observer in observers) {
[observer processCountryEvent:@(countryId.c_str())];
}
}
};
GetFramework().GetStorage().Subscribe(countryFunction, progressFunction);
},
[observers](CountryId const & countryId, downloader::Progress const & progress) {
for (id<MWMStorageObserver> observer in observers) {
// processCountry function in observer's implementation may not exist.
/// @todo We can face with an invisible bug, if function's signature will be changed.
if ([observer respondsToSelector:@selector(processCountry:downloadedBytes:totalBytes:)]) {
[observer processCountry:@(countryId.c_str())
downloadedBytes:progress.m_bytesDownloaded
totalBytes:progress.m_bytesTotal];
}
}
});
}
return self;
}