organicmaps/organicmaps-tmp
Archived
13
Fork 1
Code Issues 2.7k Pull requests 182 Projects Releases 65 Wiki Activity Actions
41080 commits 238 branches 100 tags 7.7 GiB
Commit graph

4646 commits

Author SHA1 Message Date
zyphlar
5be700c916
Run info set and FillDescription again after getting address 2024-08-08 02:40:39 -07:00
zyphlar
14db5277d1
Fix place page as well 2024-07-11 23:22:22 -07:00
David Martinez
c519acac74 [placepage] FormatSubtitle: Restore withTypes parameter 
GetLocalizedAllTypes's assert was crashing when selecting a bookmark
that had no POI associated and therefore it had no types.

Now it will not invoke GetLocalizedAllTypes if withTypes is false.

Signed-off-by: David Martinez <47610359+dvdmrtnz@users.noreply.github.com>
 2024-07-03 21:37:25 -03:00
David Martinez
f16bf61607 [placepage] Show secondary types when name is empty 
[placepage] Only discard level=1 amenity, but show others like shop...

Signed-off-by: David Martinez <47610359+dvdmrtnz@users.noreply.github.com>
 2024-07-01 12:10:12 -03:00
David Martinez
80ff58e67b [placepage] Show all types 
Signed-off-by: David Martinez <47610359+dvdmrtnz@users.noreply.github.com>
 2024-06-27 22:47:47 +02:00
S. Kozyr
75c22cacd3 Introduced method PlacePageActivationListener.onSwitchFullScreenMode() 
Added onSwitchFullScreenMode listener call from JNI

Signed-off-by: S. Kozyr <s.trump@gmail.com>
 2024-06-18 23:18:59 +02:00
Kiryl Kaveryn
553d936a13 [core] split onClose and onSwitchFullScreen 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-06-18 23:18:59 +02:00
Kiryl Kaveryn
35be2a37d7 [ios] add assert on second LoadBookmarks call 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-06-11 11:40:57 +03:00
S. Kozyr
36b0265477 Refactoring of Framework::BuildPlacePageInfo function. 
Now it always returns place_page::Info struct. Changed return type and all places affected.

Signed-off-by: S. Kozyr <s.trump@gmail.com>
 2024-06-09 23:27:50 +02:00
S. Kozyr
6d260fe008 [drape] Single tap how selects any feature (POI, bookmark, line, or area) 
Long tap shows/hides the UI. Special case for buildings: on a tap building is selected in PP but selection circle is on tap position.

Signed-off-by: S. Kozyr <s.trump@gmail.com>
 2024-06-09 23:27:50 +02:00
Alexander Borsuk
296ce69fe0 [C++20] Use starts_with and ends_with 
Signed-off-by: Alexander Borsuk <me@alex.bio>
 2024-06-07 13:11:00 -03:00
Kiryl Kaveryn
450db38aec [bookmarks] implement recently deleted bookmarks and recovery support 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-06-07 15:25:27 +02:00
Kiryl Razhdzestvenski
d42503cdb3 Issue 8307. Add possibility to save gpx files to local storage 
Signed-off-by: Kiryl Razhdzestvenski <kirill.rozh@gmail.com>
 2024-06-03 16:26:21 +03:00
Harry Bond
4ed22bd8d1 Revert "[placepage] Show all types" 
This reverts commit 10b01c93d8.

Signed-off-by: Harry Bond <me@hbond.xyz>
 2024-05-31 23:12:19 +02:00
Kiryl Kaveryn
7b2ca3a65d [bookmarks] implement support for the icloud sync and bookmarks reloading 
Add methods:
- HasBookmark
- HasTrack
- ReloadBookmark
- ReloadBookmarkRoutine
Refactor methods:
- LoadBookmark
- NotifyAboutFinishAsyncLoading
- DeleteBmCategory
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>

Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-05-30 10:15:34 +03:00
cyber-toad
6e2fb9d5f8 [gpx] Add export buttons in Android and iOS 
Signed-off-by: cyber-toad <the.cyber.toad@proton.me>
 2024-05-30 08:08:02 +02:00
Kiryl Kaveryn
ad09f67da0 [bookmark] add HasBookmark to the bookmarks manager 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-05-27 23:39:28 -03:00
Viktor Govako
0cc2343b6a [base] Renamed XXXThreadPool for better understanding. 
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
 2024-05-27 23:17:15 -03:00
David Martinez
1276dc76f2 [styles] Rename styles to default/vehicle/outdoors + light/dark 
clear/style-clear    -> default/style-light
clear/style-night    -> default/style-dark
vehicle/style-clear  -> vehicle/style-light
vehicle/style-night  -> vehicle/style-dark
outdoors/style-clear -> outdoors/style-light
outdoors/style-night -> outdoors/style-dark

Signed-off-by: David Martinez <47610359+dvdmrtnz@users.noreply.github.com>
 2024-05-23 00:16:43 -03:00
David Martinez
10b01c93d8 [placepage] Show all types 
Signed-off-by: David Martinez <47610359+dvdmrtnz@users.noreply.github.com>
 2024-05-22 08:01:29 +02:00
Kiryl
4ce2c6ae78
[bookmarks] Reuse the MarkGroupId during the category reloading (#8234) 
[bookmarks] reuse category id for files with the same name

Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-05-21 23:28:22 -03:00
Viktor Govako
16ad61f4c8 [desktop] Disable traffic switch and TrafficManager initialization. 
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
 2024-05-18 21:23:28 +02:00
Konstantin Pastbin
ded9cff0da [classif] Deprecate waterway=riverbank 
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
 2024-05-14 20:25:13 -03:00
Konstantin Pastbin
871053e130 [classif] Deprecate landuse=farm 
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
 2024-05-14 20:25:13 -03:00
Will Bradley
ff8d6480e0 [strings][routing] Add TTS announcement of street names as an option 
Signed-off-by: Will Bradley <bradley.will@gmail.com>
 2024-05-14 22:34:21 +02:00
Alexander Borsuk
36136bde5c Fixed memory access past the end of the vector data 
Log printing uses charPtr as char const *, assuming that it's a null-terminated string. But it's a vector.
Signed-off-by: Alexander Borsuk <me@alex.bio>
 2024-05-09 23:46:32 +02:00
Kiryl
c3c00f1784
[Bookmarks] Add areAllCategoriesEmpty method to the bookmarks manager (#8100) 
* [ios] [bookmarks] add the `areAllCategoriesEmpty` method to the bookmarks manager

Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>

* [ios] [bookmarks] refactor the isCategoryNotEmpty method

`self.bm.IsCategoryEmpty` is used instead of `size()`

Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>

---------

Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-05-08 23:54:54 +02:00
cyber-toad
ada5327b4a [gpx] Add gpx export to core 
Signed-off-by: cyber-toad <the.cyber.toad@proton.me>
 2024-05-06 00:32:15 +02:00
map-per
60f6db585d [editor] Removed superfluous name=* restrictions 
Signed-off-by: map-per <map-per@gmx.de>
 2024-05-03 22:02:55 +02:00
David Martinez
4f96ee22e7 [placepage] Add missing local language name 
Signed-off-by: David Martinez <47610359+dvdmrtnz@users.noreply.github.com>
 2024-04-30 21:44:48 -03:00
Alexander Borsuk
45b1100c93 Save produced json in a more compact UTF-8 format 
This change will reduce the size of generated countries.txt from 405K to 355K
and speed up loading/decoding of the countries list.

Signed-off-by: Alexander Borsuk <me@alex.bio>
 2024-04-28 23:37:10 +02:00
Fábio Gomes
386e99b8c9 [routing] Update m_replaceWithMyPosition variable name 
Change name to m_replaceWithMyPositionAfterRestart in accordance to
what was suggested in my previous PR

Signed-off-by: Fábio Gomes <gabriel.gomes@tecnico.ulisboa.pt>
 2024-04-25 22:08:19 +02:00
Fábio Gomes
3cdb79fccb Fix #2833: Routing mode resets origin point to current location when re-opening the app 
The application replaced the origin point solely based on if it had found the user's location. Added a parameter to the RouteMarkData struct which is saved alongside the start point. This is used on start up to determine if the origin point of the route should be kept or replaced with the user's location (if one is found).

Signed-off-by: Fábio Gomes <gabriel.gomes@tecnico.ulisboa.pt>
 2024-04-24 19:34:49 +03:00
Viktor Govako
46241b0531 Update IsHotelChecker. 
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
 2024-04-06 15:48:04 -03:00
Alexander Borsuk
53aa9088ae [drape] Minor fixes 
Signed-off-by: Alexander Borsuk <me@alex.bio>
 2024-04-06 17:41:37 +02:00
Alexander Borsuk
59edac26f4 Updated tests for sorting by name 
Signed-off-by: Alexander Borsuk <me@alex.bio>
 2024-04-04 09:05:59 +03:00
Simon Klüber
cd5923ed69 [android][bookmarks] Add sorting bookmarks and tracks by name 
Signed-off-by: Simon Klüber <48260138+sklueber@users.noreply.github.com>
 2024-04-04 09:05:59 +03:00
Abhishek Bandyopadhyay
5670fe0ada [android] Fixed the crash while clicking on Deleted Bookmark Lists 
On Bookmarks Lists page, if a User has created a new List along with `My Places` List and then deletes it, the deleted item stays on the List. Now, if the user clicks on the deleted List Item then the app was crashing as the deleted item is unavailable. Root cause of this issue is below -
- When a `category` is deleted then `deleteCategory()` of `BookmarkManager` gets called.
- The `deleteCategory()` internally calls `nativeDeleteCategory()`.
- After a `category` is successfully deleted, then `OnBookmarksChanged()` should be invoked in order to update the List. But this wasn't happening. So deleted category wasn't getting removed from the cached list. Thus the user deleted category was visible even after deletion.
- When the user clicked on the deleted `category`, it'll eventually crash as the `category` itself isn't present

Fix: Properly notify the UI about the deleted list from BookmarkManager::NotifyChanges()
Fixes: #3828

Signed-off-by: Abhishek Bandyopadhyay <abhishek.gnit.ece@gmail.com>
Signed-off-by: Alexander Borsuk <me@alex.bio>
 2024-03-29 15:22:22 +02:00
Alexander Borsuk
d62e543a33 [bookmarks] Do not change bookmarks list modification date when hiding/showing it 
It introduces discrepancy as the file modification date will be newer than
modification date stored inside the KML.
 2024-03-29 14:02:57 +01:00
Viktor Govako
ce69a353e9 [search] Added struct QueryString. 
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
 2024-03-24 16:21:38 -03:00
Alexander Borsuk
4655ea66eb Set last modified time for imported KML or GPX before saving them 
Signed-off-by: Alexander Borsuk <me@alex.bio>
 2024-03-17 17:16:56 +01:00
Kiryl Kaveryn
01859c66cf [bookmarks] refactor UpdateBmGroupIdList method 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-03-17 11:54:47 -03:00
Kiryl Kaveryn
d641b8dc2e [bookmarks] [tests] fix bug when Bookmarks_SpecialXMLNames is working with unsorted IDs list 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-03-17 11:54:47 -03:00
Kiryl Kaveryn
0969987c91 [bookmarks] [tests] replace 'GetUnsortedBmGroupsIdList.count' with 'GetBmGroupsCount' 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-03-17 11:54:47 -03:00
Kiryl Kaveryn
d3a8ecf19d [bookmarks] rename bmGroupsIdList into unsortedBmGroupsIdList 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-03-17 11:54:47 -03:00
Kiryl Kaveryn
1465993076 [bookmarks] add 'GetBmGroupsCount' method 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-03-17 11:54:47 -03:00
Kiryl Kaveryn
239fd1a14d [bookmarks] add 'GetSortedBmGroupIdList' method to the BookmarkManager 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-03-17 11:54:47 -03:00
Kiryl Kaveryn
174fd82ae3 [bookmarks] add 'PrepareAllFilesForSharing' method 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-03-03 20:05:55 +02:00
Alexander Borsuk
a9805c1d19 Minor C++ fixes 
Signed-off-by: Alexander Borsuk <me@alex.bio>
 2024-02-29 10:05:55 +02:00
Kiryl Kaveryn
c9cbb24415 [bookmarks] implement the track color updating 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-02-28 10:05:39 +02:00