organicmaps/organicmaps-tmp
Archived
13
Fork 1
Code Issues 2.7k Pull requests 182 Projects Releases 65 Wiki Activity Actions
41696 commits 238 branches 100 tags 7.7 GiB
Commit graph

370 commits

Author SHA1 Message Date
kavikhalique
53e9d3172c removed redundant code 
Signed-off-by: kavikhalique <kavikhalique3@gmail.com>
 2024-09-21 23:21:30 -03:00
kavikhalique
c1d7287a18 Track editing fix 
Signed-off-by: kavikhalique <kavikhalique3@gmail.com>
 2024-09-21 23:21:30 -03:00
kavikhalique
55038e1cd6 [android] Implements Track Editing 
Signed-off-by: kavikhalique <kavikhalique3@gmail.com>
 2024-09-19 22:39:10 +03:00
Kiryl Kaveryn
c23a535dba [gps] add timestams and altitudes to the recorded track points 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-09-03 18:21:06 +02:00
Alexander Borsuk
a2d059da91 Replaced GpsTrackInfo with GpsInfo 
TODO: There is an inefficient copying in void GpsTrackFilter::Process
that can be refactored

Signed-off-by: Alexander Borsuk <me@alex.bio>
 2024-08-27 11:50:16 +02:00
Kiryl Kaveryn
fe4b844c11 [map] [bookmarks] implement recorded track saving 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-08-25 15:56:32 +02:00
Kiryl Kaveryn
ea7a17ba68 [bookmarks] delete category files by moving to the .Trash dir 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-08-15 12:59:33 +02:00
Alexander Borsuk
fb011eac33 [android] Fixed invalid mime types for gpx and kmz 
Signed-off-by: Alexander Borsuk <me@alex.bio>
 2024-08-01 07:39:06 +02:00
Kiryl Kaveryn
35be2a37d7 [ios] add assert on second LoadBookmarks call 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-06-11 11:40:57 +03:00
Kiryl Kaveryn
450db38aec [bookmarks] implement recently deleted bookmarks and recovery support 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-06-07 15:25:27 +02:00
Kiryl Razhdzestvenski
d42503cdb3 Issue 8307. Add possibility to save gpx files to local storage 
Signed-off-by: Kiryl Razhdzestvenski <kirill.rozh@gmail.com>
 2024-06-03 16:26:21 +03:00
Kiryl Kaveryn
7b2ca3a65d [bookmarks] implement support for the icloud sync and bookmarks reloading 
Add methods:
- HasBookmark
- HasTrack
- ReloadBookmark
- ReloadBookmarkRoutine
Refactor methods:
- LoadBookmark
- NotifyAboutFinishAsyncLoading
- DeleteBmCategory
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>

Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-05-30 10:15:34 +03:00
cyber-toad
6e2fb9d5f8 [gpx] Add export buttons in Android and iOS 
Signed-off-by: cyber-toad <the.cyber.toad@proton.me>
 2024-05-30 08:08:02 +02:00
Kiryl Kaveryn
ad09f67da0 [bookmark] add HasBookmark to the bookmarks manager 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-05-27 23:39:28 -03:00
Kiryl
4ce2c6ae78
[bookmarks] Reuse the MarkGroupId during the category reloading (#8234) 
[bookmarks] reuse category id for files with the same name

Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-05-21 23:28:22 -03:00
Alexander Borsuk
36136bde5c Fixed memory access past the end of the vector data 
Log printing uses charPtr as char const *, assuming that it's a null-terminated string. But it's a vector.
Signed-off-by: Alexander Borsuk <me@alex.bio>
 2024-05-09 23:46:32 +02:00
Kiryl
c3c00f1784
[Bookmarks] Add areAllCategoriesEmpty method to the bookmarks manager (#8100) 
* [ios] [bookmarks] add the `areAllCategoriesEmpty` method to the bookmarks manager

Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>

* [ios] [bookmarks] refactor the isCategoryNotEmpty method

`self.bm.IsCategoryEmpty` is used instead of `size()`

Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>

---------

Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-05-08 23:54:54 +02:00
Simon Klüber
cd5923ed69 [android][bookmarks] Add sorting bookmarks and tracks by name 
Signed-off-by: Simon Klüber <48260138+sklueber@users.noreply.github.com>
 2024-04-04 09:05:59 +03:00
Abhishek Bandyopadhyay
5670fe0ada [android] Fixed the crash while clicking on Deleted Bookmark Lists 
On Bookmarks Lists page, if a User has created a new List along with `My Places` List and then deletes it, the deleted item stays on the List. Now, if the user clicks on the deleted List Item then the app was crashing as the deleted item is unavailable. Root cause of this issue is below -
- When a `category` is deleted then `deleteCategory()` of `BookmarkManager` gets called.
- The `deleteCategory()` internally calls `nativeDeleteCategory()`.
- After a `category` is successfully deleted, then `OnBookmarksChanged()` should be invoked in order to update the List. But this wasn't happening. So deleted category wasn't getting removed from the cached list. Thus the user deleted category was visible even after deletion.
- When the user clicked on the deleted `category`, it'll eventually crash as the `category` itself isn't present

Fix: Properly notify the UI about the deleted list from BookmarkManager::NotifyChanges()
Fixes: #3828

Signed-off-by: Abhishek Bandyopadhyay <abhishek.gnit.ece@gmail.com>
Signed-off-by: Alexander Borsuk <me@alex.bio>
 2024-03-29 15:22:22 +02:00
Alexander Borsuk
d62e543a33 [bookmarks] Do not change bookmarks list modification date when hiding/showing it 
It introduces discrepancy as the file modification date will be newer than
modification date stored inside the KML.
 2024-03-29 14:02:57 +01:00
Viktor Govako
ce69a353e9 [search] Added struct QueryString. 
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
 2024-03-24 16:21:38 -03:00
Alexander Borsuk
4655ea66eb Set last modified time for imported KML or GPX before saving them 
Signed-off-by: Alexander Borsuk <me@alex.bio>
 2024-03-17 17:16:56 +01:00
Kiryl Kaveryn
01859c66cf [bookmarks] refactor UpdateBmGroupIdList method 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-03-17 11:54:47 -03:00
Kiryl Kaveryn
d3a8ecf19d [bookmarks] rename bmGroupsIdList into unsortedBmGroupsIdList 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-03-17 11:54:47 -03:00
Kiryl Kaveryn
239fd1a14d [bookmarks] add 'GetSortedBmGroupIdList' method to the BookmarkManager 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-03-17 11:54:47 -03:00
Kiryl Kaveryn
174fd82ae3 [bookmarks] add 'PrepareAllFilesForSharing' method 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-03-03 20:05:55 +02:00
Kiryl Kaveryn
c9cbb24415 [bookmarks] implement the track color updating 
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
 2024-02-28 10:05:39 +02:00
cyber-toad
985d9afb43 [bookmarks] Add code to export multiple files 
Signed-off-by: cyber-toad <the.cyber.toad@proton.me>
 2024-02-28 09:34:38 +02:00
Alexander Borsuk
fb22b93369 [android] Cast vector to jlong to avoid tmp allocation, and other fixes 
Signed-off-by: Alexander Borsuk <me@alex.bio>
 2024-02-06 21:26:42 -03:00
cyber-toad
a535f5256c [bookmarks] Use list of categories ids in java/cpp 
Signed-off-by: cyber-toad <the.cyber.toad@proton.me>
 2024-02-06 21:26:42 -03:00
cyber-toad
b3702a730d [kml] Load all kmls from kmz file 
Signed-off-by: cyber-toad <the.cyber.toad@proton.me>
 2023-12-12 19:14:15 -03:00
meenbeese
7654b81bb0 [bookmarks] Remove max limit to search bookmarks 
Signed-off-by: meenbeese <meenbeese@tutanota.com>
 2023-10-10 21:26:35 -03:00
S. Kozyr
eb179d3ede Fixed GPX files import 
Signed-off-by: S. Kozyr <s.trump@gmail.com>
 2023-10-03 00:39:32 +02:00
S. Kozyr
1598a7cc44 Small changes according to PR comments 
Signed-off-by: S. Kozyr <s.trump@gmail.com>
 2023-10-03 00:39:32 +02:00
S. Kozyr
478283e5bc Fixed KMB files import. 
Improved import errors handling.

Signed-off-by: S. Kozyr <s.trump@gmail.com>
 2023-10-03 00:39:32 +02:00
Konstantin Pastbin
98cde7b983 [core] Fix minor warnings 
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
 2023-09-25 14:41:52 -03:00
Alexander Borsuk
45a65e2c60 Minor clang-tidy fixes 
Signed-off-by: Alexander Borsuk <me@alex.bio>
 2023-07-09 22:15:58 +02:00
Alexander Borsuk
c01a1a6fa3
Properly import files with upper-case extensions (#5493) 
* Properly import files with upper-case extensions

Signed-off-by: Alexander Borsuk <me@alex.bio>
 2023-07-09 15:19:46 +02:00
Alexander Borsuk
344659fa6b Fixed kml.kmz for bookmarks sharing 
Signed-off-by: Alexander Borsuk <me@alex.bio>
 2023-06-22 07:29:21 +02:00
cyber-toad
67aa775abb
[gpx] Use string_view for bookmark file extensions (#5284) 
* [gpx] Use string_view for bookmark file extensions

Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

* Fixed string_view to string conversion

Signed-off-by: Alexander Borsuk <me@alex.bio>

* Follow-up fixes

Signed-off-by: Alexander Borsuk <me@alex.bio>

* Review fixes

Signed-off-by: Alexander Borsuk <me@alex.bio>

* Compile fix

Signed-off-by: Alexander Borsuk <me@alex.bio>

* append does not create a temporary :)

Signed-off-by: Alexander Borsuk <me@alex.bio>

* Avoid duplicate path

Signed-off-by: Alexander Borsuk <me@alex.bio>

---------

Signed-off-by: cyber-toad <the.cyber.toad@proton.me>
Signed-off-by: Alexander Borsuk <me@alex.bio>
Co-authored-by: Alexander Borsuk <me@alex.bio>
 2023-06-14 14:16:39 +02:00
cyber-toad
dce7c2186d
[Draft] [gpx] Add gpx import (#5166) 
* [gpx][ios] Add GPX to OMaps.plist

Signed-off-by: David Martinez <47610359+dvdmrtnz@users.noreply.github.com>

* [gpx][android] Add GPX to AndroidManifest.xml

Signed-off-by: David Martinez <47610359+dvdmrtnz@users.noreply.github.com>

* [gpx] Add serdes_gpx

Signed-off-by: David Martinez <47610359+dvdmrtnz@users.noreply.github.com>

* [gpx] Add GPX to bookmark_helpers

Signed-off-by: David Martinez <47610359+dvdmrtnz@users.noreply.github.com>

* [gpx][android] Add GPX to Framework.cpp

Signed-off-by: David Martinez <47610359+dvdmrtnz@users.noreply.github.com>

* [gpx] Add GPX test

Signed-off-by: David Martinez <47610359+dvdmrtnz@users.noreply.github.com>

* [android] Adjust gpx filter
Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

* [gpx] Update test and manifest
Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

* [gpx] Apply code-review suggestions
Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

* [gpx] Add basic parser tests for real gpx tracks
Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

* [gpx] Remove unused code, add test for waypoints only
Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

* [gpx] Support of gpx route (rte/rtept tag)
Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

* [gpx] Rework parser to use string_view
Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

* [gpx] Remove unsupported parameters

Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

* [gpx] Add support for <color> tag

Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

* [gpx] Fix name/description extraction
Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

* [gpx] Implement code-review suggestions

Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

* [gpx] Extract track & category names from file name

Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

* [gpx] Implement code-review suggestions

Signed-off-by: cyber-toad <the.cyber.toad@proton.me>

---------

Signed-off-by: David Martinez <47610359+dvdmrtnz@users.noreply.github.com>
Signed-off-by: cyber-toad <the.cyber.toad@proton.me>
Co-authored-by: David Martinez <47610359+dvdmrtnz@users.noreply.github.com>
 2023-06-04 19:14:43 +02:00
Viktor Govako
e6bbd78d55 [base] Make simple ReadFile function without FileReader overhead (inner caches). 
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
 2023-01-30 16:55:41 -03:00
Viktor Govako
abe77ce8ae Improved isSearchAllowed calls. 
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
 2022-12-30 23:52:49 +01:00
Viktor Govako
fd906da12e [bookmarks] Added CHECKs for GetGroup, GetBmCategory. 
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
 2022-12-30 23:52:49 +01:00
Viktor Govako
a52cc891e2 [kml] Support multiple track geometry. 
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
 2022-12-01 13:42:18 +03:00
Viktor Govako
1f83266198 [bookmarks] Avoid useless savings on startup. 
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
 2022-10-23 08:08:11 +03:00
Viktor Govako
339fa2f2cd [bookmarks] Fixed last modified time categories order. 
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
 2022-08-30 12:29:36 +03:00
Viktor Govako
529aa39f05 Accept strings by value instead of explicit copy. 
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
 2022-08-28 18:01:55 +03:00
Viktor Govako
4090cecb69 [bookmarks] Took out helper code from BookmarkManager. 
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
 2022-08-28 18:01:55 +03:00
Ivan Koshkin
c59766cfe7 [ios] Added new edit abilities for tracks and bookmarks 
iOS UI/UX changes:
- bookmark can be moved to other group with right swipe directly from the bookmarks list (no need to open "Edit bookmark" screen)
- bookmark can be edited right from the list: swipe left and select "Edit"
- new ability: edit track. Swipe track left in the list and select "Edit". Track name and track group can be changed (but not the color yet)
- new ability: tracks can be deleted. Swipe track left and select "Delete"
- track can be moved to other group with right swipe directly from the bookmark list

Fixes:
- bookmark title is now correctly updated in UI after bookmark was changed - in popover window and in bookmarks list

Internal changes:
- added framework methods to move, delete and update tracks
- added few framework methods to move bookmark by id, move track by id, get bookmark and track category, get specific track or bookmark, get bookmark description by id

Signed-off-by: Ivan Koshkin <ivan@koshkin.me>
 2021-07-28 11:38:01 +03:00