[ios] iCloud bug - Send NSMetadata item of deleted file into the `Updated` list instead of `Deleted` #10041

New issue

Open

opened 2025-01-10 08:50:43 +00:00 by kirylkaveryn · 0 comments

kirylkaveryn commented

2025-01-10 08:50:43 +00:00

Member

The deleted from the iCloud file appears in the Updated list, leading to the incorrect file URL and iCloud sync exception throwing.

Bug description

The user deletes the List
The FileManagere calls the trashItem to move the file from the OM iCloud directory to the Trach (Recently Deleted in the Files app)
The file is successfully trashed
The iCloud sends the newly updated lists of metadata items to the app and the deleted item exists in this list. It contains the deleted file in the list of updated items instead of deleted.
The File manager attempts to copy the file back from the iCloud to the Local dir, but there is no file and the manager raises an exception.

Logs from the user

Important

I(1) 8535.82284 CloudDirectoryMonitor.swift:186 queryDidUpdate(:): Removed from the cloud content (0):
I(1) 8535.82292 SynchronizationStateResolver.swift:74 resolveEvent(:): Events to process (0):

--- 1. The user deletes the List
I(1) 8536.22632 map/bookmark_manager.cpp:2625 DeleteBmCategory(): Category at /var/mobile/Containers/Data/Application/xxx/Documents/bookmarks/TARGET_FILE.kml is trashed to the /var/mobile/Containers/Data/Application/xxx/Documents/.Trash/TARGET_FILE.kml
I(1) 8536.75851 LocalDirectoryMonitor.swift:170 didUpdate(:): Local contents (32):
I(1) 8536.75861 LocalDirectoryMonitor.swift:171 didUpdate(:): fileName: x.kml, lastModified: 1736073775.0
I(1) 8536.75864 LocalDirectoryMonitor.swift:171 didUpdate(:): fileName: y.kml, lastModified: 1735909687.0
I(1) 8536.75867 LocalDirectoryMonitor.swift:171 didUpdate(:): fileName: x - Ilm_1.kml, lastModified: 1735389409.0
I(1) 8536...
I(1) 8536.75951 LocalDirectoryMonitor.swift:171 didUpdate(:): fileName: z.kml, lastModified: 1703881765.0
I(1) 8536.75954 LocalDirectoryMonitor.swift:172 didUpdate(:): Added to the local content (0):
I(1) 8536.75955 LocalDirectoryMonitor.swift:173 didUpdate(:): Updated in the local content (0):
--- The file appears to be deleted
I(1) 8536.75957 LocalDirectoryMonitor.swift:174 didUpdate(:): Removed from the local content (1):
fileName: TARGET_FILE.kml, lastModified: 1736358594.0
I(1) 8536.75964 SynchronizationStateResolver.swift:74 resolveEvent(:): Events to process (1):
I(1) 8536.75987 SynchronizationStateResolver.swift:75 resolveEvent(:): removeCloudItem(Organic_Maps.CloudMetadataItem(fileName: "TARGET_FILE.kml", fileUrl: file:///var/mobile/Library/Mobile%20Documents/iCloud~~app~~organicmaps/Documents/Gro%C3%9Fe%20Striegis.kml, isDownloaded: true, lastModificationDate: 1736358594.0, downloadingError: nil, uploadingError: nil, hasUnresolvedConflicts: false))

--- 2. The FileManagere calls the trashItem to move the file from the OM iCloud directory to the Trach (Recently Deleted in the Files app)
I(12) 8536.75993 SynchronizationFileWriter.swift:129 removeFromCloudContainer(_:completion:): Trash file TARGET_FILE.kml to the iCloud trash
--- 3. The file is successfully trashed

I(1) 8536.77919 Classes/MapsAppDelegate.mm:172 -[MapsAppDelegate applicationWillResignActive:]: applicationWillResignActive - begin
I(1) 8536.78172 Location/MWMLocationManager.mm:580 -[MWMLocationManager stop]: Stop updating location
I(1) 8536.78719 Classes/MapsAppDelegate.mm:185 -[MapsAppDelegate applicationWillResignActive:]: applicationWillResignActive - end
I(1) 8537.65270 Classes/MapsAppDelegate.mm:155 -[MapsAppDelegate applicationDidEnterBackground:]: applicationDidEnterBackground - begin
I(1) 8537.65321 Classes/MapsAppDelegate.mm:168 -[MapsAppDelegate applicationDidEnterBackground:]: applicationDidEnterBackground - end
I(1) 8537.65729 SynchronizaionManager.swift:152 pauseSynchronization(): Pause synchronization
I(1) 8542.60661 map/framework.cpp:1198 MemoryWarning(): MemoryWarning
I(1) 8544.63179 Classes/MapsAppDelegate.mm:189 -[MapsAppDelegate applicationWillEnterForeground:]: applicationWillEnterForeground - begin
I(1) 8544.63485 DeepLinkHandler.swift:72 handleFileImport(url:): handleFileImport: file:///private/var/mobile/Containers/Data/Application/xxx/Documents/Inbox/y.gpx
I(5) 8544.68205 map/bookmark_helpers.cpp:595 SaveKmlFileSafe(): Save kml file of type Text to /var/mobile/Containers/Data/Application/xxx/Documents/bookmarks/x.kml
I(1) 8544.68813 DefaultAlert/MWMDefaultAlert.mm:369 +[MWMDefaultAlert defaultAlertWithTitle:message:rightButtonTitle:leftButtonTitle:rightButtonAction:log:]: Info Alert
I(1) 8545.08362 Classes/MapsAppDelegate.mm:210 -[MapsAppDelegate applicationDidBecomeActive:]: applicationDidBecomeActive - begin
I(1) 8545.09909 Location/MWMLocationManager.mm:548 -[MWMLocationManager startUpdatingLocationFor:]: Start updating location
I(1) 8545.10260 Classes/MapsAppDelegate.mm:227 -[MapsAppDelegate applicationDidBecomeActive:]: applicationDidBecomeActive - end
I(1) 8545.10475 SynchronizaionManager.swift:158 resumeSynchronization(): Resume synchronization

--- 4. The iCloud sends the newly updated lists of metadata items to the app and the deleted item exists in this list
I(1) 8545.12391 CloudDirectoryMonitor.swift:182 queryDidUpdate(:): Cloud contents (33):
I(1) 8545.12393 CloudDirectoryMonitor.swift:183 queryDidUpdate(:): fileName: x.kml, lastModified: 1730878743.0
I(1) 8545.12395 CloudDirectoryMonitor.swift:183 queryDidUpdate(:): fileName: y.kml, lastModified: 1703881765.0
...
I(1) 8545.12455 CloudDirectoryMonitor.swift:183 queryDidUpdate(:): fileName: a, lastModified: 1736358594.0
I(1) 8545.12458 CloudDirectoryMonitor.swift:183 queryDidUpdate(:): fileName: TARGET_FILE.kml, lastModified: 1736358594.0
I(1) 8545.12460 CloudDirectoryMonitor.swift:184 queryDidUpdate(:): Added to the cloud content (0):

--- It contains the deleted file in the list of updated items instead of deleted
I(1) 8545.12461 CloudDirectoryMonitor.swift:185 queryDidUpdate(:): Updated in the cloud content (1):
fileName: TARGET_FILE.kml, lastModified: 1736358594.0
I(1) 8545.12462 CloudDirectoryMonitor.swift:186 queryDidUpdate(:): Removed from the cloud content (0):
I(1) 8545.12468 SynchronizationStateResolver.swift:74 resolveEvent(_:): Events to process (1):

--- 5. The File manager attempts to copy the file back from the iCloud to the Local dir
I(1) 8545.12523 SynchronizationStateResolver.swift:75 resolveEvent(:): createLocalItem(with: Organic_Maps.CloudMetadataItem(fileName: "TARGET_FILE.kml", fileUrl: file:///private/var/mobile/Library/Mobile%20Documents/iCloud~~app~~organicmaps/Documents/Gro%C3%9Fe%20Striegis.kml, isDownloaded: true, lastModificationDate: 1736358594.0, downloadingError: nil, uploadingError: nil, hasUnresolvedConflicts: false))
I(13) 8545.20669 SynchronizationFileWriter.swift:66 writeToLocalContainer(:completion:): Write file TARGET_FILE.kml to the local directory

--- but there is no file and the manager raises an exception.

E(1) 8545.25526 SynchronizaionManager.swift:286 processError(_:): System Error: Die Datei „TARGET_FILE.kml“ konnte nicht geöffnet werden, da sie nicht existiert.
I(1) 8545.25528 SynchronizaionManager.swift:139 stopSynchronization(withError:): Stop synchronization
I(1) 8545.25571 SynchronizaionManager.swift:139 stopSynchronization(withError:): Stop synchronization

Possible reasons

Depending on the iOS versions and the platform (ios/macos) when the file is deleted from the iCloud directory the NSMetadata updates may differ and send different info. Sometimes the deleted file appears in the deleted list, sometimes at the first update in the updated with the new URL (that contains ./Trash in the path) and only after that in the deleted list.
I will investigate how it works and updated the issue.

The deleted from the iCloud file appears in the Updated list, leading to the incorrect file URL and iCloud sync exception throwing. ### Bug description 1. The user deletes the List 2. The FileManagere calls the `trashItem` to move the file from the OM iCloud directory to the Trach (Recently Deleted in the Files app) 3. The file is successfully trashed 4. The iCloud sends the newly updated lists of metadata items to the app and the deleted item **exists** in this list. It contains the deleted file in the list of `updated` items instead of `deleted`. 5. The File manager attempts to copy the file back from the iCloud to the Local dir, but there is no file and the manager raises an exception. ### Logs from the user > [!important] > > > I(1) 8535.82284 CloudDirectoryMonitor.swift:186 queryDidUpdate(_:): Removed from the cloud content (0): > I(1) 8535.82292 SynchronizationStateResolver.swift:74 resolveEvent(_:): Events to process (0): > > --- 1. The user deletes the List > I(1) 8536.22632 map/bookmark_manager.cpp:2625 DeleteBmCategory(): Category at /var/mobile/Containers/Data/Application/xxx/Documents/bookmarks/TARGET_FILE.kml is trashed to the /var/mobile/Containers/Data/Application/xxx/Documents/.Trash/TARGET_FILE.kml > I(1) 8536.75851 LocalDirectoryMonitor.swift:170 didUpdate(_:): Local contents (32): > I(1) 8536.75861 LocalDirectoryMonitor.swift:171 didUpdate(_:): fileName: x.kml, lastModified: 1736073775.0 > I(1) 8536.75864 LocalDirectoryMonitor.swift:171 didUpdate(_:): fileName: y.kml, lastModified: 1735909687.0 > I(1) 8536.75867 LocalDirectoryMonitor.swift:171 didUpdate(_:): fileName: x - Ilm_1.kml, lastModified: 1735389409.0 > I(1) 8536... > I(1) 8536.75951 LocalDirectoryMonitor.swift:171 didUpdate(_:): fileName: z.kml, lastModified: 1703881765.0 > I(1) 8536.75954 LocalDirectoryMonitor.swift:172 didUpdate(_:): Added to the local content (0): > I(1) 8536.75955 LocalDirectoryMonitor.swift:173 didUpdate(_:): Updated in the local content (0): > --- The file appears to be deleted > I(1) 8536.75957 LocalDirectoryMonitor.swift:174 didUpdate(_:): Removed from the local content (1): > fileName: TARGET_FILE.kml, lastModified: 1736358594.0 > I(1) 8536.75964 SynchronizationStateResolver.swift:74 resolveEvent(_:): Events to process (1): > I(1) 8536.75987 SynchronizationStateResolver.swift:75 resolveEvent(_:): removeCloudItem(Organic_Maps.CloudMetadataItem(fileName: "TARGET_FILE.kml", fileUrl: file:///var/mobile/Library/Mobile%20Documents/iCloud~app~organicmaps/Documents/Gro%C3%9Fe%20Striegis.kml, isDownloaded: true, lastModificationDate: 1736358594.0, downloadingError: nil, uploadingError: nil, hasUnresolvedConflicts: false)) > > --- 2. The FileManagere calls the `trashItem` to move the file from the OM iCloud directory to the Trach (Recently Deleted in the Files app) > I(12) 8536.75993 SynchronizationFileWriter.swift:129 removeFromCloudContainer(_:completion:): Trash file TARGET_FILE.kml to the iCloud trash > --- 3. The file is successfully trashed > > I(1) 8536.77919 Classes/MapsAppDelegate.mm:172 -[MapsAppDelegate applicationWillResignActive:]: applicationWillResignActive - begin > I(1) 8536.78172 Location/MWMLocationManager.mm:580 -[MWMLocationManager stop]: Stop updating location > I(1) 8536.78719 Classes/MapsAppDelegate.mm:185 -[MapsAppDelegate applicationWillResignActive:]: applicationWillResignActive - end > I(1) 8537.65270 Classes/MapsAppDelegate.mm:155 -[MapsAppDelegate applicationDidEnterBackground:]: applicationDidEnterBackground - begin > I(1) 8537.65321 Classes/MapsAppDelegate.mm:168 -[MapsAppDelegate applicationDidEnterBackground:]: applicationDidEnterBackground - end > I(1) 8537.65729 SynchronizaionManager.swift:152 pauseSynchronization(): Pause synchronization > I(1) 8542.60661 map/framework.cpp:1198 MemoryWarning(): MemoryWarning > I(1) 8544.63179 Classes/MapsAppDelegate.mm:189 -[MapsAppDelegate applicationWillEnterForeground:]: applicationWillEnterForeground - begin > I(1) 8544.63485 DeepLinkHandler.swift:72 handleFileImport(url:): handleFileImport: file:///private/var/mobile/Containers/Data/Application/xxx/Documents/Inbox/y.gpx > I(5) 8544.68205 map/bookmark_helpers.cpp:595 SaveKmlFileSafe(): Save kml file of type Text to /var/mobile/Containers/Data/Application/xxx/Documents/bookmarks/x.kml > I(1) 8544.68813 DefaultAlert/MWMDefaultAlert.mm:369 +[MWMDefaultAlert defaultAlertWithTitle:message:rightButtonTitle:leftButtonTitle:rightButtonAction:log:]: Info Alert > I(1) 8545.08362 Classes/MapsAppDelegate.mm:210 -[MapsAppDelegate applicationDidBecomeActive:]: applicationDidBecomeActive - begin > I(1) 8545.09909 Location/MWMLocationManager.mm:548 -[MWMLocationManager startUpdatingLocationFor:]: Start updating location > I(1) 8545.10260 Classes/MapsAppDelegate.mm:227 -[MapsAppDelegate applicationDidBecomeActive:]: applicationDidBecomeActive - end > I(1) 8545.10475 SynchronizaionManager.swift:158 resumeSynchronization(): Resume synchronization > > --- 4. The iCloud sends the newly updated lists of metadata items to the app and the deleted item **exists** in this list > I(1) 8545.12391 CloudDirectoryMonitor.swift:182 queryDidUpdate(_:): Cloud contents (33): > I(1) 8545.12393 CloudDirectoryMonitor.swift:183 queryDidUpdate(_:): fileName: x.kml, lastModified: 1730878743.0 > I(1) 8545.12395 CloudDirectoryMonitor.swift:183 queryDidUpdate(_:): fileName: y.kml, lastModified: 1703881765.0 > ... > I(1) 8545.12455 CloudDirectoryMonitor.swift:183 queryDidUpdate(_:): fileName: a, lastModified: 1736358594.0 > I(1) 8545.12458 CloudDirectoryMonitor.swift:183 queryDidUpdate(_:): fileName: TARGET_FILE.kml, lastModified: 1736358594.0 > I(1) 8545.12460 CloudDirectoryMonitor.swift:184 queryDidUpdate(_:): Added to the cloud content (0): > > --- It contains the deleted file in the list of `updated` items instead of `deleted` > I(1) 8545.12461 CloudDirectoryMonitor.swift:185 queryDidUpdate(_:): Updated in the cloud content (1): > fileName: TARGET_FILE.kml, lastModified: 1736358594.0 > I(1) 8545.12462 CloudDirectoryMonitor.swift:186 queryDidUpdate(_:): Removed from the cloud content (0): > I(1) 8545.12468 SynchronizationStateResolver.swift:74 resolveEvent(_:): Events to process (1): > > --- 5. The File manager attempts to copy the file back from the iCloud to the Local dir > I(1) 8545.12523 SynchronizationStateResolver.swift:75 resolveEvent(_:): createLocalItem(with: Organic_Maps.CloudMetadataItem(fileName: "TARGET_FILE.kml", fileUrl: file:///private/var/mobile/Library/Mobile%20Documents/iCloud~app~organicmaps/Documents/Gro%C3%9Fe%20Striegis.kml, isDownloaded: true, lastModificationDate: 1736358594.0, downloadingError: nil, uploadingError: nil, hasUnresolvedConflicts: false)) > I(13) 8545.20669 SynchronizationFileWriter.swift:66 writeToLocalContainer(_:completion:): Write file TARGET_FILE.kml to the local directory > > --- but there is no file and the manager raises an exception. > > E(1) 8545.25526 SynchronizaionManager.swift:286 processError(_:): System Error: Die Datei „TARGET_FILE.kml“ konnte nicht geöffnet werden, da sie nicht existiert. > I(1) 8545.25528 SynchronizaionManager.swift:139 stopSynchronization(withError:): Stop synchronization > I(1) 8545.25571 SynchronizaionManager.swift:139 stopSynchronization(withError:): Stop synchronization ### Possible reasons Depending on the iOS versions and the platform (ios/macos) when the file is deleted from the iCloud directory the NSMetadata updates may differ and send different info. Sometimes the deleted file appears in the `deleted` list, sometimes at the first update in the `updated` with the new URL (that contains ./Trash in the path) and only after that in the `deleted` list. I will investigate how it works and updated the issue.

This repo is archived. You cannot comment on issues.