[ios] Refactor ElevationProfileVC: update statistics collection UI and move it over the chart #10049

Merged
root merged 1 commit from ios/redesing-elevation-profile into master 2025-02-13 16:14:44 +00:00
Member

This PR slightly changes the Track Place Page UI and refactors a related to the elevation profile code.
These changes are important to continue work on because the TrackRecording PP UI should be readable but fully match with the Track PP UI.

  1. Move the description collection view over the chart (see design with related discussions)
  2. Remove the ElevationProfileViewController stroryboard and implement programmatically (same for the ElevationProfileDescriptionCell)
  3. Remove some unused code from the Chart target
  4. Add isChartViewInfoHidden to show/hide the info view and enable/disable user interaction (will be used for the track recording later)
Before After
image) image
image image
This PR slightly changes the Track Place Page UI and refactors a related to the elevation profile code. These changes are important to continue work on #9942 because the TrackRecording PP UI should be readable but fully match with the Track PP UI. 1. Move the description collection view over the chart (see [design](https://www.figma.com/design/5R5LmdM6L4GyfWjSrtlFqZ/OM-Track-Recoding-by-KK?node-id=0-1&t=4uYyqlATrBRgHlZ6-1) with related discussions) 2. Remove the `ElevationProfileViewController` stroryboard and implement programmatically (same for the ElevationProfileDescriptionCell) 3. Remove some unused code from the `Chart` target 4. Add `isChartViewInfoHidden` to show/hide the info view and enable/disable user interaction (will be used for the track recording later) | Before | After | | --- | --- | | <img width="300" alt="image" src="https://github.com/user-attachments/assets/f23664b3-4ab8-49e2-8438-e2de3f3153ca" />) | <img width="300" alt="image" src="https://github.com/user-attachments/assets/bf93394d-6a8a-42b8-9a07-ede76254cbdd" /> | | <img width="300" alt="image" src="https://github.com/user-attachments/assets/01131dc7-c42d-448a-8391-4b0cf0e834ca" /> | <img width="300" alt="image" src="https://github.com/user-attachments/assets/fa01c899-f5d3-4663-808a-ae4d2daa548d" /> |
biodranik (Migrated from github.com) reviewed 2025-01-10 14:51:05 +00:00
rtsisyk reviewed 2025-01-10 14:51:05 +00:00
pastk reviewed 2025-01-10 14:51:05 +00:00
oleg-rswll reviewed 2025-01-10 14:51:05 +00:00
vng (Migrated from github.com) approved these changes 2025-01-14 16:01:25 +00:00
vng (Migrated from github.com) commented 2025-01-14 15:57:02 +00:00

Is there something interesting to use .zero instead of 0 ? :)

Is there something interesting to use .zero instead of 0 ? :)
Dariton4000 (Migrated from github.com) approved these changes 2025-02-06 06:09:44 +00:00
This repo is archived. You cannot comment on pull requests.
No labels
Accessibility
Accessibility
Address
Address
Android
Android
Android Auto
Android Auto
Android Automotive (AAOS)
Android Automotive (AAOS)
API
API
AppGallery
AppGallery
AppStore
AppStore
Battery and Performance
Battery and Performance
Blocker
Blocker
Bookmarks and Tracks
Bookmarks and Tracks
Borders
Borders
Bug
Bug
Build
Build
CarPlay
CarPlay
Classificator
Classificator
Community
Community
Core
Core
CrashReports
CrashReports
Cycling
Cycling
Desktop
Desktop
DevEx
DevEx
DevOps
DevOps
dev_sandbox
dev_sandbox
Directions
Directions
Documentation
Documentation
Downloader
Downloader
Drape
Drape
Driving
Driving
Duplicate
Duplicate
Editor
Editor
Elevation
Elevation
Enhancement
Enhancement
Epic
Epic
External Map Datasets
External Map Datasets
F-Droid
F-Droid
Fonts
Fonts
Frequently User Reported
Frequently User Reported
Fund
Fund
Generator
Generator
Good first issue
Good first issue
Google Play
Google Play
GPS
GPS
GSoC
GSoC
iCloud
iCloud
Icons
Icons
iOS
iOS
Legal
Legal
Linux Desktop
Linux Desktop
Linux packaging
Linux packaging
Linux Phone
Linux Phone
Mac OS
Mac OS
Map Data
Map Data
Metro
Metro
Navigation
Navigation
Need Feedback
Need Feedback
Night Mode
Night Mode
NLnet 2024-06-281
NLnet 2024-06-281
No Feature Parity
No Feature Parity
Opening Hours
Opening Hours
Outdoors
Outdoors
POI Info
POI Info
Privacy
Privacy
Public Transport
Public Transport
Raw Idea
Raw Idea
Refactoring
Refactoring
Regional
Regional
Regression
Regression
Releases
Releases
RoboTest
RoboTest
Route Planning
Route Planning
Routing
Routing
Ruler
Ruler
Search
Search
Security
Security
Styles
Styles
Tests
Tests
Track Recording
Track Recording
Translations
Translations
TTS
TTS
UI
UI
UX
UX
Walk Navigation
Walk Navigation
Watches
Watches
Web
Web
Wikipedia
Wikipedia
Windows
Windows
Won't fix
Won't fix
World Map
World Map
No milestone
No project
No assignees
5 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps-tmp#10049
No description provided.