[POI Info]: social networks links aren't parsed correctly #1397

New issue

Closed

opened 2021-10-10 06:43:59 +00:00 by PetbkA · 4 comments

PetbkA commented

2021-10-10 06:43:59 +00:00

(Migrated from github.com)

App: 2021.10.09-2-Google
OS: LineageOS 17.1 (Android 10.0)

According to OSM Wiki for contact tag for social networks (at least, for Facebook and VK),

The value is the Page-/Profil-URL or the Pagename.

OM correctly parses only the latter, e.g. if link on VK will be pasted, we'll get https://vk.com/https://vk.com in POI info

**App:** 2021.10.09-2-Google **OS**: LineageOS 17.1 (Android 10.0) According to OSM Wiki for `contact` tag for social networks (at least, for [Facebook](https://wiki.openstreetmap.org/wiki/Key:contact:facebook) and [VK](https://wiki.openstreetmap.org/wiki/Key:contact:vk)), > The value is **the Page-/Profil-URL** or the Pagename. OM correctly parses only the latter, e.g. if link on VK will be pasted, we'll get `https://vk.com/https://vk.com` in POI info

biodranik commented

2021-11-09 21:49:59 +00:00

(Migrated from github.com)

@strump Can you please check this one?

strump commented

2021-11-10 07:38:20 +00:00

Member

@biodranik The root cause of the problem is that Android editor uses EditableMapObject which is located in "indexer" project, while MetadataTagProcessor::ValidateAndFormat_vk is part of "generator" project (see comment in my PR).

What's the best way to clean VK/Facebook/Instagram/Twitter links the same way as generator_tool cleans OSM data?

@biodranik The root cause of the problem is that Android editor uses `EditableMapObject` which is located in "indexer" project, while `MetadataTagProcessor::ValidateAndFormat_vk` is part of "generator" project (see [comment in my PR](https://git.omaps.dev/organicmaps/organicmaps/pulls/1196#discussion_r713718499)). What's the best way to clean VK/Facebook/Instagram/Twitter links the same way as generator_tool cleans OSM data?

biodranik commented

2021-11-11 14:18:04 +00:00

(Migrated from github.com)

@strump please move the common code into the indexer library, and call it from generator. Also leave a comment that these methods are needed at runtime and at generation time.