organicmaps/organicmaps-tmp

Archived

Fork 1

Searching for "toilet" or "bathroom" doesn't include amenity=toilets in the results #1462

New issue

Closed

opened 2021-10-24 05:56:17 +00:00 by squeak9 · 12 comments

squeak9 commented

2021-10-24 05:56:17 +00:00

(Migrated from github.com)

This seems like an oversight, currently it only shows results for toilets=yes (wiki) and not amenity=toilets (wiki) which is the tag for public toilets and not just if a feature has a toilet or not.

Please include amenity=toilets into the results.

While you're at it consider displaying information from the tags that further describes the public restroom like changing_table=*, wheelchair=*, access=customers and fee=* cause these are tags that streetcomplete users constantly contribute to the map.

This seems like an oversight, currently it only shows results for `toilets=yes` ([wiki](https://wiki.openstreetmap.org/wiki/Key:toilets)) and not `amenity=toilets` ([wiki](https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dtoilets)) which is the tag for public toilets and not just if a feature has a toilet or not. Please include `amenity=toilets` into the results. While you're at it consider displaying information from the tags that further describes the public restroom like `changing_table=*`, `wheelchair=*`, `access=customers` and `fee=*` cause these are tags that [streetcomplete users constantly contribute to the map](https://wiki.openstreetmap.org/wiki/StreetComplete/Quests#Released_quest_types).

biodranik commented

2021-10-24 06:47:38 +00:00

(Migrated from github.com)

@vng do we really ignore amenity=toilets?

@vng do we really ignore `amenity=toilets`?

vng commented

2021-10-24 10:56:39 +00:00

(Migrated from github.com)

We do search for amenity=toilets. Better to check it like "Show on map".
Current ranking in search is bad (on my opinion) and first results in list will be POIs with names and toilet=yes.
Public toilets will be at the end of the list despite of the distance. This is bad and we already have a bunch of issues with search ranking ...

We do search for amenity=toilets. Better to check it like "Show on map". Current ranking in search is bad _(on my opinion)_ and first results in list will be POIs with names and toilet=yes. Public toilets will be at the end of the list despite of the distance. This is bad and we already have a bunch of issues with search ranking ...

squeak9 commented

2021-10-24 19:28:06 +00:00

(Migrated from github.com)

Ah, you're right! They do show on the map, didn't think to check that.

They do show in the list also but you have to scroll like you said, the unnamed toiled 1km away was below the named place with toilets 50km away..

Thanks for clearing that up, hope you fix the search rankings later on but I guess that's a larger issue.

Ah, you're right! They do show on the map, didn't think to check that. They do show in the list also but you have to scroll like you said, the unnamed toiled 1km away was below the named place with toilets 50km away.. Thanks for clearing that up, hope you fix the search rankings later on but I guess that's a larger issue.

Outlet2048 commented

2021-10-24 21:07:19 +00:00

(Migrated from github.com)

While we're at it:

https://wiki.openstreetmap.org/wiki/Tag:building%3Dtoilets

Building=toilets should be added as well

That tag can be set by streetcomplete users who answer the building quest
Therefore there might be buildings tagged as toilets with no extra toilet tag added as POI inside of the buildings

Which is why I believe this tag should be included when searching for toilets

While we're at it: https://wiki.openstreetmap.org/wiki/Tag:building%3Dtoilets Building=toilets should be added as well That tag can be set by streetcomplete users who answer the building quest Therefore there might be buildings tagged as toilets with no extra toilet tag added as POI inside of the buildings Which is why I believe this tag should be included when searching for toilets

biodranik commented

2021-10-25 08:18:44 +00:00

(Migrated from github.com)

It is incorrect from the OSM point of view to show building= objects as amenity=
It would be great if streetcomplete will properly add amenity= to toilets.

It is incorrect from the OSM point of view to show building= objects as amenity= It would be great if streetcomplete will properly add amenity= to toilets.

Outlet2048 commented

2021-10-25 08:23:37 +00:00

(Migrated from github.com)

Even though it is incorrect to tag it that way, this currently seems to be the case
Wouldn't supporting the tag be an option regardless?

Even though it is incorrect to tag it that way, this currently seems to be the case Wouldn't supporting the tag be an option regardless?

biodranik commented

2021-10-25 09:15:15 +00:00

(Migrated from github.com)

Ideally, it would be great to avoid supporting incorrect tagging and fix the problem in the core instead.

Outlet2048 commented

2021-10-25 10:06:40 +00:00

(Migrated from github.com)

https://github.com/streetcomplete/StreetComplete/issues/3398
Seems like the proposal was denied by the devs

https://github.com/streetcomplete/StreetComplete/issues/3398 Seems like the proposal was denied by the devs

matkoniecz commented

2021-11-15 15:40:32 +00:00

(Migrated from github.com)

Building=toilets should be added as well

definitely no, as it includes also disused toilet buildings, private toilets (say separate toilet building on stadium inaccessible to general public and used only by players) etc.

(I am one of StreetComplete contributors)

> Building=toilets should be added as well definitely no, as it includes also disused toilet buildings, private toilets (say separate toilet building on stadium inaccessible to general public and used only by players) etc. (I am one of StreetComplete contributors)

pastk commented

2021-12-01 11:33:24 +00:00

Owner

We do search for amenity=toilets. Better to check it like "Show on map". Current ranking in search is bad (on my opinion) and first results in list will be POIs with names and toilet=yes. Public toilets will be at the end of the list despite of the distance. This is bad and we already have a bunch of issues with search ranking ...

Do we really support toilets=yes? It doesn't show up as an extension of other types in types_strings.txt like its done with some some other attributes e.g. amenity.parking.private or natural.beach.gravel

Update: we do support it via data/replaced_tags.txt: toilets=yes : amenity=toilets

> We do search for amenity=toilets. Better to check it like "Show on map". Current ranking in search is bad _(on my opinion)_ and first results in list will be POIs with names and toilet=yes. Public toilets will be at the end of the list despite of the distance. This is bad and we already have a bunch of issues with search ranking ... Do we really support [toilets=yes](https://wiki.openstreetmap.org/wiki/Key:toilets)? It doesn't show up as an extension of other types in `types_strings.txt` like its done with some some other attributes e.g. `amenity.parking.private` or `natural.beach.gravel` Update: we do support it via `data/replaced_tags.txt`: `toilets=yes : amenity=toilets`

pastk commented

2021-12-01 11:35:45 +00:00

Owner

Just to link here related issues: #1301 and #979
Upd: and #1648

Just to link here related issues: #1301 and #979 Upd: and #1648

pastk commented

2022-01-28 19:36:30 +00:00

Owner

To be done as part of #1376

This repo is archived. You cannot comment on issues.