[search] Searching for "water" miss many water source types - important for hiking use #1621

New issue

Closed

opened 2021-11-27 10:12:28 +00:00 by pastk · 3 comments

pastk commented

2021-11-27 10:12:28 +00:00

Owner

"water" search result only in type.natural.water.* like "water", "lake", "reservoir".
But it doesn't result (neither in the list, nor on the map) in "drinking water", "water tap", "spring", "water well", "drinking fountain" types.

Likewise, searching for e.g. "drinking water" will not show "water tap", "spring" etc.

For hiking use its really important to be able to search for all available water sources around.
Maybe we need to maintain a list of synonims for some popular/important search terms?

(it'll be great to distinguish between potable/non-potable water as well by maybe using different icons - but that's a further improvement, first thing a search needs to be fixed)

"water" search result only in `type.natural.water.*` like "water", "lake", "reservoir". But it doesn't result (neither in the list, nor on the map) in "drinking water", "water tap", "spring", "water well", "drinking fountain" types. Likewise, searching for e.g. "drinking water" will not show "water tap", "spring" etc. For hiking use its really important to be able to search for all available water sources around. Maybe we need to maintain a list of synonims for some popular/important search terms? (it'll be great to distinguish between potable/non-potable water as well by maybe using different icons - but that's a further improvement, first thing a search needs to be fixed)

👍 1

biodranik commented

2021-11-27 18:15:54 +00:00

(Migrated from github.com)

The list of synonyms is defined in data/categories.txt

pastk commented

2021-11-28 17:31:11 +00:00

Author

Owner

I propose following changes. Its mainly targeted to outdoors use, but will be an improvement for urban use as well.

Add "Water" to the "categories" list in search screen (in the bottom of the list, in between Entertainment and Hospital maybe).

That "Water" search shall result in all water sources with a likely drinkable water:

amenity=drinking_water
amenity=water_point
man_made=water_tap
man_made=water_well
natural=spring

Bigger bodies of water like rivers, lakes, ponds etc. should not be included as they are quite big and obvious terrain features on the map anyway (it'll be possible to search for them using their own terms like "lake" still).

A search for "drinking/potable water" shall result in amenity=drinking_water only.
As I understand we don't have a drinking_water=* attribute available in OM map files? If we do, then we can add other types with a drinking_water=yes to this search.

I don't think that the "water" search should result in confirmed drinkable (amenity=drinking_water) sources only, because

a lot of other sources are actually drinkable (but not marked) or conditionally drinkable (e.g. after a boil)
technical water is important in outdoors also (doing dishes, washing, rinsing stuff...)
there is no obvious way to search for "all water" if the "water" term is reserved for drinkable only

I'll prep the changes in categories.txt.

Feedback?
@biodranik

I propose following changes. Its mainly targeted to outdoors use, but will be an improvement for urban use as well. Add "Water" to the "categories" list in search screen (in the bottom of the list, in between Entertainment and Hospital maybe). That "Water" search shall result in all water sources with a likely drinkable water: ``` amenity=drinking_water amenity=water_point man_made=water_tap man_made=water_well natural=spring ``` Bigger bodies of water like rivers, lakes, ponds etc. should not be included as they are quite big and obvious terrain features on the map anyway (it'll be possible to search for them using their own terms like "lake" still). A search for "drinking/potable water" shall result in `amenity=drinking_water` only. As I understand we don't have a [drinking_water=*](https://wiki.openstreetmap.org/wiki/Key:drinking_water) attribute available in OM map files? If we do, then we can add other types with a `drinking_water=yes` to this search. I don't think that the "water" search should result in confirmed drinkable (`amenity=drinking_water`) sources only, because - a lot of other sources are actually drinkable (but not marked) or conditionally drinkable (e.g. after a boil) - technical water is important in outdoors also (doing dishes, washing, rinsing stuff...) - there is no obvious way to search for "all water" if the "water" term is reserved for drinkable only I'll prep the changes in `categories.txt`. Feedback? @biodranik

👍 1

biodranik commented

2021-11-28 20:58:55 +00:00

(Migrated from github.com)

Approved.

This repo is archived. You cannot comment on issues.