organicmaps/organicmaps-tmp

Archived

Fork 1

Bundled minizip does not compile when zlib is installed and the workaround is gone #1752

New issue

Open

opened 2021-12-28 18:47:31 +00:00 by l29ah · 9 comments

l29ah commented

2021-12-28 18:47:31 +00:00

(Migrated from github.com)

Basically, https://github.com/mapsme/omim/issues/3808 is still there, but additionally in case of the suggested unbundling of minizip the following error occurs:

[ 21%] Building CXX object coding/CMakeFiles/coding.dir/zip_creator.cpp.o
cd /var/tmp/portage/sci-geosciences/organicmaps-9999/work/organicmaps-9999_build/coding && /usr/bin/ccache /usr/bin/ccache /usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -DRELEASE -DUCONFIG_USE_LOCAL -Dcoding_EXPORTS -I/var/tmp/portage/sci-geosciences/organicmaps-9999/work/organicmaps-9999 -I/var/tmp/portage/sci-geosciences/organicmaps-9999/work/organicmaps-9999/3party/boost -I/var/tmp/portage/sci-geosciences/organicmaps-9999/work/organicmaps-9999/3party/expat/expat/lib -I/var/tmp/portage/sci-geosciences/organicmaps-9999/work/organicmaps-9999_build/3party/expat/expat -I/var/tmp/portage/sci-geosciences/organicmaps-9999/work/organicmaps-9999/3party/icu/. -I/var/tmp/portage/sci-geosciences/organicmaps-9999/work/organicmaps-9999/3party/icu/icu/icu4c/source/common -I/var/tmp/portage/sci-geosciences/organicmaps-9999/work/organicmaps-9999/3party/icu/icu/icu4c/source/i18n -I/var/tmp/portage/sci-geosciences/organicmaps-9999/work/organicmaps-9999/3party/liboauthcpp/include  -O2 -pipe -march=native -ftree-vectorize -malign-data=cacheline -mtls-dialect=gnu2 -fPIC -fdiagnostics-color=always -ffast-math -Ofast -Wall -Wextra -Wno-unused-parameter -MD -MT coding/CMakeFiles/coding.dir/zip_creator.cpp.o -MF CMakeFiles/coding.dir/zip_creator.cpp.o.d -o CMakeFiles/coding.dir/zip_creator.cpp.o -c /var/tmp/portage/sci-geosciences/organicmaps-9999/work/organicmaps-9999/coding/zip_creator.cpp
/var/tmp/portage/sci-geosciences/organicmaps-9999/work/organicmaps-9999/coding/zip_creator.cpp:13:10: fatal error: minizip/minizip.hpp: No such file or directory
   13 | #include "minizip/minizip.hpp"
      |          ^~~~~~~~~~~~~~~~~~~~~

Indeed, zlib (no longer?) ships such a header:

$ ls /usr/include/minizip 
ioapi.h  mztools.h  unzip.h  zip.h

I'm trying to package organicmaps for Gentoo if it matters.

Basically, https://github.com/mapsme/omim/issues/3808 is still there, but additionally in case of the suggested unbundling of minizip the following error occurs: ``` [ 21%] Building CXX object coding/CMakeFiles/coding.dir/zip_creator.cpp.o cd /var/tmp/portage/sci-geosciences/organicmaps-9999/work/organicmaps-9999_build/coding && /usr/bin/ccache /usr/bin/ccache /usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -DRELEASE -DUCONFIG_USE_LOCAL -Dcoding_EXPORTS -I/var/tmp/portage/sci-geosciences/organicmaps-9999/work/organicmaps-9999 -I/var/tmp/portage/sci-geosciences/organicmaps-9999/work/organicmaps-9999/3party/boost -I/var/tmp/portage/sci-geosciences/organicmaps-9999/work/organicmaps-9999/3party/expat/expat/lib -I/var/tmp/portage/sci-geosciences/organicmaps-9999/work/organicmaps-9999_build/3party/expat/expat -I/var/tmp/portage/sci-geosciences/organicmaps-9999/work/organicmaps-9999/3party/icu/. -I/var/tmp/portage/sci-geosciences/organicmaps-9999/work/organicmaps-9999/3party/icu/icu/icu4c/source/common -I/var/tmp/portage/sci-geosciences/organicmaps-9999/work/organicmaps-9999/3party/icu/icu/icu4c/source/i18n -I/var/tmp/portage/sci-geosciences/organicmaps-9999/work/organicmaps-9999/3party/liboauthcpp/include -O2 -pipe -march=native -ftree-vectorize -malign-data=cacheline -mtls-dialect=gnu2 -fPIC -fdiagnostics-color=always -ffast-math -Ofast -Wall -Wextra -Wno-unused-parameter -MD -MT coding/CMakeFiles/coding.dir/zip_creator.cpp.o -MF CMakeFiles/coding.dir/zip_creator.cpp.o.d -o CMakeFiles/coding.dir/zip_creator.cpp.o -c /var/tmp/portage/sci-geosciences/organicmaps-9999/work/organicmaps-9999/coding/zip_creator.cpp /var/tmp/portage/sci-geosciences/organicmaps-9999/work/organicmaps-9999/coding/zip_creator.cpp:13:10: fatal error: minizip/minizip.hpp: No such file or directory 13 | #include "minizip/minizip.hpp" | ^~~~~~~~~~~~~~~~~~~~~ ``` Indeed, zlib (no longer?) ships such a header: ``` $ ls /usr/include/minizip ioapi.h mztools.h unzip.h zip.h ``` I'm trying to package organicmaps for Gentoo if it matters.

👍 1

biodranik commented

2021-12-28 20:42:53 +00:00

(Migrated from github.com)

Please do not use system minizip. Use our version instead. This hpp file is our file, not a system one.

biodranik commented

2021-12-28 20:44:26 +00:00

(Migrated from github.com)

How are you buildng the app? Please share your full configure and build logs.

l29ah commented

2021-12-28 22:05:24 +00:00

(Migrated from github.com)

Please do not use system minizip.

How are you buildng the app?

# Unknown build type: Gentoo
CMAKE_BUILD_TYPE=RelWithDebInfo
# build.ninja:16154: bad $-escape (literal $ must be written as $$)
CMAKE_MAKEFILE_GENERATOR=emake

src_prepare() {
	cmake-utils_src_prepare
}

src_configure() {
	echo | ./configure.sh

	cmake-utils_src_configure
}

Please share your full configure and build logs.

build.log

> Please do not use system minizip. ok > How are you buildng the app? ``` # Unknown build type: Gentoo CMAKE_BUILD_TYPE=RelWithDebInfo # build.ninja:16154: bad $-escape (literal $ must be written as $$) CMAKE_MAKEFILE_GENERATOR=emake src_prepare() { cmake-utils_src_prepare } src_configure() { echo | ./configure.sh cmake-utils_src_configure } ``` > Please share your full configure and build logs. [build.log](https://github.com/organicmaps/organicmaps/files/7786514/build.log)

biodranik commented

2021-12-29 07:31:36 +00:00

(Migrated from github.com)

You don't need echo | now to run configure.sh
Does tools/unix/build_omim.sh -r desktop work?
What is wrong with ninja? Can you please provide a full build log with ninja -v?
Do you use the latest cmake 3.18+ ?

1. You don't need echo | now to run configure.sh 2. Does `tools/unix/build_omim.sh -r desktop` work? 3. What is wrong with ninja? Can you please provide a full build log with `ninja -v`? 4. Do you use the latest cmake 3.18+ ?

biodranik commented

2021-12-29 09:43:38 +00:00

(Migrated from github.com)

What is in your gentoo_toolchain.cmake and gentoo_common_config.cmake? I think your issues are rooted there.

uis246 commented

2022-02-26 09:30:36 +00:00

(Migrated from github.com)

I'm trying to package organicmaps for Gentoo if it matters.

zlib on gentoo has use-flag minizip. And it almost always set. No need in bundled minizip.

> I'm trying to package organicmaps for Gentoo if it matters. zlib on gentoo has use-flag minizip. And it almost always set. No need in bundled minizip.

👍 1

vitaly-zdanevich commented

2022-03-06 08:38:28 +00:00

(Migrated from github.com)

I'm trying to package organicmaps for Gentoo if it matters.

Thank you!

> I'm trying to package organicmaps for Gentoo if it matters. Thank you!

hrnick commented

2022-06-15 12:46:46 +00:00

(Migrated from github.com)

@l29ah: I've built Organic Maps on Gentoo with USE="minizip" zlib successfully using an ebuild in a local repository. Do you still have this issue?

Creating an ebuild for Gentoo is being discussed in organicmaps/organicmaps#2217.

@l29ah: I've built Organic Maps on Gentoo with USE="minizip" zlib successfully using an ebuild in a local repository. Do you still have this issue? Creating an ebuild for Gentoo is being discussed in https://git.omaps.dev/organicmaps/organicmaps/issues/2217.

uis246 commented

2022-06-15 16:00:01 +00:00

(Migrated from github.com)

@l29ah: I've built Organic Maps on Gentoo with USE="minizip" zlib successfully using an ebuild in a local repository. Do you still have this issue?

I've built long time ago too. With removal of 3party/minizip/src. 3party/minizip should be kept because this actually isn't minizip's code.

> @l29ah: I've built Organic Maps on Gentoo with USE="minizip" zlib successfully using an ebuild in a local repository. Do you still have this issue? I've built long time ago too. With removal of `3party/minizip/src`. `3party/minizip` should be kept because this actually isn't minizip's code.

This repo is archived. You cannot comment on issues.