Fix roads/paths selection by long tap #1847

New issue

Closed

opened 2022-01-13 11:44:56 +00:00 by pastk · 4 comments

pastk commented

2022-01-13 11:44:56 +00:00

Owner

Selection works fine if there is no "background":

However if there is e.g. natural=wood or landuse=allotments/farmland/etc area in the background then the area type wrongly takes precedence:

Way-like features should have a priority over area-like ones.

When all (most) of the displayed features are selectable it'll help close the "Where is the map legend?" case.

Selection works fine if there is no "background": ![road_sel_road](https://user-images.githubusercontent.com/18434508/149323772-aa7963cf-2789-4547-8385-637f62e091bd.png) However if there is e.g. `natural=wood` or `landuse=allotments/farmland/etc` area in the background then the area type wrongly takes precedence: ![road_sel_forest](https://user-images.githubusercontent.com/18434508/149323778-53ccae62-3b25-4ab6-bce0-e1f57a8be033.png) Way-like features should have a priority over area-like ones. When all (most) of the displayed features are selectable it'll help close the "Where is the map legend?" case.

biodranik commented

2022-01-13 11:51:10 +00:00

(Migrated from github.com)

Here all types should be displayed, Minor Road * Forest.

pastk commented

2022-01-14 07:40:00 +00:00

Author

Owner

Here all types should be displayed, Minor Road * Forest.

There are two things here.
We don't do it in other situations, e.g. we don't display "Power Tower * Farmland" or "Water Tap * Forest" or "Cafe * Retail Land".
It won't be as easy to do as those types belong to different features and the current PP filling code operates on a single selected feature only (map/place_page_info.cpp:Info::SetFromFeatureType).

> Here all types should be displayed, Minor Road * Forest. There are two things here. We don't do it in other situations, e.g. we don't display "Power Tower * Farmland" or "Water Tap * Forest" or "Cafe * Retail Land". It won't be as easy to do as those types belong to different features and the current PP filling code operates on a single selected feature only (`map/place_page_info.cpp:Info::SetFromFeatureType`).

biodranik commented

2022-01-14 07:42:43 +00:00

(Migrated from github.com)

Ok. Then we need to do what users expect from the selection.

pastk commented

2022-01-14 08:25:14 +00:00

Author

Owner

Displaying additional types makes perfect sense when they're hidden/undiscoverable by the user otherwise, e.g. in POIs with many types.
But in this situation the "background" type is visible (and selectable also) in the viewport, so its present there in the UX context already.

Displaying additional types makes perfect sense when they're hidden/undiscoverable by the user otherwise, e.g. in POIs with many types. But in this situation the "background" type is visible (and selectable also) in the viewport, so its present there in the UX context already.

This repo is archived. You cannot comment on issues.