[android] Remove space for icons in Settings #1924

Merged

stloeffler merged 2 commits from settings-padding into master

2022-01-23 21:08:37 +00:00

stloeffler commented

2022-01-22 10:26:57 +00:00

(Migrated from github.com)

Override the the iconSpaceReserved property specified in the Android sources as none of the Settings items has an icon; hence the space is wasted and leads to the truncation of item names and descriptions. Inspired by https://stackoverflow.com/a/52960668.

Closes #1872

Override the the iconSpaceReserved property specified in [the Android sources](https://cs.android.com/android/platform/superproject/+/android-12.0.0_r4:prebuilts/sdk/current/support/v7/preference/res/values-sw360dp-v13/values-sw360dp-v13.xml) as none of the Settings items has an icon; hence the space is wasted and leads to the truncation of item names and descriptions. Inspired by https://stackoverflow.com/a/52960668. Closes #1872

👍 2

biodranik commented

2022-01-22 21:28:02 +00:00

(Migrated from github.com)

Thanks! Did you try this non-hacky fix? https://stackoverflow.com/a/55987124/1209392

It would be also great to insert a comment into the XML with the description, why is it needed, and with a link.

Thanks! Did you try this non-hacky fix? https://stackoverflow.com/a/55987124/1209392 It would be also great to insert a comment into the XML with the description, why is it needed, and with a link.

stloeffler commented

2022-01-23 07:15:27 +00:00

(Migrated from github.com)

By "insert a comment [...] with a link", do you mean a link to StackOverflow, to the Android sources, to the GitHub issue, or something else? (Note that there is some controversy about StackOverflow code licensing, see e.g. here and references therein).

I did try the "non-hacky" fix as well and it works. However, it needs to be added to each item in the preferences XML separately. I.e., if a new preferences item is added, it will be indented by default unless iconSpaceReserved is manually set to false. By overriding the default as in the current version of the PR, this does not happen - all items (old and new) are unindented by default. However, if you prefer the non-hacky fix, I could easily adapt the PR. By "insert a comment [...] with a link", do you mean a link to StackOverflow, to the Android sources, to the GitHub issue, or something else? (Note that there is some controversy about StackOverflow code licensing, see e.g. [here](https://softwareengineering.stackexchange.com/questions/170185/is-creative-commons-license-compatible-with-apache-license) and references therein).

biodranik commented

2022-01-23 07:42:18 +00:00

(Migrated from github.com)

Less work is better. We can merge the "hacky" fix, but please add a comment to it with a link to this issue.

stloeffler commented

2022-01-23 09:26:55 +00:00

(Migrated from github.com)

I added the comment (with description, rational, links, etc.).

biodranik (Migrated from github.com) approved these changes 2022-01-23 10:57:25 +00:00

biodranik (Migrated from github.com) left a comment

Awesome, thanks!

This repo is archived. You cannot comment on pull requests.